511kinderheim/device_xiaomi_sm6150-common
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

davinci: fod: Improve semantics

Browse Source 
* do not use (void) to silence unused parameters
 * do not specify namespace for IFingerprintInscreenCallback

Change-Id: Ife9d0799a091c539028f775a728d2c8c31ffbf98
This commit is contained in:
Demon000 2019-12-31 01:06:45 +01:00 committed by Arian
parent c89dcfb0df
commit e456f36fe1
No known key found for this signature in database
GPG Key ID: 48029380598CE3B9
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fod/FingerprintInscreen.cpp
View File

@ -126,7 +126,7 @@ Return<void> FingerprintInscreen::setLongPressEnabled(bool) {
return Void(); return Void();
} }
Return<int32_t> FingerprintInscreen::getDimAmount(int32_t brightness) { Return<int32_t> FingerprintInscreen::getDimAmount(int32_t /* brightness */) {
int realBrightness = get(BRIGHTNESS_PATH, 0); int realBrightness = get(BRIGHTNESS_PATH, 0);
float alpha; float alpha;
@ -136,8 +136,6 @@ Return<int32_t> FingerprintInscreen::getDimAmount(int32_t brightness) {
alpha = 1.0 - pow(realBrightness / 1680.0, 0.455); alpha = 1.0 - pow(realBrightness / 1680.0, 0.455);
} }
(void) brightness;
return 255 * alpha; return 255 * alpha;
} }
@ -145,8 +143,7 @@ Return<bool> FingerprintInscreen::shouldBoostBrightness() {
return false; return false;
} }
Return<void> FingerprintInscreen::setCallback(const sp<::vendor::lineage::biometrics::fingerprint::inscreen::V1_0::IFingerprintInscreenCallback>& callback) { Return<void> FingerprintInscreen::setCallback(const sp<IFingerprintInscreenCallback>& /* callback */) {
(void) callback;
return Void(); return Void();
} }

2
fod/FingerprintInscreen.h
View File

@ -50,7 +50,7 @@ public:
Return<void> setLongPressEnabled(bool enabled) override; Return<void> setLongPressEnabled(bool enabled) override;
Return<int32_t> getDimAmount(int32_t brightness) override; Return<int32_t> getDimAmount(int32_t brightness) override;
Return<bool> shouldBoostBrightness() override; Return<bool> shouldBoostBrightness() override;
Return<void> setCallback(const sp<::vendor::lineage::biometrics::fingerprint::inscreen::V1_0::IFingerprintInscreenCallback>& callback) override; Return<void> setCallback(const sp<IFingerprintInscreenCallback>& callback) override;
private: private:
sp<IXiaomiFingerprint> xiaomiFingerprintService; sp<IXiaomiFingerprint> xiaomiFingerprintService;