Fixed a crash

2021-01-04 19:45:48 +01:00
parent 3c0c48c00c
commit a233915064
3 changed files with 12 additions and 7 deletions
@@ -492,13 +492,14 @@ void LocalFileTransfer::execute_disk_io(const std::shared_ptr<FileClient> &clien
                            assert(client->disk_buffer.bytes >= written);
                            client->disk_buffer.bytes -= written;
                            buffer_left_size = client->disk_buffer.bytes;
+
+                            /* We have to deref the buffer twice since we've removed it from the list which owns us one reference */
+                            /* Will not trigger a memory free since we're still holding onto one reference */
+                            deref_buffer(buffer);
                        } else {
                            /* The buffer got removed */
                        }
                    }
-
-                    /* We have to deref the buffer twice since we've removed it from the list which owns us one reference */
-                    deref_buffer(buffer);
                } else {
                    std::lock_guard block{client->disk_buffer.mutex};
                    if(client->disk_buffer.buffer_head == buffer) {