From 11ee6834f6fbb0dd7bf6a5d1ba7ba30decdc8f84 Mon Sep 17 00:00:00 2001 From: Colin Duquesnoy Date: Sat, 10 Feb 2018 15:15:46 +0100 Subject: [PATCH] Fix compilation error with GCC 8 error: need 'typename' before 'std::conditional::value, fmt::BasicMemoryWriter, fmt::BasicMemoryWriter >::type' because 'std::conditional::value, fmt::BasicMemoryWriter, fmt::BasicMemoryWriter >' is a dependent scope std::conditional::value, fmt::MemoryWriter, fmt::WMemoryWriter>::type w; --- include/spdlog/sinks/file_sinks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/spdlog/sinks/file_sinks.h b/include/spdlog/sinks/file_sinks.h index e7856172..e13c81a6 100644 --- a/include/spdlog/sinks/file_sinks.h +++ b/include/spdlog/sinks/file_sinks.h @@ -81,7 +81,7 @@ public: // e.g. calc_filename("logs/mylog.txt, 3) => "logs/mylog.3.txt". static filename_t calc_filename(const filename_t& filename, std::size_t index) { - std::conditional::value, fmt::MemoryWriter, fmt::WMemoryWriter>::type w; + typename std::conditional::value, fmt::MemoryWriter, fmt::WMemoryWriter>::type w; if (index) { filename_t basename, ext;