From 18a0455b9184187bdb4ed60092a1872b778ded9b Mon Sep 17 00:00:00 2001 From: ThePhD Date: Tue, 30 May 2017 18:15:30 -0400 Subject: [PATCH] _pattern was never set... but it was also never used. Intentional by @gabime, or a reflection of a refactor with some data member left behind? --- include/spdlog/details/pattern_formatter_impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/spdlog/details/pattern_formatter_impl.h b/include/spdlog/details/pattern_formatter_impl.h index 55b3912a..38c03fa4 100644 --- a/include/spdlog/details/pattern_formatter_impl.h +++ b/include/spdlog/details/pattern_formatter_impl.h @@ -503,9 +503,9 @@ class full_formatter SPDLOG_FINAL:public flag_formatter // pattern_formatter inline impl /////////////////////////////////////////////////////////////////////////////// inline spdlog::pattern_formatter::pattern_formatter(const std::string& pattern, pattern_time ptime) -: _time(ptime), _pattern(pattern) +: _time(ptime) { - compile_pattern(_pattern, _time); + compile_pattern(pattern, _time); } inline void spdlog::pattern_formatter::compile_pattern(const std::string& pattern, pattern_time ptime)