From 2af5eea2c69d295c4393140d183967f709849677 Mon Sep 17 00:00:00 2001
From: gabime <gmelman1@gmail.com>
Date: Mon, 2 Sep 2019 12:35:33 +0300
Subject: [PATCH] SImplify filename creation in rotating sink

---
 include/spdlog/sinks/rotating_file_sink-inl.h | 20 ++++++++-----------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/include/spdlog/sinks/rotating_file_sink-inl.h b/include/spdlog/sinks/rotating_file_sink-inl.h
index 5e2b1fd9..2e459cbf 100644
--- a/include/spdlog/sinks/rotating_file_sink-inl.h
+++ b/include/spdlog/sinks/rotating_file_sink-inl.h
@@ -43,18 +43,14 @@ SPDLOG_INLINE rotating_file_sink<Mutex>::rotating_file_sink(
 template<typename Mutex>
 SPDLOG_INLINE filename_t rotating_file_sink<Mutex>::calc_filename(const filename_t &filename, std::size_t index)
 {
-    typename std::conditional<std::is_same<filename_t::value_type, char>::value, memory_buf_t, fmt::wmemory_buffer>::type w;
-    if (index != 0u)
-    {
-        filename_t basename, ext;
-        std::tie(basename, ext) = details::file_helper::split_by_extension(filename);
-        fmt::format_to(w, SPDLOG_FILENAME_T("{}.{}{}"), basename, index, ext);
-    }
-    else
-    {
-        fmt::format_to(w, SPDLOG_FILENAME_T("{}"), filename);
-    }
-    return fmt::to_string(w);
+	if(index == 0u)
+	{
+		return filename;
+	}
+
+	filename_t basename, ext;
+    std::tie(basename, ext) = details::file_helper::split_by_extension(filename);
+    return fmt::format(SPDLOG_FILENAME_T("{}.{}{}"), basename, index, ext);
 }
 
 template<typename Mutex>