From 4637cf35df9a7e4dcb40b1affd49cb54360ebd7e Mon Sep 17 00:00:00 2001 From: gabi Date: Mon, 8 Dec 2014 00:55:45 +0200 Subject: [PATCH] Improved perf by using const char* instead of std::string& when accepting format strings --- include/spdlog/details/line_logger.h | 2 +- include/spdlog/details/logger_impl.h | 22 +++++++++++----------- include/spdlog/logger.h | 22 +++++++++++----------- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/spdlog/details/line_logger.h b/include/spdlog/details/line_logger.h index cf54bb79..7160f6da 100644 --- a/include/spdlog/details/line_logger.h +++ b/include/spdlog/details/line_logger.h @@ -71,7 +71,7 @@ public: template - void write(const std::string& fmt, const Args&... args) + void write(const char* fmt, const Args&... args) { if (!_enabled) return; diff --git a/include/spdlog/details/logger_impl.h b/include/spdlog/details/logger_impl.h index 286dde48..3f2360b0 100644 --- a/include/spdlog/details/logger_impl.h +++ b/include/spdlog/details/logger_impl.h @@ -67,7 +67,7 @@ inline void spdlog::logger::set_pattern(const std::string& pattern) // cppformat API of the form logger.info("hello {} {}", "world", 1); // template -inline spdlog::details::line_logger spdlog::logger::_log(level::level_enum lvl, const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::_log(level::level_enum lvl, const char* fmt, const Args&... args) { bool msg_enabled = should_log(lvl); details::line_logger l(this, lvl, msg_enabled); @@ -76,61 +76,61 @@ inline spdlog::details::line_logger spdlog::logger::_log(level::level_enum lvl, } template -inline spdlog::details::line_logger spdlog::logger::log(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::log(const char* fmt, const Args&... args) { return _log(level::ALWAYS, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::trace(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::trace(const char* fmt, const Args&... args) { return _log(level::TRACE, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::debug(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::debug(const char* fmt, const Args&... args) { return _log(level::DEBUG, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::info(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::info(const char* fmt, const Args&... args) { return _log(level::INFO, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::notice(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::notice(const char* fmt, const Args&... args) { return _log(level::NOTICE, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::warn(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::warn(const char* fmt, const Args&... args) { return _log(level::WARN, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::error(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::error(const char* fmt, const Args&... args) { return _log(level::ERR, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::critical(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::critical(const char* fmt, const Args&... args) { return _log(level::CRITICAL, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::alert(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::alert(const char* fmt, const Args&... args) { return _log(level::ALERT, fmt, args...); } template -inline spdlog::details::line_logger spdlog::logger::emerg(const std::string& fmt, const Args&... args) +inline spdlog::details::line_logger spdlog::logger::emerg(const char* fmt, const Args&... args) { return _log(level::EMERG, fmt, args...); } diff --git a/include/spdlog/logger.h b/include/spdlog/logger.h index cc7fb58b..095c34a9 100644 --- a/include/spdlog/logger.h +++ b/include/spdlog/logger.h @@ -65,16 +65,16 @@ public: //Stop logging void stop(); - template details::line_logger log(const std::string& fmt, const Args&... args); - template details::line_logger trace(const std::string& fmt, const Args&... args); - template details::line_logger debug(const std::string& fmt, const Args&... args); - template details::line_logger info(const std::string& fmt, const Args&... args); - template details::line_logger notice(const std::string& fmt, const Args&... args); - template details::line_logger warn(const std::string& fmt, const Args&... args); - template details::line_logger error(const std::string& fmt, const Args&... args); - template details::line_logger critical(const std::string& fmt, const Args&... args); - template details::line_logger alert(const std::string& fmt, const Args&... args); - template details::line_logger emerg(const std::string& fmt, const Args&... args); + template details::line_logger log(const char* fmt, const Args&... args); + template details::line_logger trace(const char* fmt, const Args&... args); + template details::line_logger debug(const char* fmt, const Args&... args); + template details::line_logger info(const char* fmt, const Args&... args); + template details::line_logger notice(const char* fmt, const Args&... args); + template details::line_logger warn(const char* fmt, const Args&... args); + template details::line_logger error(const char* fmt, const Args&... args); + template details::line_logger critical(const char* fmt, const Args&... args); + template details::line_logger alert(const char* fmt, const Args&... args); + template details::line_logger emerg(const char* fmt, const Args&... args); //API to support logger.info() << ".." calls @@ -100,7 +100,7 @@ protected: virtual void _set_formatter(formatter_ptr); virtual void _stop(); details::line_logger _log(level::level_enum lvl); - template details::line_logger _log(level::level_enum lvl, const std::string& fmt, const Args&... args); + template details::line_logger _log(level::level_enum lvl, const char* fmt, const Args&... args); friend details::line_logger;