From 63a475d88c2bf5be21bf6abd4a487909862e97de Mon Sep 17 00:00:00 2001 From: "David P. Sicilia" Date: Tue, 27 Nov 2018 20:23:51 -0500 Subject: [PATCH 1/2] Do not attempt to default operator= when it is implicitly deleted --- include/spdlog/details/log_msg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/spdlog/details/log_msg.h b/include/spdlog/details/log_msg.h index affeb514..5913c3b0 100644 --- a/include/spdlog/details/log_msg.h +++ b/include/spdlog/details/log_msg.h @@ -37,7 +37,6 @@ struct log_msg } log_msg(const log_msg &other) = default; - log_msg &operator=(const log_msg &other) = default; const std::string *logger_name{nullptr}; level::level_enum level{level::off}; From a6152ebadd676d7f5a3a50e49eb995aa05d97112 Mon Sep 17 00:00:00 2001 From: "David P. Sicilia" Date: Tue, 27 Nov 2018 20:24:21 -0500 Subject: [PATCH 2/2] Make an implicit cast from int --> uint32_t explicit. Perhaps this casting should not happen to begin with, but better to make it explicit where it is happening for readability. This fixes a compiler warning. --- include/spdlog/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/spdlog/common.h b/include/spdlog/common.h index 4a9110b6..350ae08b 100644 --- a/include/spdlog/common.h +++ b/include/spdlog/common.h @@ -193,7 +193,7 @@ struct source_loc } SPDLOG_CONSTEXPR source_loc(const char *filename, int line) : filename(filename) - , line(line) + , line(static_cast(line)) { }