TeaSpeak
/
spdlog
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove minor optimization for the sake of simplicity

This commit is contained in:
Philip Miller 2019-01-24 09:19:52 -05:00
parent e41b92c55a
commit 4f65fcd7b1
1 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
include/spdlog/sinks/rotating_file_sink.h
View File

@ -36,15 +36,12 @@ public:
, max_size_(max_size) , max_size_(max_size)
, max_files_(max_files) , max_files_(max_files)
{ {
if (rotate_on_open) file_helper_.open(calc_filename(base_filename_, 0));
{
rotate_(false);
}
else
{
file_helper_.open(calc_filename(base_filename_, 0));
}
current_size_ = file_helper_.size(); // expensive. called only once current_size_ = file_helper_.size(); // expensive. called only once
if (rotate_on_open && current_size_ > 0)
{
rotate_();
}
} }
// calc filename according to index and file extension if exists. // calc filename according to index and file extension if exists.
@ -95,7 +92,7 @@ private:
// log.1.txt -> log.2.txt // log.1.txt -> log.2.txt
// log.2.txt -> log.3.txt // log.2.txt -> log.3.txt
// log.3.txt -> delete // log.3.txt -> delete
void rotate_(bool reopen=true) void rotate_()
{ {
using details::os::filename_to_str; using details::os::filename_to_str;
file_helper_.close(); file_helper_.close();
@ -123,14 +120,7 @@ private:
} }
} }
} }
if (reopen) file_helper_.reopen(true);
{
file_helper_.reopen(true);
}
else
{
file_helper_.open(base_filename_, true);
}
} }
// delete the target if exists, and rename the src file to target // delete the target if exists, and rename the src file to target