From 7f4c1bb77c24676419d5b042f79af801c52a8bcd Mon Sep 17 00:00:00 2001 From: Daniel Chabrowski Date: Sat, 24 Feb 2018 22:35:09 +0100 Subject: [PATCH] modernize-use-using --- include/spdlog/common.h | 4 ++-- include/spdlog/details/mpmc_bounded_q.h | 2 +- include/spdlog/details/registry.h | 6 ++++-- include/spdlog/sinks/ansicolor_sink.h | 10 +++++----- include/spdlog/sinks/dist_sink.h | 5 +++-- include/spdlog/sinks/file_sinks.h | 13 +++++++------ include/spdlog/sinks/msvc_sink.h | 4 ++-- include/spdlog/sinks/null_sink.h | 5 +++-- include/spdlog/sinks/ostream_sink.h | 5 +++-- include/spdlog/sinks/stdout_sinks.h | 10 +++++----- include/spdlog/sinks/wincolor_sink.h | 10 +++++----- include/spdlog/sinks/windebug_sink.h | 4 ++-- 12 files changed, 42 insertions(+), 36 deletions(-) diff --git a/include/spdlog/common.h b/include/spdlog/common.h index 6c7ab149..97e58247 100644 --- a/include/spdlog/common.h +++ b/include/spdlog/common.h @@ -75,7 +75,7 @@ using log_err_handler = std::function; //Log level enum namespace level { -typedef enum +enum level_enum { trace = 0, debug = 1, @@ -84,7 +84,7 @@ typedef enum err = 4, critical = 5, off = 6 -} level_enum; +}; #if !defined(SPDLOG_LEVEL_NAMES) #define SPDLOG_LEVEL_NAMES { "trace", "debug", "info", "warning", "error", "critical", "off" } diff --git a/include/spdlog/details/mpmc_bounded_q.h b/include/spdlog/details/mpmc_bounded_q.h index 102df855..887f530f 100644 --- a/include/spdlog/details/mpmc_bounded_q.h +++ b/include/spdlog/details/mpmc_bounded_q.h @@ -157,7 +157,7 @@ private: size_t const max_size_; static size_t const cacheline_size = 64; - typedef char cacheline_pad_t[cacheline_size]; + using cacheline_pad_t = char[cacheline_size]; cacheline_pad_t pad0_; cell_t* const buffer_; diff --git a/include/spdlog/details/registry.h b/include/spdlog/details/registry.h index b68b9f5a..28d8d2fa 100644 --- a/include/spdlog/details/registry.h +++ b/include/spdlog/details/registry.h @@ -216,10 +216,12 @@ private: std::chrono::milliseconds _flush_interval_ms; std::function _worker_teardown_cb = nullptr; }; + #ifdef SPDLOG_NO_REGISTRY_MUTEX -typedef registry_t registry; +using registry = registry_t; #else -typedef registry_t registry; +using registry = registry_t; #endif + } } diff --git a/include/spdlog/sinks/ansicolor_sink.h b/include/spdlog/sinks/ansicolor_sink.h index bd0e3222..2063b079 100644 --- a/include/spdlog/sinks/ansicolor_sink.h +++ b/include/spdlog/sinks/ansicolor_sink.h @@ -116,6 +116,9 @@ public: {} }; +using ansicolor_stdout_sink_mt = ansicolor_stdout_sink; +using ansicolor_stdout_sink_st = ansicolor_stdout_sink; + template class ansicolor_stderr_sink: public ansicolor_sink { @@ -124,11 +127,8 @@ public: {} }; -typedef ansicolor_stdout_sink ansicolor_stdout_sink_mt; -typedef ansicolor_stdout_sink ansicolor_stdout_sink_st; - -typedef ansicolor_stderr_sink ansicolor_stderr_sink_mt; -typedef ansicolor_stderr_sink ansicolor_stderr_sink_st; +using ansicolor_stderr_sink_mt = ansicolor_stderr_sink; +using ansicolor_stderr_sink_st = ansicolor_stderr_sink; } // namespace sinks } // namespace spdlog diff --git a/include/spdlog/sinks/dist_sink.h b/include/spdlog/sinks/dist_sink.h index 537efe1d..604c5a7d 100644 --- a/include/spdlog/sinks/dist_sink.h +++ b/include/spdlog/sinks/dist_sink.h @@ -66,7 +66,8 @@ public: } }; -typedef dist_sink dist_sink_mt; -typedef dist_sink dist_sink_st; +using dist_sink_mt = dist_sink; +using dist_sink_st = dist_sink; + } } diff --git a/include/spdlog/sinks/file_sinks.h b/include/spdlog/sinks/file_sinks.h index e13c81a6..baef4a46 100644 --- a/include/spdlog/sinks/file_sinks.h +++ b/include/spdlog/sinks/file_sinks.h @@ -55,8 +55,8 @@ private: bool _force_flush; }; -typedef simple_file_sink simple_file_sink_mt; -typedef simple_file_sink simple_file_sink_st; +using simple_file_sink_mt = simple_file_sink; +using simple_file_sink_st = simple_file_sink; /* * Rotating file sink based on size @@ -149,8 +149,8 @@ private: details::file_helper _file_helper; }; -typedef rotating_file_sink rotating_file_sink_mt; -typedef rotating_file_sinkrotating_file_sink_st; +using rotating_file_sink_mt = rotating_file_sink; +using rotating_file_sink_st = rotating_file_sink; /* * Default generator of daily log file names. @@ -247,7 +247,8 @@ private: details::file_helper _file_helper; }; -typedef daily_file_sink daily_file_sink_mt; -typedef daily_file_sink daily_file_sink_st; +using daily_file_sink_mt = daily_file_sink; +using daily_file_sink_st = daily_file_sink; + } } diff --git a/include/spdlog/sinks/msvc_sink.h b/include/spdlog/sinks/msvc_sink.h index 22b52c8f..879ae81f 100644 --- a/include/spdlog/sinks/msvc_sink.h +++ b/include/spdlog/sinks/msvc_sink.h @@ -42,8 +42,8 @@ protected: {} }; -typedef msvc_sink msvc_sink_mt; -typedef msvc_sink msvc_sink_st; +using msvc_sink_mt = msvc_sink; +using msvc_sink_st = msvc_sink; } } diff --git a/include/spdlog/sinks/null_sink.h b/include/spdlog/sinks/null_sink.h index 7605ac68..deda0373 100644 --- a/include/spdlog/sinks/null_sink.h +++ b/include/spdlog/sinks/null_sink.h @@ -26,8 +26,9 @@ protected: {} }; -typedef null_sink null_sink_st; -typedef null_sink null_sink_mt; + +using null_sink_mt = null_sink; +using null_sink_st = null_sink; } } diff --git a/include/spdlog/sinks/ostream_sink.h b/include/spdlog/sinks/ostream_sink.h index 1e5b261c..8ab9caab 100644 --- a/include/spdlog/sinks/ostream_sink.h +++ b/include/spdlog/sinks/ostream_sink.h @@ -41,7 +41,8 @@ protected: bool _force_flush; }; -typedef ostream_sink ostream_sink_mt; -typedef ostream_sink ostream_sink_st; +using ostream_sink_mt = ostream_sink; +using ostream_sink_st = ostream_sink; + } } diff --git a/include/spdlog/sinks/stdout_sinks.h b/include/spdlog/sinks/stdout_sinks.h index dfbfccd5..6867ba4e 100644 --- a/include/spdlog/sinks/stdout_sinks.h +++ b/include/spdlog/sinks/stdout_sinks.h @@ -42,9 +42,8 @@ protected: } }; -typedef stdout_sink stdout_sink_st; -typedef stdout_sink stdout_sink_mt; - +using stdout_sink_mt = stdout_sink; +using stdout_sink_st = stdout_sink; template class stderr_sink SPDLOG_FINAL : public base_sink @@ -71,7 +70,8 @@ protected: } }; -typedef stderr_sink stderr_sink_mt; -typedef stderr_sink stderr_sink_st; +using stderr_sink_mt = stderr_sink; +using stderr_sink_st = stderr_sink; + } } diff --git a/include/spdlog/sinks/wincolor_sink.h b/include/spdlog/sinks/wincolor_sink.h index d8211fb1..bd612407 100644 --- a/include/spdlog/sinks/wincolor_sink.h +++ b/include/spdlog/sinks/wincolor_sink.h @@ -85,7 +85,7 @@ private: back_color &= static_cast(~(FOREGROUND_RED | FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY)); // keep the background color unchanged SetConsoleTextAttribute(out_handle_, attribs | back_color); - return orig_buffer_info.wAttributes; //return orig attribs + return orig_buffer_info.wAttributes; //return orig attribs } }; @@ -100,8 +100,8 @@ public: {} }; -typedef wincolor_stdout_sink wincolor_stdout_sink_mt; -typedef wincolor_stdout_sink wincolor_stdout_sink_st; +using wincolor_stdout_sink_mt = wincolor_stdout_sink; +using wincolor_stdout_sink_st = wincolor_stdout_sink; // // windows color console to stderr @@ -114,8 +114,8 @@ public: {} }; -typedef wincolor_stderr_sink wincolor_stderr_sink_mt; -typedef wincolor_stderr_sink wincolor_stderr_sink_st; +using wincolor_stderr_sink_mt = wincolor_stderr_sink; +using wincolor_stderr_sink_st = wincolor_stderr_sink; } } diff --git a/include/spdlog/sinks/windebug_sink.h b/include/spdlog/sinks/windebug_sink.h index c22e9522..16e8e540 100644 --- a/include/spdlog/sinks/windebug_sink.h +++ b/include/spdlog/sinks/windebug_sink.h @@ -20,8 +20,8 @@ namespace sinks template using windebug_sink = msvc_sink; -typedef msvc_sink_mt windebug_sink_mt; -typedef msvc_sink_st windebug_sink_st; +using windebug_sink_mt = msvc_sink_mt; +using windebug_sink_st = msvc_sink_st; } }