VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2025-05-29 21:42:26 -04:00
Code Issues Projects Releases Wiki Activity

Web API: fixed missing initializations of error object

Browse Source
This commit is contained in:
f4exb 2018-02-21 13:27:10 +01:00
parent 9f220f182c
commit 0162b1d2bc
2 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sdrgui/webapi/webapiadaptergui.cpp
View File

@ -779,6 +779,8 @@ int WebAPIAdapterGUI::devicesetDeviceSettingsGet(
SWGSDRangel::SWGDeviceSettings& response, SWGSDRangel::SWGDeviceSettings& response,
SWGSDRangel::SWGErrorResponse& error) SWGSDRangel::SWGErrorResponse& error)
{ {
error.init();
if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainWindow.m_deviceUIs.size())) if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainWindow.m_deviceUIs.size()))
{ {
DeviceUISet *deviceSet = m_mainWindow.m_deviceUIs[deviceSetIndex]; DeviceUISet *deviceSet = m_mainWindow.m_deviceUIs[deviceSetIndex];
@ -799,16 +801,13 @@ int WebAPIAdapterGUI::devicesetDeviceSettingsGet(
} }
else else
{ {
error.init();
*error.getMessage() = QString("DeviceSet error"); *error.getMessage() = QString("DeviceSet error");
return 500; return 500;
} }
} }
else else
{ {
error.init();
*error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex); *error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex);
return 404; return 404;
} }
} }
@ -820,6 +819,8 @@ int WebAPIAdapterGUI::devicesetDeviceSettingsPutPatch(
SWGSDRangel::SWGDeviceSettings& response, SWGSDRangel::SWGDeviceSettings& response,
SWGSDRangel::SWGErrorResponse& error) SWGSDRangel::SWGErrorResponse& error)
{ {
error.init();
if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainWindow.m_deviceUIs.size())) if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainWindow.m_deviceUIs.size()))
{ {
DeviceUISet *deviceSet = m_mainWindow.m_deviceUIs[deviceSetIndex]; DeviceUISet *deviceSet = m_mainWindow.m_deviceUIs[deviceSetIndex];
@ -828,13 +829,11 @@ int WebAPIAdapterGUI::devicesetDeviceSettingsPutPatch(
{ {
if (response.getTx() != 0) if (response.getTx() != 0)
{ {
error.init();
*error.getMessage() = QString("Rx device found but Tx device requested"); *error.getMessage() = QString("Rx device found but Tx device requested");
return 400; return 400;
} }
if (deviceSet->m_deviceSourceAPI->getHardwareId() != *response.getDeviceHwType()) if (deviceSet->m_deviceSourceAPI->getHardwareId() != *response.getDeviceHwType())
{ {
error.init();
*error.getMessage() = QString("Device mismatch. Found %1 input").arg(deviceSet->m_deviceSourceAPI->getHardwareId()); *error.getMessage() = QString("Device mismatch. Found %1 input").arg(deviceSet->m_deviceSourceAPI->getHardwareId());
return 400; return 400;
} }
@ -848,13 +847,11 @@ int WebAPIAdapterGUI::devicesetDeviceSettingsPutPatch(
{ {
if (response.getTx() == 0) if (response.getTx() == 0)
{ {
error.init();
*error.getMessage() = QString("Tx device found but Rx device requested"); *error.getMessage() = QString("Tx device found but Rx device requested");
return 400; return 400;
} }
else if (deviceSet->m_deviceSinkAPI->getHardwareId() != *response.getDeviceHwType()) else if (deviceSet->m_deviceSinkAPI->getHardwareId() != *response.getDeviceHwType())
{ {
error.init();
*error.getMessage() = QString("Device mismatch. Found %1 output").arg(deviceSet->m_deviceSinkAPI->getHardwareId()); *error.getMessage() = QString("Device mismatch. Found %1 output").arg(deviceSet->m_deviceSinkAPI->getHardwareId());
return 400; return 400;
} }
@ -866,14 +863,12 @@ int WebAPIAdapterGUI::devicesetDeviceSettingsPutPatch(
} }
else else
{ {
error.init();
*error.getMessage() = QString("DeviceSet error"); *error.getMessage() = QString("DeviceSet error");
return 500; return 500;
} }
} }
else else
{ {
error.init();
*error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex); *error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex);
return 404; return 404;
} }

12
sdrsrv/webapi/webapiadaptersrv.cpp
View File

@ -884,6 +884,8 @@ int WebAPIAdapterSrv::devicesetDeviceSettingsGet(
SWGSDRangel::SWGDeviceSettings& response, SWGSDRangel::SWGDeviceSettings& response,
SWGSDRangel::SWGErrorResponse& error) SWGSDRangel::SWGErrorResponse& error)
{ {
error.init();
if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainCore.m_deviceSets.size())) if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainCore.m_deviceSets.size()))
{ {
DeviceSet *deviceSet = m_mainCore.m_deviceSets[deviceSetIndex]; DeviceSet *deviceSet = m_mainCore.m_deviceSets[deviceSetIndex];
@ -904,14 +906,12 @@ int WebAPIAdapterSrv::devicesetDeviceSettingsGet(
} }
else else
{ {
error.init();
*error.getMessage() = QString("DeviceSet error"); *error.getMessage() = QString("DeviceSet error");
return 500; return 500;
} }
} }
else else
{ {
error.init();
*error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex); *error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex);
return 404; return 404;
} }
@ -924,6 +924,8 @@ int WebAPIAdapterSrv::devicesetDeviceSettingsPutPatch(
SWGSDRangel::SWGDeviceSettings& response, SWGSDRangel::SWGDeviceSettings& response,
SWGSDRangel::SWGErrorResponse& error) SWGSDRangel::SWGErrorResponse& error)
{ {
error.init();
if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainCore.m_deviceSets.size())) if ((deviceSetIndex >= 0) && (deviceSetIndex < (int) m_mainCore.m_deviceSets.size()))
{ {
DeviceSet *deviceSet = m_mainCore.m_deviceSets[deviceSetIndex]; DeviceSet *deviceSet = m_mainCore.m_deviceSets[deviceSetIndex];
@ -932,13 +934,11 @@ int WebAPIAdapterSrv::devicesetDeviceSettingsPutPatch(
{ {
if (response.getTx() != 0) if (response.getTx() != 0)
{ {
error.init();
*error.getMessage() = QString("Rx device found but Tx device requested"); *error.getMessage() = QString("Rx device found but Tx device requested");
return 400; return 400;
} }
if (deviceSet->m_deviceSourceAPI->getHardwareId() != *response.getDeviceHwType()) if (deviceSet->m_deviceSourceAPI->getHardwareId() != *response.getDeviceHwType())
{ {
error.init();
*error.getMessage() = QString("Device mismatch. Found %1 input").arg(deviceSet->m_deviceSourceAPI->getHardwareId()); *error.getMessage() = QString("Device mismatch. Found %1 input").arg(deviceSet->m_deviceSourceAPI->getHardwareId());
return 400; return 400;
} }
@ -952,13 +952,11 @@ int WebAPIAdapterSrv::devicesetDeviceSettingsPutPatch(
{ {
if (response.getTx() == 0) if (response.getTx() == 0)
{ {
error.init();
*error.getMessage() = QString("Tx device found but Rx device requested"); *error.getMessage() = QString("Tx device found but Rx device requested");
return 400; return 400;
} }
else if (deviceSet->m_deviceSinkAPI->getHardwareId() != *response.getDeviceHwType()) else if (deviceSet->m_deviceSinkAPI->getHardwareId() != *response.getDeviceHwType())
{ {
error.init();
*error.getMessage() = QString("Device mismatch. Found %1 output").arg(deviceSet->m_deviceSinkAPI->getHardwareId()); *error.getMessage() = QString("Device mismatch. Found %1 output").arg(deviceSet->m_deviceSinkAPI->getHardwareId());
return 400; return 400;
} }
@ -970,14 +968,12 @@ int WebAPIAdapterSrv::devicesetDeviceSettingsPutPatch(
} }
else else
{ {
error.init();
*error.getMessage() = QString("DeviceSet error"); *error.getMessage() = QString("DeviceSet error");
return 500; return 500;
} }
} }
else else
{ {
error.init();
*error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex); *error.getMessage() = QString("There is no device set with index %1").arg(deviceSetIndex);
return 404; return 404;
} }