1
0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-07-17 16:24:08 -04:00

PVS-Studio analys fixes: core package serious issues

This commit is contained in:
f4exb
2019-06-14 16:58:09 +02:00
parent 63132f0165
commit 06dea9b29f
40 changed files with 105 additions and 41 deletions
@@ -893,6 +893,8 @@ void AirspyInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void AirspyInput::networkManagerFinished(QNetworkReply *reply)
@@ -917,6 +917,8 @@ void AirspyHFInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void AirspyHFInput::networkManagerFinished(QNetworkReply *reply)
@@ -860,6 +860,8 @@ void Bladerf1Input::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void Bladerf1Input::networkManagerFinished(QNetworkReply *reply)
@@ -1343,6 +1343,8 @@ void BladeRF2Input::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void BladeRF2Input::networkManagerFinished(QNetworkReply *reply)
@@ -1149,6 +1149,8 @@ void FCDProInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void FCDProInput::networkManagerFinished(QNetworkReply *reply)
@@ -813,6 +813,8 @@ void FCDProPlusInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void FCDProPlusInput::networkManagerFinished(QNetworkReply *reply)
@@ -658,6 +658,8 @@ void FileSourceInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void FileSourceInput::networkManagerFinished(QNetworkReply *reply)
@@ -825,6 +825,8 @@ void HackRFInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void HackRFInput::networkManagerFinished(QNetworkReply *reply)
@@ -345,10 +345,10 @@ void HackRFInputGui::on_centerFrequency_changed(quint64 value)
void HackRFInputGui::on_sampleRate_changed(quint64 value)
{
if (m_sampleRateMode) {
m_settings.m_devSampleRate = value;
} else {
m_settings.m_devSampleRate = value * (1 << m_settings.m_log2Decim);
m_settings.m_devSampleRate = value;
if (!m_sampleRateMode) {
m_settings.m_devSampleRate <<= m_settings.m_log2Decim;
}
displayFcTooltip();
@@ -363,11 +363,10 @@ void HackRFInputGui::on_decim_currentIndexChanged(int index)
m_settings.m_log2Decim = index;
displaySampleRate();
m_settings.m_devSampleRate = ui->sampleRate->getValueNew();
if (m_sampleRateMode) {
m_settings.m_devSampleRate = ui->sampleRate->getValueNew();
} else {
m_settings.m_devSampleRate = ui->sampleRate->getValueNew() * (1 << m_settings.m_log2Decim);
if (!m_sampleRateMode) {
m_settings.m_devSampleRate <<= m_settings.m_log2Decim;
}
sendSettings();
@@ -545,6 +545,8 @@ void KiwiSDRInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void KiwiSDRInput::networkManagerFinished(QNetworkReply *reply)
@@ -1790,6 +1790,8 @@ void LimeSDRInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void LimeSDRInput::networkManagerFinished(QNetworkReply *reply)
@@ -43,6 +43,7 @@ MESSAGE_CLASS_DEFINITION(LocalInput::MsgReportSampleRateAndFrequency, Message)
LocalInput::LocalInput(DeviceAPI *deviceAPI) :
m_deviceAPI(deviceAPI),
m_settings(),
m_centerFrequency(0),
m_deviceDescription("LocalInput")
{
m_sampleFifo.setSize(96000 * 4);
@@ -457,6 +458,8 @@ void LocalInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void LocalInput::networkManagerFinished(QNetworkReply *reply)
@@ -698,6 +698,8 @@ void PerseusInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void PerseusInput::networkManagerFinished(QNetworkReply *reply)
@@ -1022,6 +1022,8 @@ void PlutoSDRInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void PlutoSDRInput::networkManagerFinished(QNetworkReply *reply)
@@ -230,11 +230,10 @@ void PlutoSDRInputGui::on_swDecim_currentIndexChanged(int index)
{
m_settings.m_log2Decim = index > 6 ? 6 : index;
displaySampleRate();
m_settings.m_devSampleRate = ui->sampleRate->getValueNew();
if (m_sampleRateMode) {
m_settings.m_devSampleRate = ui->sampleRate->getValueNew();
} else {
m_settings.m_devSampleRate = ui->sampleRate->getValueNew() * (1 << m_settings.m_log2Decim);
if (!m_sampleRateMode) {
m_settings.m_devSampleRate <<= m_settings.m_log2Decim;
}
sendSettings();
@@ -249,10 +248,10 @@ void PlutoSDRInputGui::on_fcPos_currentIndexChanged(int index)
void PlutoSDRInputGui::on_sampleRate_changed(quint64 value)
{
if (m_sampleRateMode) {
m_settings.m_devSampleRate = value;
} else {
m_settings.m_devSampleRate = value * (1 << m_settings.m_log2Decim);
m_settings.m_devSampleRate = value;
if (!m_sampleRateMode) {
m_settings.m_devSampleRate <<= m_settings.m_log2Decim;
}
displayFcTooltip();
@@ -507,6 +507,8 @@ void RemoteInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void RemoteInput::networkManagerFinished(QNetworkReply *reply)
@@ -862,6 +862,8 @@ void RTLSDRInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void RTLSDRInput::networkManagerFinished(QNetworkReply *reply)
@@ -949,6 +949,8 @@ void SDRPlayInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void SDRPlayInput::networkManagerFinished(QNetworkReply *reply)
@@ -2020,6 +2020,8 @@ void SoapySDRInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void SoapySDRInput::networkManagerFinished(QNetworkReply *reply)
@@ -727,6 +727,8 @@ void TestSourceInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void TestSourceInput::networkManagerFinished(QNetworkReply *reply)
@@ -1640,6 +1640,8 @@ void XTRXInput::webapiReverseSendStartStop(bool start)
} else {
m_networkManager->sendCustomRequest(m_networkRequest, "DELETE", buffer);
}
delete swgDeviceSettings;
}
void XTRXInput::networkManagerFinished(QNetworkReply *reply)