From 081f4d564471c2534a289d7acfdf7b3ff1666fcd Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 18 Apr 2026 19:46:11 +0000
Subject: [PATCH] freqdisplay: make only the display area transparent, not the
 settings bar

Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/b295b0a4-ffcc-41dc-9e86-f204ec06d389

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
---
 .../feature/freqdisplay/freqdisplaygui.cpp    | 28 ++++++-------------
 plugins/feature/freqdisplay/freqdisplaygui.ui |  2 +-
 2 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/plugins/feature/freqdisplay/freqdisplaygui.cpp b/plugins/feature/freqdisplay/freqdisplaygui.cpp
index d8eadbef6..12a109eda 100644
--- a/plugins/feature/freqdisplay/freqdisplaygui.cpp
+++ b/plugins/feature/freqdisplay/freqdisplaygui.cpp
@@ -18,9 +18,6 @@ constexpr int minimumFrequencyFontPointSize = 10;
 // Reference point size used when probing text metrics in updateFrequencyFont().
 // Large enough that integer rounding in QFontMetrics is negligible.
 constexpr int fontProbePointSize = 200;
-// Stylesheet applied to this window when transparency is enabled.
-// The '*' universal selector cascades to every child widget.
-constexpr const char* transparentStyleSheet = "* { background: transparent; border: none; }";
 }
 
 FreqDisplayGUI* FreqDisplayGUI::create(PluginAPI* pluginAPI, FeatureUISet *featureUISet, Feature *feature)
@@ -367,23 +364,14 @@ void FreqDisplayGUI::updateFrequencyFont()
 
 void FreqDisplayGUI::applyTransparency()
 {
-    if (m_settings.m_transparentBackground)
-    {
-        // Override the FeatureGUI stylesheet on the entire window using the '*'
-        // universal selector so that every child widget's background is also
-        // cleared.  Combined with WA_TranslucentBackground (set in the constructor)
-        // this makes the sub-window show whatever is rendered behind it in the
-        // MDI area instead of the normal solid background.
-        setStyleSheet(transparentStyleSheet);
-    }
-    else
-    {
-        // Restore the stylesheet that FeatureGUI set at construction time.
-        setStyleSheet(m_normalStyleSheet);
-        // Also clear any per-widget overrides from previous transparent runs.
-        ui->settingsContainer->setStyleSheet(QString());
-        ui->frequencyValue->setStyleSheet(QString());
-    }
+    // Always keep the window-level stylesheet and the settings bar looking normal.
+    setStyleSheet(m_normalStyleSheet);
+    ui->settingsContainer->setStyleSheet(QString());
+
+    // Apply or remove transparency on the display area only.
+    const QString displayStyle = m_settings.m_transparentBackground ? "background: transparent;" : QString();
+    ui->horizontalWidget->setStyleSheet(displayStyle);
+    ui->frequencyValue->setStyleSheet(displayStyle);
 }
 
 void FreqDisplayGUI::on_displayMode_currentIndexChanged(int index)
diff --git a/plugins/feature/freqdisplay/freqdisplaygui.ui b/plugins/feature/freqdisplay/freqdisplaygui.ui
index af3bbf901..23b47d674 100644
--- a/plugins/feature/freqdisplay/freqdisplaygui.ui
+++ b/plugins/feature/freqdisplay/freqdisplaygui.ui
@@ -124,7 +124,7 @@
       <item>
        <widget class="ButtonSwitch" name="transparentBackground">
         <property name="toolTip">
-         <string>Toggle transparent window background</string>
+         <string>Toggle transparent background for the display area</string>
         </property>
         <property name="text">
          <string>T</string>