VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2025-04-04 02:28:33 -04:00
Code Issues Projects Releases Wiki Activity

BFM demod: RDS demod: Initialize RDSDemod array elements

Browse Source 
The m_parms.tot_errs array is not initialized prior to its first use
in the RDSDemod::biphase function. ASAN does not pick up on this
directly, but instead reports it as follows (note that ASAN fills
memory with 0xBE and -1094795586 is 0xBEBEBEBE):

    ./plugins/channelrx/demodbfm/rdsdemod.cpp:159:95: runtime error: signed
    integer overflow: -1094795586 + -1094795586 cannot be represented in type
    'int'

The m_parms.subcarr_bb array does not appear to be read prior to
initialization, but we initialize it to zero anyway for the sake
of good hygiene.
This commit is contained in:
Jason Gerecke 2018-04-21 09:53:04 -07:00
parent bc4d7adce7
commit 141997475c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/channelrx/demodbfm/rdsdemod.cpp
View File

@ -36,6 +36,7 @@ RDSDemod::RDSDemod()
m_srate = 250000;
m_parms.subcarr_phi = 0;
memset(m_parms.subcarr_bb, 0, sizeof(m_parms.subcarr_bb));
m_parms.clock_offset = 0;
m_parms.clock_phi = 0;
m_parms.prev_clock_phi = 0;
@ -48,6 +49,7 @@ RDSDemod::RDSDemod()
m_parms.prev_acc = 0;
m_parms.counter = 0;
m_parms.reading_frame = 0;
memset(m_parms.tot_errs, 0, sizeof(m_parms.tot_errs));
m_parms.dbit = 0;
m_prev = 0.0f;
memset(m_xv, 0, 6*sizeof(Real));