Fixed FCD Pro LNA gain setting

Readme.md

@@ -53,7 +53,7 @@ If you use your own location for libbladeRF install directory you need to specif
 
 <h2>FunCube Dongle</h2>
 
-Both Pro and Pro+ are supported with the plugins in fcdpro and fcdproplus respectively. This is a work in progress. For Pro+ the RF filter selection does not seem to be effective. Perhaps it is derived from the given center frequency internally. Support of features is still inadapted for Pro which is just a copy from Pro+ apart from some constants to make it work with Pro.
+Both Pro and Pro+ are supported with the plugins in fcdpro and fcdproplus respectively. For the Pro+ the band filter selection is not effective as it is handled by the firmware using the center frequency.
 
 The control interface is based on qthid and has been built in the software in the fcdhid library. You don't need anything else than libusb support. Library fcdlib is used to store the constants for each dongle type.
 
@@ -91,8 +91,7 @@ Assuming Debian Jessie is used:
 
 <h1>Known Issues</h1>
 
-  - You will need to stop input before changing sample rate or frequency (hence preset) then start again. There are still segfaults on critical changes
-  - There are still some unexpected segfaults but they are rather rare
+  - Segfaults in the channelizer seem to be fixed; still under observation. Consequently it is now possible to change critical settings without stopping acquisition.
   - The message queuing model supports a n:1 connection to an object (on its input queue) and a 1:1 connection from an object (on its output queue). Assuming a different model can cause insidious disruptions.
   - As the objects input and output queues can be publicly accessed there is no strict control of which objects post messages on these queues. The correct assumption is that messages can be popped from the input queue only by its holder and that messages can be pushed on the output queue only by its holder.
 
@@ -150,15 +149,14 @@ Assuming Debian Jessie is used:
   - Dedicated message queue to communicate to the GUI for objects coupled with a GUI
   - Optimizations with Valgrind cachegrind
   - Corrected decimators bit shifting so that the number of effective output bits is constant and fill the internal sample width
-  - Separate library to support all flavours of FunCube dongles
+  - Separate library to support all flavours of FunCube dongles. Rewritten FCD plugins.
   - Many other little things...
     
 <h1>To Do</h1>
-
+  - Enhance presets management (Edit, Move, Import/Export from/to human readable format like JSON). Allow several sample source plugins to share the same presets
   - Level calibration  
-  - Enhance presets management (Edit, Move, Import/Export from/to human readable format like JSON)  
-  - Tx channels for Rx/Tx boards like BladeRF
+  - Tx support with the BladeRF
   - Enhance WFM (stereo, RDS?)
   - Even more demods ...
-  - Support for Airspy and Funcube Dongle Pro+
+  - Support for Airspy
   

plugins/samplesource/fcdpro/fcdprogui.cpp

@@ -317,21 +317,21 @@ void FCDProGui::on_gain6_currentIndexChanged(int index)
 
 void FCDProGui::on_setDefaults_clicked(bool checked)
 {
-	m_settings.lnaGainIndex = 4;
+	m_settings.lnaGainIndex = 8;        // +15 dB
 	//m_settings.rfFilterIndex = 0;
-	m_settings.mixerGainIndex = 1;
-	m_settings.mixerFilterIndex = 8;
-	m_settings.gain1Index = 1;
-	m_settings.rcFilterIndex = 15;
-	m_settings.gain2Index = 1;
-	m_settings.gain3Index = 1;
-	m_settings.gain4Index = 0;
-	m_settings.ifFilterIndex = 31;
-	m_settings.gain5Index = 0;
-	m_settings.gain6Index = 0;
-	m_settings.lnaEnhanceIndex = 0;
-	m_settings.biasCurrentIndex = 3;
-	m_settings.modeIndex = 0;
+	m_settings.mixerGainIndex = 1;      // +12 dB
+	m_settings.mixerFilterIndex = 8;    // 1.9 MHz
+	m_settings.gain1Index = 1;          // +6 dB
+	m_settings.rcFilterIndex = 15;      // 1.0 MHz
+	m_settings.gain2Index = 1;          // +3 dB
+	m_settings.gain3Index = 1;          // +3 dB
+	m_settings.gain4Index = 0;          // 0 dB
+	m_settings.ifFilterIndex = 31;      // 2.15 MHz
+	m_settings.gain5Index = 0;          // +3 dB
+	m_settings.gain6Index = 0;          // +3 dB
+	m_settings.lnaEnhanceIndex = 0;     // Off
+	m_settings.biasCurrentIndex = 3;    // V/U band
+	m_settings.modeIndex = 0;           // Linearity
 	displaySettings();
 	sendSettings();
 }

plugins/samplesource/fcdpro/fcdprogui.ui

@@ -153,7 +153,7 @@
      <item>
       <widget class="QLabel" name="lnaEnhanceLabel">
        <property name="text">
-        <string>LNA En</string>
+        <string>LNA Enh</string>
        </property>
       </widget>
      </item>

plugins/samplesource/fcdpro/fcdproinput.cpp

@@ -250,7 +250,7 @@ void FCDProInput::applySettings(const Settings& settings, bool force)
 
 		if (m_dev != 0)
 		{
-			set_ifFilter(settings.lnaGainIndex);
+			set_lnaGain(settings.lnaGainIndex);
 		}
 	}