PVS-Studio static analysis corrections (3) issue #137

plugins/samplesource/bladerfinput/bladerfinput.cpp

@@ -146,12 +146,7 @@ bool BladerfInput::start()
 
     if (m_running) stop();
 
-	if((m_bladerfThread = new BladerfInputThread(m_dev, &m_sampleFifo)) == 0) {
-	    qCritical("BladerfInput::start: out of memory");
-		stop();
-		return false;
-	}
-
+	m_bladerfThread = new BladerfInputThread(m_dev, &m_sampleFifo);
 	m_bladerfThread->setLog2Decimation(m_settings.m_log2Decim);
 	m_bladerfThread->setFcPos((int) m_settings.m_fcPos);
 

plugins/samplesource/bladerfinput/bladerfinputplugin.cpp

@@ -59,23 +59,23 @@ PluginInterface::SamplingDevices BlderfInputPlugin::enumSampleSources()
 
 	int count = bladerf_get_device_list(&devinfo);
 
-	for(int i = 0; i < count; i++)
-	{
-		QString displayedName(QString("BladeRF[%1] %2").arg(devinfo[i].instance).arg(devinfo[i].serial));
+    if (devinfo)
+    {
+        for(int i = 0; i < count; i++)
+        {
+            QString displayedName(QString("BladeRF[%1] %2").arg(devinfo[i].instance).arg(devinfo[i].serial));
 
-		result.append(SamplingDevice(displayedName,
-		        m_hardwareID,
-				m_deviceTypeID,
-				QString(devinfo[i].serial),
-				i,
-				PluginInterface::SamplingDevice::PhysicalDevice,
-				true,
-				1,
-				0));
-	}
+            result.append(SamplingDevice(displayedName,
+                    m_hardwareID,
+                    m_deviceTypeID,
+                    QString(devinfo[i].serial),
+                    i,
+                    PluginInterface::SamplingDevice::PhysicalDevice,
+                    true,
+                    1,
+                    0));
+        }
 
-	if (devinfo)
-	{
 		bladerf_free_device_list(devinfo); // Valgrind memcheck
 	}
 

plugins/samplesource/bladerfinput/bladerfinputthread.cpp

@@ -18,6 +18,7 @@
 
 #include <stdio.h>
 #include <errno.h>
+#include <algorithm>
 #include "dsp/samplesinkfifo.h"
 
 
@@ -31,6 +32,7 @@ BladerfInputThread::BladerfInputThread(struct bladerf* dev, SampleSinkFifo* samp
 	m_log2Decim(0),
 	m_fcPos(0)
 {
+    std::fill(m_buf, m_buf + 2*BLADERF_BLOCKSIZE, 0);
 }
 
 BladerfInputThread::~BladerfInputThread()