From 581576dbc6998677a3c2224daeead21afc4dffd3 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Sat, 1 Aug 2026 16:05:08 -0400 Subject: [PATCH] sdrangelserverlist: Initialize SDRangelServer members by default Add default initializers for primitive SDRangelServer members to avoid uninitialized values when optional JSON fields are not present. Fixes cppcheck warnings for uninitialized struct members. Signed-off-by: Robin Getz --- sdrbase/util/sdrangelserverlist.h | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/sdrbase/util/sdrangelserverlist.h b/sdrbase/util/sdrangelserverlist.h index 9cb08b483..83f1e3efe 100644 --- a/sdrbase/util/sdrangelserverlist.h +++ b/sdrbase/util/sdrangelserverlist.h @@ -18,6 +18,7 @@ #ifndef INCLUDE_SDRANGELSERVERLIST_H #define INCLUDE_SDRANGELSERVERLIST_H +#include #include #include @@ -36,25 +37,25 @@ public: struct SDRangelServer { QString m_address; - quint16 m_port; + quint16 m_port = 0; QString m_protocol; - qint64 m_minFrequency; - qint64 m_maxFrequency; - int m_maxSampleRate; + qint64 m_minFrequency = 0; + qint64 m_maxFrequency = std::numeric_limits::max(); + int m_maxSampleRate = std::numeric_limits::max(); QString m_device; QString m_antenna; - bool m_remoteControl; + bool m_remoteControl = false; QString m_stationName; QString m_location; - float m_latitude; - float m_longitude; - float m_altitude; - bool m_isotropic; - float m_azimuth; - float m_elevation; - int m_clients; - int m_maxClients; - int m_timeLimit; // In minutes + float m_latitude = 0.0f; + float m_longitude = 0.0f; + float m_altitude = 0.0f; + bool m_isotropic = false; + float m_azimuth = 0.0f; + float m_elevation = 0.0f; + int m_clients = 0; + int m_maxClients = 4; + int m_timeLimit = 0; // In minutes }; SDRangelServerList();