From 61d4de46019175235922cfb8a1a4ae0cd0f77c7a Mon Sep 17 00:00:00 2001 From: f4exb Date: Thu, 28 Dec 2017 17:14:52 +0100 Subject: [PATCH] Server: fix possible core dump in MainCore::changeSampleSource by removing the saving and loading of device settings on the working preset --- sdrsrv/maincore.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/sdrsrv/maincore.cpp b/sdrsrv/maincore.cpp index a148a8707..858b1a335 100644 --- a/sdrsrv/maincore.cpp +++ b/sdrsrv/maincore.cpp @@ -344,7 +344,6 @@ void MainCore::changeSampleSource(int deviceSetIndex, int selectedDeviceIndex) { qDebug("MainCore::changeSampleSource: deviceSet at %d", deviceSetIndex); DeviceSet *deviceSet = m_deviceSets[deviceSetIndex]; - deviceSet->m_deviceSourceAPI->saveSourceSettings(m_settings.getWorkingPreset()); // save old API settings deviceSet->m_deviceSourceAPI->stopAcquisition(); // deletes old UI and input object @@ -401,8 +400,6 @@ void MainCore::changeSampleSource(int deviceSetIndex, int selectedDeviceIndex) DeviceSampleSource *source = deviceSet->m_deviceSourceAPI->getPluginInterface()->createSampleSourcePluginInstanceInput( deviceSet->m_deviceSourceAPI->getSampleSourceId(), deviceSet->m_deviceSourceAPI); deviceSet->m_deviceSourceAPI->setSampleSource(source); - - deviceSet->m_deviceSourceAPI->loadSourceSettings(m_settings.getWorkingPreset()); // load new API settings } }