From 810b0524fb457f28b564b9bef98fd7d79537a011 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Sun, 12 Jul 2026 19:16:08 -0400 Subject: [PATCH] adsb: fix Coverity UNINIT_CTOR warning in AircraftModel Initialize the AircraftModel settings pointer to nullptr. Coverity (CID 649096) flagged m_settings as potentially uninitialized because the compiler-generated constructor does not initialize it. Initialize it to nullptr, which is the appropriate default until setSettings() provides a valid pointer. This is likely not an issue, as m_settings is typically assigned shortly after construction. However, correctness depends on that assumption holding everywhere. Initializing it in the declaration costs nothing, removes the dependency on initialization order, and eliminates this class of bugs. Signed-off-by: Robin Getz --- plugins/channelrx/demodadsb/adsbdemodgui.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/channelrx/demodadsb/adsbdemodgui.h b/plugins/channelrx/demodadsb/adsbdemodgui.h index 1f3b5b4dd..a7ee72466 100644 --- a/plugins/channelrx/demodadsb/adsbdemodgui.h +++ b/plugins/channelrx/demodadsb/adsbdemodgui.h @@ -720,7 +720,7 @@ public: } } - const ADSBDemodSettings *m_settings; + const ADSBDemodSettings *m_settings = nullptr; private: QList m_aircrafts;