1
0
mirror of https://github.com/f4exb/sdrangel.git synced 2024-09-29 16:26:47 -04:00

All plugins: removed apply settings in constructors as it causes segfaults

This commit is contained in:
f4exb 2017-12-24 18:37:33 +01:00
parent 063eff4204
commit b127182062
18 changed files with 5 additions and 30 deletions

View File

@ -47,8 +47,6 @@ BladerfOutput::BladerfOutput(DeviceSinkAPI *deviceAPI) :
m_sampleSourceFifo.resize(16*BLADERFOUTPUT_BLOCKSIZE); m_sampleSourceFifo.resize(16*BLADERFOUTPUT_BLOCKSIZE);
openDevice(); openDevice();
m_deviceAPI->setBuddySharedPtr(&m_sharedParams); m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
applySettings(m_settings, true);
} }
BladerfOutput::~BladerfOutput() BladerfOutput::~BladerfOutput()

View File

@ -49,7 +49,6 @@ FileSinkOutput::FileSinkOutput(DeviceSinkAPI *deviceAPI) :
m_startingTimeStamp(0), m_startingTimeStamp(0),
m_masterTimer(deviceAPI->getMasterTimer()) m_masterTimer(deviceAPI->getMasterTimer())
{ {
applySettings(m_settings, true);
} }
FileSinkOutput::~FileSinkOutput() FileSinkOutput::~FileSinkOutput()

View File

@ -47,8 +47,6 @@ HackRFOutput::HackRFOutput(DeviceSinkAPI *deviceAPI) :
{ {
openDevice(); openDevice();
m_deviceAPI->setBuddySharedPtr(&m_sharedParams); m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
applySettings(m_settings, true);
} }
HackRFOutput::~HackRFOutput() HackRFOutput::~HackRFOutput()

View File

@ -55,8 +55,6 @@ LimeSDROutput::LimeSDROutput(DeviceSinkAPI *deviceAPI) :
openDevice(); openDevice();
resumeTxBuddies(); resumeTxBuddies();
resumeRxBuddies(); resumeRxBuddies();
applySettings(m_settings, true, false);
} }
LimeSDROutput::~LimeSDROutput() LimeSDROutput::~LimeSDROutput()

View File

@ -45,8 +45,6 @@ PlutoSDROutput::PlutoSDROutput(DeviceSinkAPI *deviceAPI) :
suspendBuddies(); suspendBuddies();
openDevice(); openDevice();
resumeBuddies(); resumeBuddies();
applySettings(m_settings, true);
} }
PlutoSDROutput::~PlutoSDROutput() PlutoSDROutput::~PlutoSDROutput()

View File

@ -47,7 +47,6 @@ SDRdaemonSinkOutput::SDRdaemonSinkOutput(DeviceSinkAPI *deviceAPI) :
m_startingTimeStamp(0), m_startingTimeStamp(0),
m_masterTimer(deviceAPI->getMasterTimer()) m_masterTimer(deviceAPI->getMasterTimer())
{ {
applySettings(m_settings, true);
} }
SDRdaemonSinkOutput::~SDRdaemonSinkOutput() SDRdaemonSinkOutput::~SDRdaemonSinkOutput()

View File

@ -52,8 +52,6 @@ AirspyInput::AirspyInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true);
} }
AirspyInput::~AirspyInput() AirspyInput::~AirspyInput()

View File

@ -53,8 +53,6 @@ BladerfInput::BladerfInput(DeviceSourceAPI *deviceAPI) :
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
m_deviceAPI->setBuddySharedPtr(&m_sharedParams); m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
applySettings(m_settings, false);
} }
BladerfInput::~BladerfInput() BladerfInput::~BladerfInput()

View File

@ -54,8 +54,6 @@ FCDProInput::FCDProInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true);
} }
FCDProInput::~FCDProInput() FCDProInput::~FCDProInput()

View File

@ -53,8 +53,6 @@ FCDProPlusInput::FCDProPlusInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true);
} }
FCDProPlusInput::~FCDProPlusInput() FCDProPlusInput::~FCDProPlusInput()

View File

@ -54,6 +54,9 @@ FileSourceInput::FileSourceInput(DeviceSourceAPI *deviceAPI) :
m_startingTimeStamp(0), m_startingTimeStamp(0),
m_masterTimer(deviceAPI->getMasterTimer()) m_masterTimer(deviceAPI->getMasterTimer())
{ {
qDebug("FileSourceInput::FileSourceInput: device source engine: %p", m_deviceAPI->getDeviceSourceEngine());
qDebug("FileSourceInput::FileSourceInput: device source engine message queue: %p", m_deviceAPI->getDeviceEngineInputMessageQueue());
qDebug("FileSourceInput::FileSourceInput: device source: %p", m_deviceAPI->getDeviceSourceEngine()->getSource());
} }
FileSourceInput::~FileSourceInput() FileSourceInput::~FileSourceInput()

View File

@ -56,8 +56,6 @@ HackRFInput::HackRFInput(DeviceSourceAPI *deviceAPI) :
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
m_deviceAPI->setBuddySharedPtr(&m_sharedParams); m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
applySettings(m_settings, true);
} }
HackRFInput::~HackRFInput() HackRFInput::~HackRFInput()

View File

@ -61,8 +61,6 @@ LimeSDRInput::LimeSDRInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true, false);
} }
LimeSDRInput::~LimeSDRInput() LimeSDRInput::~LimeSDRInput()

View File

@ -52,8 +52,6 @@ PlutoSDRInput::PlutoSDRInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true);
} }
PlutoSDRInput::~PlutoSDRInput() PlutoSDRInput::~PlutoSDRInput()

View File

@ -59,8 +59,6 @@ RTLSDRInput::RTLSDRInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true);
} }
RTLSDRInput::~RTLSDRInput() RTLSDRInput::~RTLSDRInput()

View File

@ -53,8 +53,6 @@ SDRPlayInput::SDRPlayInput(DeviceSourceAPI *deviceAPI) :
sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID()); sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
m_fileSink = new FileRecord(std::string(recFileNameCStr)); m_fileSink = new FileRecord(std::string(recFileNameCStr));
m_deviceAPI->addSink(m_fileSink); m_deviceAPI->addSink(m_fileSink);
applySettings(m_settings, true, true);
} }
SDRPlayInput::~SDRPlayInput() SDRPlayInput::~SDRPlayInput()

View File

@ -7,12 +7,14 @@ set(filesource_SOURCES
${PLUGIN_PREFIX}/filesourceinput.cpp ${PLUGIN_PREFIX}/filesourceinput.cpp
${PLUGIN_PREFIX}/filesourceplugin.cpp ${PLUGIN_PREFIX}/filesourceplugin.cpp
${PLUGIN_PREFIX}/filesourcethread.cpp ${PLUGIN_PREFIX}/filesourcethread.cpp
${PLUGIN_PREFIX}/filesourcesettings.cpp
) )
set(filesource_HEADERS set(filesource_HEADERS
${PLUGIN_PREFIX}/filesourceinput.h ${PLUGIN_PREFIX}/filesourceinput.h
${PLUGIN_PREFIX}/filesourceplugin.h ${PLUGIN_PREFIX}/filesourceplugin.h
${PLUGIN_PREFIX}/filesourcethread.h ${PLUGIN_PREFIX}/filesourcethread.h
${PLUGIN_PREFIX}/filesourcesettings.h
) )
include_directories( include_directories(

View File

@ -95,8 +95,6 @@ void FileRecord::stopRecording()
bool FileRecord::handleMessage(const Message& message) bool FileRecord::handleMessage(const Message& message)
{ {
qDebug() << "FileRecord::handleMessage";
if (DSPSignalNotification::match(message)) if (DSPSignalNotification::match(message))
{ {
DSPSignalNotification& notif = (DSPSignalNotification&) message; DSPSignalNotification& notif = (DSPSignalNotification&) message;