From f1388ca5714684d02538ba022e4582e09ac84efb Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 18 Apr 2026 15:15:43 +0000
Subject: [PATCH] Polish freqdisplay GUI iteration and font scaling constant

Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/3b53c052-7f2b-4597-b509-d7cc17f3b0b0

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
---
 plugins/feature/freqdisplay/freqdisplaygui.cpp | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/plugins/feature/freqdisplay/freqdisplaygui.cpp b/plugins/feature/freqdisplay/freqdisplaygui.cpp
index 1d3d0f2e8..7227a7184 100644
--- a/plugins/feature/freqdisplay/freqdisplaygui.cpp
+++ b/plugins/feature/freqdisplay/freqdisplaygui.cpp
@@ -10,6 +10,10 @@
 #include "freqdisplay.h"
 #include "freqdisplaygui.h"
 
+namespace {
+constexpr double kFrequencyFontScale = 0.22;
+}
+
 FreqDisplayGUI* FreqDisplayGUI::create(PluginAPI* pluginAPI, FeatureUISet *featureUISet, Feature *feature)
 {
     return new FreqDisplayGUI(pluginAPI, featureUISet, feature);
@@ -125,17 +129,14 @@ void FreqDisplayGUI::updateChannelList()
 
     int selectedIndex = -1;
 
-    int i = 0;
-    for (const auto& availableChannel : m_availableChannels)
+    for (int i = 0; i < m_availableChannels.size(); ++i)
     {
-        const QString longId = availableChannel.getLongId();
+        const QString longId = m_availableChannels.at(i).getLongId();
         ui->channels->addItem(longId);
 
         if (longId == m_settings.m_selectedChannel) {
             selectedIndex = i;
         }
-
-        ++i;
     }
 
     if ((selectedIndex < 0) && (m_availableChannels.size() > 0)) {
@@ -227,7 +228,7 @@ void FreqDisplayGUI::updateFrequencyText()
 void FreqDisplayGUI::updateFrequencyFont()
 {
     const int minDimension = qMin(ui->frequencyValue->width(), ui->frequencyValue->height());
-    const int pointSize = qMax(10, static_cast<int>(minDimension * 0.22));
+    const int pointSize = qMax(10, static_cast<int>(minDimension * kFrequencyFontScale));
 
     QFont font = ui->frequencyValue->font();
     font.setPointSize(pointSize);