Commit Graph

34 Commits

Author SHA1 Message Date
Daniele Forsi 8829df3c3b Fix memleaks found with AddressSanitizer/LeakSanitizer
Found with:
ASAN_OPTIONS="detect_odr_violation=1,strip_path_prefix=$(pwd)/" build/sdrangel

Fixes:
Direct leak of 448 byte(s) in 2 object(s) allocated from:
    #0 0x7f78cd8f46b8 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:95
    #1 0x7f788e0e9d9c in GS232ControllerWorker::MsgConfigureGS232ControllerWorker::create(GS232ControllerSettings const&, QList<QString> const&, bool) sdrangel/plugins/feature/gs232controller/gs232controllerworker.h:51
    #2 0x7f788e0eeedf in GS232Controller::applySettings(GS232ControllerSettings const&, QList<QString> const&, bool) sdrangel/plugins/feature/gs232controller/gs232controller.cpp:291
    #3 0x7f788e0ec595 in GS232Controller::handleMessage(Message const&) sdrangel/plugins/feature/gs232controller/gs232controller.cpp:156
    #4 0x7f78cabe899f in Feature::handleInputMessages() sdrangel/sdrbase/feature/feature.cpp:46
    #5 0x7f78ca9f9b5c in Feature::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) build-sdrangel-Desktop_qt5-Debug/sdrbase/sdrbase_autogen/3DM3QXXG3A/moc_feature.cpp:89
    #6 0x7f78c7f05fcc  (/lib/x86_64-linux-gnu/libQt5Core.so.5+0x305fcc) (BuildId: ed2abb344a128279a866aa6c4a79f3fa5c87c59e)
    #7 0x7f78caa0584a in MessageQueue::messageEnqueued() build-sdrangel-Desktop_qt5-Debug/sdrbase/sdrbase_autogen/KH43KSYMFX/moc_messagequeue.cpp:131
    #8 0x7f78cad19c77 in MessageQueue::push(Message*, bool) sdrangel/sdrbase/util/messagequeue.cpp:55
    #9 0x7f788e142936 in GS232ControllerGUI::applySettings(QStringList const&, bool) sdrangel/plugins/feature/gs232controller/gs232controllergui.cpp:969
    #10 0x7f788e142727 in GS232ControllerGUI::applySetting(QString const&) sdrangel/plugins/feature/gs232controller/gs232controllergui.cpp:960
    #11 0x7f788e133c26 in GS232ControllerGUI::onWidgetRolled(QWidget*, bool) sdrangel/plugins/feature/gs232controller/gs232controllergui.cpp:206
    #12 0x7f788e0e25d9 in GS232ControllerGUI::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) build-sdrangel-Desktop_qt5-Debug/plugins/feature/gs232controller/featuregs232controller_autogen/EWIEGA46WW/moc_gs232controllergui.cpp:234
    #13 0x7f78c7f05fcc  (/lib/x86_64-linux-gnu/libQt5Core.so.5+0x305fcc) (BuildId: ed2abb344a128279a866aa6c4a79f3fa5c87c59e)
    #14 0x7f78ccdcd9a1 in RollupContents::widgetRolled(QWidget*, bool) build-sdrangel-Desktop_qt5-Debug/sdrgui/sdrgui_autogen/DMHXEJ42XS/moc_rollupcontents.cpp:146
    #15 0x7f78cd06a080 in RollupContents::eventFilter(QObject*, QEvent*) sdrangel/sdrgui/gui/rollupcontents.cpp:403
    #16 0x7f78c7ecc4b2 in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2cc4b2) (BuildId: ed2abb344a128279a866aa6c4a79f3fa5c87c59e)

and more
2024-05-19 19:44:45 +02:00
Mykola Dvornik 15337cac66 Fix bug that prevents settings changes updates via reverse API
Most plugins that use reverse API to PATCH settings updates to remote
server only do so when `useReverseAPI` is toggled, but not when the
relevant settings are being updated. So lets fix the precondition to
use the `m_useReverseAPI` flag instead.
2024-04-14 18:58:12 +02:00
Daniele Forsi 8c3f7e3775 Remove unused includes and use more direct includes 2024-04-11 23:31:34 +02:00
srcejon e1817958b5 Fix warnings and Sky Map connections. 2024-02-16 18:08:31 +00:00
srcejon 483e338614 Add AvailableChannelOrFeatureHandler for handling lists of channels, features and message pipes to them. 2024-02-16 16:31:12 +00:00
srcejon 607d7db702 Use MainCore code for managing available channel and feature list. 2024-02-14 15:36:22 +00:00
srcejon 1ace16cfe2 Add Sky Map support to Rotator Controller. 2024-02-14 13:21:26 +00:00
f4exb 00b041d762 Rewriting of copyright notices for plugins/features. Part of #1893 2023-11-18 13:12:18 +01:00
Jon Beniston 2d7c572040 Rotator Controller: Add additional gamepad calibration and functionality 2023-08-05 12:33:01 +01:00
Jon Beniston a1c1308580 Rotator Controller: Add gamepad input controller support. 2023-04-23 19:52:02 +01:00
Jon Beniston 4ac5e729ff Rotator Controller Updates
Add support for X/Y coordinates.
Add coordinate precision setting.
Automatically scan for serial port changes.
Refactor so each protocol is implemented in a separate class.
Add start of DFM protocol.
2023-04-03 16:47:13 +01:00
f4exb 005cee925d Rotator Controller feature: Make settings assignments atomic. Part of #1329 2022-11-24 16:40:36 +01:00
Jon Beniston a618dae6e7 Check for existing pipes after GUI is created. For #1484 2022-10-27 19:15:46 +01:00
Jon Beniston b1ce69fb2b Call stopWork from destructor. 2022-09-20 21:13:12 +01:00
Jon Beniston 5da8d6d28c Update threading in Rotator Controller for #1346 2022-09-18 16:47:06 +01:00
f4exb 842546aec6 Rotator controller and dependent plugins: implemented new message pipes and other fixes. Part of #1154 2022-03-28 20:12:25 +02:00
f4exb 4111c967e9 Fixed some signal/slot connects. Removed unnecessary m_channelMessageQueue in ChannelAPI. Fixes #1185 2022-03-23 22:32:23 +01:00
f4exb 98b305f320 Make rollup state a serializable object so that it can be dumped in JSON format for the API. Prerequisite tp #1050 2022-01-09 05:27:12 +01:00
Jon Beniston d5857c3878 Move Feature workers to thread 2021-11-25 09:28:59 +00:00
Jon Beniston fb394165a3 Update API 2021-11-23 12:28:06 +00:00
f4exb fee2c5065d API: report running state for feature plugins with run action 2021-10-23 21:24:25 +02:00
f4exb 10f79b183f Implemented run action API in relevant feature plugins. Missing bits. 2021-10-23 10:53:15 +02:00
f4exb 920fa82022 Implemented run action API in relevant feature plugins 2021-10-22 02:01:33 +02:00
Jon Beniston 1de5a38d6b Fix gcc warnings 2021-10-12 12:10:12 +01:00
Jon Beniston 750f556eaa GS-232 Controller Updates
Fix broken pipe #1006.
Add onTarget and current and target aziumth and elevation to web report.
Set run/stop button background to yellow when rotator is rotating (not onTarget).
Use floating point value for tolerance setting.
2021-10-05 14:03:31 +01:00
f4exb 00b3ae29d9 GS232 Controller API: added serial devices to report + fixes 2021-10-04 02:11:27 +02:00
f4exb f5e14f6502 GS232 Feature: rename targets as sources. API: created GS232 report and fixed missing source name in get settings 2021-10-03 23:15:15 +02:00
Jon Beniston f51e8b4095 Add SPID rot2prog protocol support. Add tolerance setting. 2021-05-30 12:38:07 +01:00
Jon Beniston cd504da84e Add min and max limits for azimuth and elevation in GS-232 controller. Add satellite tracker support 2021-02-26 20:27:35 +00:00
Jon Beniston d507f49626 Instantiate QNetworkAccessManager to avoid crash on reverse API usage 2021-01-15 11:24:21 +00:00
Jon Beniston 931a63dc8b GS-232 Controller updates.
Update GS-232 controller to use message pipes for the target.
Add field displaying the name of the target.
Add azimuth and elevation offsets.
Report worker thread errors to the GUI.
2021-01-13 19:44:53 +00:00
Kacper Michajłow f2d01b61d3 Avoid global QString init in plugins
This workarounds issue with LTO with GCC #716
2020-11-22 04:06:32 +01:00
f4exb 55eb6cc951 Fixed -Wunused-parameter warnings 2020-11-14 11:13:32 +01:00
Jon Beniston 1a9b6d1763 Add ADS-B Demodulator plugin.
Add GS232 Rotator Controller feature plugin.
Add altitude and station name to My Positon.
Use QtDeploy to ensure all required Qt libraries are included (Should
fix OpenGL issues)
2020-10-27 16:22:10 +00:00