MessageQueue::pop() transfers ownership of the popped message to the
caller, but many handleInputMessages() implementations only deleted
the message when handleMessage() returned true. When a message was not
handled, ownership had already been transferred from the queue and the
message was leaked.
This was identified while investigating an ASAN leak in the audio
subsystem.
Update the applicable handleInputMessages() implementations to always
delete messages after handleMessage() returns. Unhandled messages are
also logged with the component and message identifier so unexpected
message routing is visible during debugging.
This change:
- Ensures every message popped from a queue has its ownership resolved.
- Prevents leaks when handleMessage() returns false.
- Makes unhandled messages visible instead of silently discarding them.
- Preserves the existing message handling logic and does not require
components to handle message types that are legitimately irrelevant
to them.
The changes are intentionally mechanical and limited to the common
message queue ownership and diagnostic pattern.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Initialize previously uninitialized RigCtlServerWorker target frequency,
offset, and bandwidth members to defined values to eliminate cppcheck
UNINIT_CTOR warnings. This ensures target settings start in a known state
and avoids undefined behavior from reading uninitialized values.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Robin Getz
f4exb
Daniele Forsi
Jiří Pinkava
Christian W. Zuckschwerdt