1
0
mirror of https://github.com/f4exb/sdrangel.git synced 2024-11-23 00:18:37 -05:00
Commit Graph

13 Commits

Author SHA1 Message Date
Jason Gerecke
7c67b7de7c qrtplib: clear buffer fed to RTPSession::CreateCNAME
The RTPSession::CreateCNAME function checks to see if the buffer that
it is provided already has any data in it, and appends to it if so. The
RTPSession::InternalCreate function calls this function with an uninitialized
buffer, which results in indeterminate behavior. To ensure that the CNAME
is properly created, we clear the buffer before use.

==30323== Conditional jump or move depends on uninitialised value(s)
==30323==    at 0x4C30109: __strlen_sse2 (vg_replace_strmem.c:460)
==30323==    by 0x85647A4: qrtplib::RTPSession::CreateCNAME(unsigned char*, unsigned long*, bool) (rtpsession.cpp:1150)
==30323==    by 0x8564B35: qrtplib::RTPSession::InternalCreate(qrtplib::RTPSessionParams const&) (rtpsession.cpp:218)
==30323==    by 0x5499159: RTPSink::RTPSink(QUdpSocket*, int, bool) (rtpsink.cpp:48)
==30323==    by 0x5420B6A: AudioNetSink::AudioNetSink(QObject*, int, bool) (audionetsink.cpp:42)
==30323==    by 0x541F465: AudioOutput::start(int, int) (audiooutput.cpp:114)
==30323==    by 0x5412763: AudioDeviceManager::startAudioOutput(int) (audiodevicemanager.cpp:361)
==30323==    by 0x5412B0C: AudioDeviceManager::addAudioSink(AudioFifo*, MessageQueue*, int) (audiodevicemanager.cpp:229)
==30323==    by 0x33F96DE7: BFMDemod::BFMDemod(DeviceSourceAPI*) (bfmdemod.cpp:56)
==30323==    by 0x33FB03F2: non-virtual thunk to BFMPlugin::createRxChannelBS(DeviceSourceAPI*) (bfmplugin.cpp:62)
==30323==    by 0x4F47F25: DeviceUISet::loadRxChannelSettings(Preset const*, PluginAPI*) (deviceuiset.cpp:199)
==30323==    by 0x4EA51EA: MainWindow::loadPresetSettings(Preset const*, int) (mainwindow.cpp:575)
==30323==    by 0x4EAC81B: MainWindow::MainWindow(qtwebapp::LoggerWithFile*, MainParser const&, QWidget*) (mainwindow.cpp:176)
==30323==    by 0x10A49B: runQtApplication(int, char**, qtwebapp::LoggerWithFile*) (main.cpp:120)
==30323==    by 0x109B38: main (main.cpp:131)
2018-04-21 18:52:20 -07:00
f4exb
8dfdc1086c PVS-Studio static analysis corrections (4) 2018-04-04 23:39:31 +02:00
f4exb
3c4d40ac73 qrtplib: Windows build 2018-03-05 16:40:53 +01:00
f4exb
afe3fbabd3 qrtplib: new RTPUDPTransmitter 2018-03-05 01:17:19 +01:00
f4exb
f678c049f9 qrtplib: replaced size_t by std::size_t 2018-02-28 13:31:44 +01:00
f4exb
a0c7381047 qrtplib: implemented Qt style RTP address object 2018-02-28 01:37:47 +01:00
f4exb
92bc10efe6 qrtplib: removed probation support 2018-02-27 23:36:24 +01:00
f4exb
fb4d07c275 qrtplib: removed unknown packet support 2018-02-27 23:13:12 +01:00
f4exb
ff4a35b3e3 qrtplib: removed memory management 2018-02-27 23:05:46 +01:00
f4exb
8c1293e213 qrtplib: restored new operator 2018-02-27 02:44:27 +01:00
f4exb
c1c705b8be qrtplib: removed IPV6 and netinet dependency 2018-02-27 02:14:45 +01:00
f4exb
c15c8b79d9 qrtplib: removed jthread 2018-02-27 01:43:41 +01:00
f4exb
30d019d39a qrtplib: removed debug 2018-02-27 01:35:16 +01:00