Commit Graph
870 Commits
Author SHA1 Message Date
Robin Getz 164a35b083 map: release aircraft state with map item
Add a destructor to ObjectMapItem to release its owned m_aircraftState.

ObjectMapItem allocates m_aircraftState when aircraft state is present,
but had no corresponding cleanup when the map item was destroyed.

Coverity reported the allocation as a constructor/destructor resource
leak.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-08-09 17:41:39 -04:00
Edouard Griffiths 7abc5b3274 Merge pull request #2873 from srcejon/fixes
AIS, Packet and Pager demodulator improvements
2026-08-07 19:02:06 +02:00
srcejon 0d67de7847 Merge branch 'f4exb:master' into fixes 2026-08-03 13:42:07 +01:00
Robin Getz 7e96f9c139 simpleptt: Initialize rx to tx GPIO enable setting
Coverity reported an uninitialized m_rx2txGPIOEnable value when it was
used by SimplePTTGUI before settings were loaded. Initialize the setting
in resetToDefaults() to provide a defined default value.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-08-02 20:39:52 -04:00
Robin Getz bef0b8184e vorlocalizer: Fix round robin plan sorting comparator
The channel count comparison in getChannelsByDevice() accidentally used
the first plan's channel count for both operands. This caused the comparator
to always treat the channel counts as equal and sort only by bandwidth.

Use the second plan's channel count when comparing RRTurnPlans so plans are
ordered correctly by number of channels before applying the bandwidth
tie-breaker.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-08-01 19:16:31 -04:00
Jon Beniston 2cb8091c54 Allow zooming in on chart and hiding of series. 2026-08-01 21:09:30 +01:00
Jon Beniston 77e43defe6 Add message / ship chart.
Add images of ships from VesselFinder.
2026-08-01 20:56:52 +01:00
Jon Beniston fd72109d37 Merge branch 'fixes' of https://github.com/srcejon/sdrangel into fixes 2026-08-01 15:31:38 +01:00
Robin Getz 09980d9782 APRSGUI: Fix displayTableSettings argument order
cppcheck reported that the displayTableSettings() declaration argument
order differed from the function definition. The header declared the
arguments as (columnIndexes, columnSizes), while the implementation and
all call sites use (columnSizes, columnIndexes).

Update the declaration to match the implementation and remove ambiguity
between the table column width and ordering arrays.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-07-31 21:02:23 -04:00
Jon Beniston 13f9fe4cd7 Remove unused variables and support port 65535. 2026-07-31 15:57:06 +01:00
Jon Beniston 5271173997 Add missing label offsets. Fix bounded so tug 3 is used. 2026-07-31 15:49:54 +01:00
Jon Beniston ee3b8c14a3 Remove unused variable. 2026-07-31 15:48:18 +01:00
Jon Beniston d6ddad8b83 Handle less columns being supplied than we have. 2026-07-31 15:47:58 +01:00
Jon Beniston 6373df9f8a Fix memory leak 2026-07-31 02:05:35 +01:00
Edouard Griffiths 31580ca25a Merge pull request #2821 from srcejon/fix_2819
APRS: Fix memory leak.
2026-07-22 05:18:09 +02:00
Jon Beniston 08ed42bf73 APRS: Fix memory leak. 2026-07-21 10:32:00 +01:00
Robin Getz 0659f264aa VOR Localizer: initialize intersection variables
Initialize the coordinate and bearing variables used by
VORModel::findIntersection() and declare the validity flags as bool.

Coverity reported that lat1, lon1, bearing1, lat2, lon2, and bearing2
could be passed uninitialized to calcIntersectionPoint(). While the
current control flow is intended to assign these values before the
corresponding validity flag is set, they were not initialized at
declaration, leaving undefined behavior if that invariant were ever
broken.

Initializing the variables removes the possibility of using
indeterminate values, satisfies static analysis, and makes the code
more robust against future modifications. The validity flags are also
changed from float to bool to match their intended use.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-07-20 17:25:57 -04:00
Jon Beniston ad5ca070e8 Fix constant to be 32MHz instead of 320MHz. Fixes #2801 2026-07-19 17:09:30 +01:00
Jon Beniston a83dd8b8a0 Use default QSurfaceFormat when MSAA enabled. May fix #2788, #2022 and #1616 2026-07-07 14:06:13 +01:00
f4exb 13fdc156a2 Tried to fix Debian builds 2026-06-03 03:06:36 +02:00
f4exb 7e37ca68a2 Release v7.26.0 2026-06-02 21:37:05 +02:00
srcejon e3e2f5bb20 Add active only button. Increase poll frequency. Support channels that don't have a frequency offset. 2026-05-05 10:45:24 +01:00
f4exb ef4357f26b Release 7.25.0 2026-05-04 06:00:17 +02:00
Tammo Jan Dijkema c86c178363 Use Qt6.2 compatible qt_add_plugin in CMake 2026-04-25 17:11:41 +02:00
Jon Beniston 6f97e12a70 Make private 2026-04-22 22:04:53 +01:00
copilot-swe-agent[bot]andsrcejon 42a65a0311 refactor: use MainCore::getDeviceAndChannelIndexFromId in webapiFormatFeatureReport
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/68c9a41e-19ba-45f8-955d-b7b2e2b9fd8f

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-22 20:51:13 +00:00
Jon Beniston c545a835e1 Bring in line with other features. 2026-04-22 21:46:32 +01:00
copilot-swe-agent[bot]andsrcejon 4581df2c53 refactor: make FreqDisplay::applySettings private; use MsgConfigureFreqDisplay in FreqDisplayGUI::applySettings
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/d71b1b23-0809-4351-bfc0-1f46a26a49cc

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-22 20:23:48 +00:00
copilot-swe-agent[bot]andsrcejon 220f5d11ab feat: add FreqDisplay webapiReportGet, webapiFormatFeatureReport; add freqDecimalPlaces and dropShadowColor to settings webapi methods
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/896509c5-b3f8-406a-98db-4b744f7a918c

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-22 19:20:46 +00:00
Jon Beniston c44925dba3 Fix webapi for Freq Display. 2026-04-22 20:09:41 +01:00
Jon Beniston fd9f3ac632 Fix compilation. 2026-04-22 19:34:49 +01:00
copilot-swe-agent[bot]andsrcejon 219ece573c feat: implement FreqDisplay WebAPI (webapiSettingsGet/PutPatch, format/update, reverseSend)
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/373fd0a8-4ef8-4849-8b8e-adb0a988230d

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-22 18:28:48 +00:00
Jon Beniston 3a15e13cde Implement FreqDisplayWebAPIAdapter 2026-04-22 16:34:46 +01:00
Jon Beniston a298406d74 Fix use of settings keys.
Add onMenuDialogCalled to support basic settings dialog.
2026-04-20 10:15:13 +01:00
Jon Beniston afde6d50b4 Update naming convention. 2026-04-20 09:35:04 +01:00
Jon Beniston 1d4a936f86 Add drop shadow to docs. 2026-04-20 09:24:34 +01:00
copilot-swe-agent[bot]andsrcejon 154e52d0b2 refactor: move anonymous namespace members into FreqDisplayGUI as static members
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/822b5f58-a706-4e7c-af65-8d2b5c4be5b1

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-19 22:07:58 +00:00
copilot-swe-agent[bot]andsrcejon 9363b043a1 feat: add drop shadow ButtonSwitch and color picker to freqdisplay
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/41854996-2343-4d0a-b99a-2a0ebdc8e586

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-19 21:44:13 +00:00
Jon Beniston 8896ed129a Fix both windows being displayed at startup, if transparency enabled. 2026-04-19 22:24:26 +01:00
Jon Beniston dc960c2dfd Position overlay so it's where the frequencyValue widget was. 2026-04-19 21:56:51 +01:00
copilot-swe-agent[bot]andsrcejon 19cc426948 feat: replace frequencyValue QLabel with FrequencyLabel custom widget (minimumSizeHint 50x10)
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/882a0465-b780-4bea-a664-422995cba8b7

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-19 20:46:23 +00:00
Jon Beniston ef335dd1ff Disable word wrapping 2026-04-19 21:41:53 +01:00
Jon Beniston cf82d023c6 Don't use a container for the frequencyValue 2026-04-19 21:15:18 +01:00
Jon Beniston 4c86f1c4b9 Add documentation. 2026-04-19 17:51:05 +01:00
Jon Beniston 01b53f50b0 Fix window sizing by calling sizeToContents. Roll back previous commit.
Add rollup settings.
2026-04-19 17:12:51 +01:00
copilot-swe-agent[bot]andsrcejon 2bbe19af46 freqdisplay: fix font sizing to respect both width and height constraints
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/8205839a-4dad-46b0-8fbf-02dd31499bb7

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-19 10:58:06 +00:00
Jon Beniston ffe32eb1a0 Speech current text when speech enabled. Disable speech button if not available.
Fix font color button.
Add rollup titles.
2026-04-19 11:52:39 +01:00
copilot-swe-agent[bot]andsrcejon 6b67959774 freqdisplay: add text color picker button saved as setting, default white
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/6d0cceb4-1d01-4c8e-95aa-f203715615cc

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-19 10:34:01 +00:00
Jon Beniston 1f41715197 Rearrange GUI 2026-04-19 11:28:03 +01:00
copilot-swe-agent[bot]andsrcejon ff06cf1935 freqdisplay: fix crash on exit transparent mode by using deleteLater()
Agent-Logs-Url: https://github.com/srcejon/sdrangel/sessions/9fb3e940-7f8e-46a9-8095-5ebc03428c00

Co-authored-by: srcejon <57259258+srcejon@users.noreply.github.com>
2026-04-19 10:16:13 +00:00