Commit Graph
33 Commits
Author SHA1 Message Date
Jon Beniston a0918b5785 Map API names to setting names.
Fix API settings with spelling mistakes.
2026-09-13 12:09:20 +01:00
Jon BenistonandClaude Opus 5 60db861797 Fix QString leak in the web API settings and report formatters
The generated SWG setters overwrite the string pointer without deleting
what is already there, and every webapiSettingsGet and webapiReportGet
calls init() first, which has allocated one. Each call therefore leaked a
QString per string field. Measured at 117 bytes per settings GET for the
Satellite Tracker, over 20,000 requests.

Assign in place when the pointer is already set, which is what these same
functions have always done for title and reverseAPIAddress. 394 sites
across webapiFormatChannelSettings, webapiFormatDeviceSettings,
webapiFormatFeatureSettings and the three report equivalents.

The webapiReverseSend* functions are deliberately left alone: they build a
fresh SWG object whose constructor leaves the pointers null, so passing a
new QString is correct there.

After the change the same measurement is flat, at 7 bytes per GET.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-11 16:54:42 +01:00
f4exb 63348eeee1 Make device title editable in the basic device settings. Fixes #2292 2026-01-28 03:05:39 +01:00
Mykola Dvornik 15337cac66 Fix bug that prevents settings changes updates via reverse API
Most plugins that use reverse API to PATCH settings updates to remote
server only do so when `useReverseAPI` is toggled, but not when the
relevant settings are being updated. So lets fix the precondition to
use the `m_useReverseAPI` flag instead.
2024-04-14 18:58:12 +02:00
Daniele Forsi 8c3f7e3775 Remove unused includes and use more direct includes 2024-04-11 23:31:34 +02:00
f4exb b6c4d10b62 Rewriting of copyright notices for plugins/samplesource. Part of #1893 2023-11-18 10:07:41 +01:00
f4exb 68c534f848 Remote Input: Make settings assignments atomic. Part of #1329 2022-10-28 20:57:20 +02:00
Jiří Pinkava 0df2d75e6d Replace deprecated QMutex(Recursive) with QRecursiveMutex 2022-09-17 23:00:07 +02:00
f4exb 4111c967e9 Fixed some signal/slot connects. Removed unnecessary m_channelMessageQueue in ChannelAPI. Fixes #1185 2022-03-23 22:32:23 +01:00
f4exb 053e4a31cd Add label to SampleSinkFifo to mention controlling component in error messages 2022-03-18 21:53:53 +01:00
f4exb 180d554812 Remote Input: do not apply remote channel settings before they get updated via stream 2022-01-11 23:23:18 +01:00
f4exb 128dd03684 New Jogdial Controller feature plugin. Implements #1088 2022-01-06 22:47:41 +01:00
f4exb 58a9b2996d Remote input/sink implemented remote control. Implements #1074 2021-12-26 11:56:37 +01:00
f4exb d981912eee Remote input: removed API calls from GUI 2021-12-25 12:54:33 +01:00
f4exb 9bb3a273b3 Remote input/sink implemented remote control (1) 2021-12-24 21:06:15 +01:00
f4exb 459298687b Remote Input: multicast: REST API implementation 2020-08-27 09:55:04 +02:00
f4exb 2b1ddc7208 Remote Input: added option to join a multicast group. Implements #611 2020-08-27 07:40:54 +02:00
f4exb e6e7ece46c Removed file recording function from device plugins 2020-08-09 00:47:06 +02:00
f4exb d93651dedb RemoteInput; do not stop UDP handler when stopping else it blocks the restart. Fixes issue #563 2020-07-13 00:06:48 +02:00
f4exb 16364d604a Remote input buffer size rework: member name changes. Adjust sample sink fifo size from sample rate 2020-06-28 10:14:35 +02:00
f4exb 323e75cddd REST API device and channel actions: extension of record action: implementation 2020-03-10 19:44:27 +01:00
f4exb 246ff824af Corrected network manager process memory leaks (Rx side) 2019-11-12 18:46:45 +01:00
f4exb f80d16451b REST API: config: PUT (1): swagger implementation. Various small fixes 2019-08-05 18:29:09 +02:00
f4exb a078239685 REST API: config: GET (11). Support of the rest of devices 2019-08-04 20:24:44 +02:00
f4exb 06dea9b29f PVS-Studio analys fixes: core package serious issues 2019-06-14 16:58:09 +02:00
f4exb b01c4e2477 Device API: added a number of source and sink streams and update it from the plugins 2019-05-21 00:27:08 +02:00
f4exb 89e53cf179 Single DeviceAPI interface (1) 2019-05-08 22:11:53 +02:00
f4exb 54e46837dd REST API: changed binary tx parameter to ternary direction parameter (0: rx, 1: tx, 2: any) 2019-05-07 14:43:38 +02:00
f4exb 4bb0f4f51a Fixed incomplete copyright headers (2): plugins/samplesource 2019-04-11 06:57:41 +02:00
f4exb cd35732807 Reverse API originator information: implemented for start/stop in all source plugins 2019-03-25 15:21:17 +01:00
f4exb 9b30d602c3 Reverse API originator information: implemented in all source plugins 2019-03-25 13:41:38 +01:00
f4exb 60ca383a6e Rename SDRDaemonSource device plugin to RemoteInput (2): REST API 2019-02-03 00:49:57 +01:00
f4exb 4fe16095d4 Rename SDRDaemonSource device plugin to RemoteInput (1) 2019-02-03 00:26:26 +01:00