Commit Graph
78 Commits
Author SHA1 Message Date
Jon BenistonandClaude Opus 5 60db861797 Fix QString leak in the web API settings and report formatters
The generated SWG setters overwrite the string pointer without deleting
what is already there, and every webapiSettingsGet and webapiReportGet
calls init() first, which has allocated one. Each call therefore leaked a
QString per string field. Measured at 117 bytes per settings GET for the
Satellite Tracker, over 20,000 requests.

Assign in place when the pointer is already set, which is what these same
functions have always done for title and reverseAPIAddress. 394 sites
across webapiFormatChannelSettings, webapiFormatDeviceSettings,
webapiFormatFeatureSettings and the three report equivalents.

The webapiReverseSend* functions are deliberately left alone: they build a
fresh SWG object whose constructor leaves the pointers null, so passing a
new QString is correct there.

After the change the same measurement is flat, at 7 bytes per GET.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-11 16:54:42 +01:00
f4exb 63348eeee1 Make device title editable in the basic device settings. Fixes #2292 2026-01-28 03:05:39 +01:00
f4exb 585d806ef8 All device plugins: make sure start and stop are effective once only. PArt of #2159 2024-08-27 09:54:09 +02:00
f4exb ade3eedfa5 SDRPlay v1: fix setting of hardware flavour. Fixes #2127 2024-06-02 03:27:52 +02:00
Mykola Dvornik 15337cac66 Fix bug that prevents settings changes updates via reverse API
Most plugins that use reverse API to PATCH settings updates to remote
server only do so when `useReverseAPI` is toggled, but not when the
relevant settings are being updated. So lets fix the precondition to
use the `m_useReverseAPI` flag instead.
2024-04-14 18:58:12 +02:00
Daniele Forsi 8c3f7e3775 Remove unused includes and use more direct includes 2024-04-11 23:31:34 +02:00
f4exb b6c4d10b62 Rewriting of copyright notices for plugins/samplesource. Part of #1893 2023-11-18 10:07:41 +01:00
f4exb b3539c9292 SDRPlay: Make settings assignments atomic. Part of #1329 2022-10-28 20:57:21 +02:00
ericek111 557147d09e SDRPlayInput: separate HW flavour from mirisdr_open 2022-07-18 15:52:40 +02:00
f4exb 4111c967e9 Fixed some signal/slot connects. Removed unnecessary m_channelMessageQueue in ChannelAPI. Fixes #1185 2022-03-23 22:32:23 +01:00
f4exb 053e4a31cd Add label to SampleSinkFifo to mention controlling component in error messages 2022-03-18 21:53:53 +01:00
f4exb 29d4a67eac SDRplay v1: fixed frequency boundaries in report. Fixes #1061 2021-12-01 21:09:21 +01:00
f4exb e6e7ece46c Removed file recording function from device plugins 2020-08-09 00:47:06 +02:00
f4exb c4136c6a44 IQ swap: REST API: implementation in plugins 2020-06-23 19:56:50 +02:00
f4exb cc5d614f67 IQ swap: initial implementation in plugins 2020-06-23 19:29:58 +02:00
f4exb 323e75cddd REST API device and channel actions: extension of record action: implementation 2020-03-10 19:44:27 +01:00
f4exb 246ff824af Corrected network manager process memory leaks (Rx side) 2019-11-12 18:46:45 +01:00
f4exb a078239685 REST API: config: GET (11). Support of the rest of devices 2019-08-04 20:24:44 +02:00
f4exb 06dea9b29f PVS-Studio analys fixes: core package serious issues 2019-06-14 16:58:09 +02:00
f4exb b01c4e2477 Device API: added a number of source and sink streams and update it from the plugins 2019-05-21 00:27:08 +02:00
f4exb 89e53cf179 Single DeviceAPI interface (1) 2019-05-08 22:11:53 +02:00
f4exb 54e46837dd REST API: changed binary tx parameter to ternary direction parameter (0: rx, 1: tx, 2: any) 2019-05-07 14:43:38 +02:00
f4exb 4bb0f4f51a Fixed incomplete copyright headers (2): plugins/samplesource 2019-04-11 06:57:41 +02:00
f4exb e2ac286458 Series of shifted decimators matching shifted interpolators. Applied to HackRF input 2019-04-02 01:10:03 +02:00
f4exb cd35732807 Reverse API originator information: implemented for start/stop in all source plugins 2019-03-25 15:21:17 +01:00
f4exb 9b30d602c3 Reverse API originator information: implemented in all source plugins 2019-03-25 13:41:38 +01:00
f4exb 0215839220 REST API: implement reverse API settings (3) 2019-01-11 14:45:00 +01:00
f4exb c6e057b143 Reverse API: SDR Play RSP1 2018-12-26 17:35:55 +01:00
f4exb 7574cb23d4 Windows: MSVC2017: fixed more attribute unused cases (2) 2018-11-13 08:51:14 +01:00
f4exb 213d19eb42 Server: added SDRplay input plugin 2018-05-29 20:52:44 +02:00
f4exb da3cb2d981 SDRPlay input: implemeted WEB API (2) 2018-05-27 20:15:55 +02:00
f4exb 2184425311 Web API: put some array items in their own classes 2018-05-27 19:54:33 +02:00
f4exb 9360c4de0b SDRPlay input: implemeted WEB API (1) 2018-05-27 11:57:23 +02:00
beta-tester 15078c9c07 modified unique file name 2018-05-11 09:08:20 +02:00
f4exb 6a5a35285e SDRplay input: rework of center frequency setting 2018-05-10 15:14:43 +02:00
f4exb 775b2a270d File record default file name fix (2) 2018-05-09 17:39:48 +02:00
f4exb 0981d04904 File record default file name fix (1) 2018-05-08 11:03:09 +02:00
f4exb 5b7cbdf0e5 Multiple audio support: transfer start/stop audio to audio FIFO management in AudioDeviceManager 2018-03-24 04:18:58 +01:00
f4exb 2e5cfcafee PVS-Studio static analysis corrections (3) issue #137 2018-02-24 10:29:27 +01:00
f4exb 2b846f5d28 PVS-Studio static analysis corrections (2) issue #137 2018-02-22 03:04:42 +01:00
f4exb 057a8f94bb Airspy, BladeRF, HackRF, PlutoSDR, RTLSDR, SDRPlay: fixed frequency setting when changing decimation with fc position change 2018-01-20 03:28:30 +01:00
f4exb 8399baeb4e Source plugins: put a serializer and deserializer in the core plugin for server. NFM demod: fixed deserializer 2017-12-28 03:21:48 +01:00
f4exb 49d1439981 Device source plugins: implemented an init method for initializations to be done when all collaborating objects are created and possibly connected 2017-12-25 09:10:19 +01:00
f4exb b127182062 All plugins: removed apply settings in constructors as it causes segfaults 2017-12-24 18:37:33 +01:00
f4exb 8e07820e8e all source and sink plugins except FileSource and SDRdaemonSource: apply settings with force on construction 2017-12-24 11:05:16 +01:00
f4exb dbeeaa8f66 Recognize SDRplay RSP2 but do not support it effectively 2017-12-20 21:38:56 +01:00
f4exb 934af70c74 Recognize SDRplay RSP1A but do not support it effectively 2017-12-19 22:46:17 +01:00
f4exb 6de0e20ceb Web API: /sdrangel/deviceset/{deviceSetIndex}/device/run POST,DELETE: return previous state instead of attempt to wait and return the state after change since it does not work reliably 2017-12-14 23:29:12 +01:00
f4exb 53925bd4fd Web API: fixed segfault when mixing start/stop between GUI and API. Applied to BladeRF input, SDRdaemon input and SDRPlay 2017-12-14 00:19:59 +01:00
f4exb 565083e5f5 Web API: implemented device run APIs for BladeRF output, HackRF, PlutoSDR and LimeSDR ourput 2017-12-10 01:57:50 +01:00