Commit Graph
28 Commits
Author SHA1 Message Date
Jon BenistonandClaude Opus 5 60db861797 Fix QString leak in the web API settings and report formatters
The generated SWG setters overwrite the string pointer without deleting
what is already there, and every webapiSettingsGet and webapiReportGet
calls init() first, which has allocated one. Each call therefore leaked a
QString per string field. Measured at 117 bytes per settings GET for the
Satellite Tracker, over 20,000 requests.

Assign in place when the pointer is already set, which is what these same
functions have always done for title and reverseAPIAddress. 394 sites
across webapiFormatChannelSettings, webapiFormatDeviceSettings,
webapiFormatFeatureSettings and the three report equivalents.

The webapiReverseSend* functions are deliberately left alone: they build a
fresh SWG object whose constructor leaves the pointers null, so passing a
new QString is correct there.

After the change the same measurement is flat, at 7 bytes per GET.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-11 16:54:42 +01:00
f4exb 63348eeee1 Make device title editable in the basic device settings. Fixes #2292 2026-01-28 03:05:39 +01:00
f4exb b85419c56a Sonar fixes 2024-08-27 09:54:09 +02:00
f4exb 585d806ef8 All device plugins: make sure start and stop are effective once only. PArt of #2159 2024-08-27 09:54:09 +02:00
Daniele Forsi 8c3f7e3775 Remove unused includes and use more direct includes 2024-04-11 23:31:34 +02:00
f4exb b6c4d10b62 Rewriting of copyright notices for plugins/samplesource. Part of #1893 2023-11-18 10:07:41 +01:00
f4exb 58456273b7 BladeRF1: Make settings assignments atomic. Part of #1329 2022-10-22 19:05:33 +02:00
f4exb 4111c967e9 Fixed some signal/slot connects. Removed unnecessary m_channelMessageQueue in ChannelAPI. Fixes #1185 2022-03-23 22:32:23 +01:00
f4exb 053e4a31cd Add label to SampleSinkFifo to mention controlling component in error messages 2022-03-18 21:53:53 +01:00
f4exb e6e7ece46c Removed file recording function from device plugins 2020-08-09 00:47:06 +02:00
f4exb c4136c6a44 IQ swap: REST API: implementation in plugins 2020-06-23 19:56:50 +02:00
f4exb cc5d614f67 IQ swap: initial implementation in plugins 2020-06-23 19:29:58 +02:00
f4exb 323e75cddd REST API device and channel actions: extension of record action: implementation 2020-03-10 19:44:27 +01:00
f4exb 246ff824af Corrected network manager process memory leaks (Rx side) 2019-11-12 18:46:45 +01:00
f4exb a078239685 REST API: config: GET (11). Support of the rest of devices 2019-08-04 20:24:44 +02:00
f4exb 06dea9b29f PVS-Studio analys fixes: core package serious issues 2019-06-14 16:58:09 +02:00
f4exb b01c4e2477 Device API: added a number of source and sink streams and update it from the plugins 2019-05-21 00:27:08 +02:00
f4exb 89e53cf179 Single DeviceAPI interface (1) 2019-05-08 22:11:53 +02:00
f4exb 54e46837dd REST API: changed binary tx parameter to ternary direction parameter (0: rx, 1: tx, 2: any) 2019-05-07 14:43:38 +02:00
f4exb 4bb0f4f51a Fixed incomplete copyright headers (2): plugins/samplesource 2019-04-11 06:57:41 +02:00
f4exb e2ac286458 Series of shifted decimators matching shifted interpolators. Applied to HackRF input 2019-04-02 01:10:03 +02:00
f4exb cd35732807 Reverse API originator information: implemented for start/stop in all source plugins 2019-03-25 15:21:17 +01:00
f4exb 9b30d602c3 Reverse API originator information: implemented in all source plugins 2019-03-25 13:41:38 +01:00
f4exb 3e096580b0 REST API: implement reverse API settings (2) 2019-01-11 08:50:47 +01:00
f4exb 6e0be2d122 REST API: implement reverse API settings (1). Bump version 2019-01-10 22:35:38 +01:00
f4exb b0d12fbb23 Reverse API: Blade RF input changes 2018-12-25 21:05:24 +01:00
f4exb 7574cb23d4 Windows: MSVC2017: fixed more attribute unused cases (2) 2018-11-13 08:51:14 +01:00
f4exb 5b31982772 LibbladeRF2: migrate bladerfinput to bladerf1input (2) 2018-09-19 13:28:14 +02:00