Commit Graph
11 Commits
Author SHA1 Message Date
Jon BenistonandClaude Opus 5 60db861797 Fix QString leak in the web API settings and report formatters
The generated SWG setters overwrite the string pointer without deleting
what is already there, and every webapiSettingsGet and webapiReportGet
calls init() first, which has allocated one. Each call therefore leaked a
QString per string field. Measured at 117 bytes per settings GET for the
Satellite Tracker, over 20,000 requests.

Assign in place when the pointer is already set, which is what these same
functions have always done for title and reverseAPIAddress. 394 sites
across webapiFormatChannelSettings, webapiFormatDeviceSettings,
webapiFormatFeatureSettings and the three report equivalents.

The webapiReverseSend* functions are deliberately left alone: they build a
fresh SWG object whose constructor leaves the pointers null, so passing a
new QString is correct there.

After the change the same measurement is flat, at 7 bytes per GET.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-11 16:54:42 +01:00
f4exb 3596fe431a Rewriting of copyright notices for plugins/channelmimo. Part of #1893 2023-11-18 06:28:24 +01:00
f4exb 2a9cc27a41 Implement serialize and deserialize to/from API in Serializable interface. Related changes and fixes 2021-12-01 00:21:19 +01:00
f4exb f886f7d400 Scope GUI: refactor amp offset 2021-06-27 10:10:28 +02:00
f4exb 70167c0ed8 Scope GUI: refactor amp scale 2021-06-27 01:52:42 +02:00
f4exb d08844a34c GLScope redesign: using GLScopeSettings (1) 2021-06-12 10:18:18 +02:00
f4exb 70550f453f GLScope redesign (1) 2021-05-31 15:56:45 +02:00
f4exb 986b6f3711 Rename GLSpectrumSettings to SpectrumSettings 2021-04-20 23:12:05 +02:00
f4exb b5d501e6ab Spactrum: allow arbitrary FPS (API) or in a range of FPS (GUI) with possible no limit. Implements #772 2021-02-12 00:53:18 +01:00
f4exb 55eb6cc951 Fixed -Wunused-parameter warnings 2020-11-14 11:13:32 +01:00
f4exb 26c7821d68 Interferomter 2020-11-10 16:38:12 +01:00