Merge a708ffed79 into a31e83d43c

Found with:
ASAN_OPTIONS="detect_odr_violation=1,strip_path_prefix=$(pwd)/" build/sdrangel

Fixes:
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x7fabe9cf46b8 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:95
    #1 0x7faba9afa508 in WebServer::addSubstitution(QString, QString, QString) sdrangel/plugins/feature/skymap/webserver.cpp:83
    #2 0x7faba9b11591 in SkyMapGUI::SkyMapGUI(PluginAPI*, FeatureUISet*, Feature*, QWidget*) sdrangel/plugins/feature/skymap/skymapgui.cpp:224
    #3 0x7faba9b0f0a0 in SkyMapGUI::create(PluginAPI*, FeatureUISet*, Feature*) sdrangel/plugins/feature/skymap/skymapgui.cpp:44
    #4 0x7faba9af70e9 in SkyMapPlugin::createFeatureGUI(FeatureUISet*, Feature*) const sdrangel/plugins/feature/skymap/skymapplugin.cpp:72
    #5 0x7fabe920938b in MainWindow::featureAddClicked(Workspace*, int) sdrangel/sdrgui/mainwindow.cpp:2888
    #6 0x7fabe9224621 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0, 1>, QtPrivate::List<Workspace*, int>, void, void (MainWindow::*)(Workspace*, int)>::call(void (MainWindow::*)(Workspace*, int), MainWindow*, void**) /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:152
    #7 0x7fabe921feed in void QtPrivate::FunctionPointer<void (MainWindow::*)(Workspace*, int)>::call<QtPrivate::List<Workspace*, int>, void>(void (MainWindow::*)(Workspace*, int), MainWindow*, void**) /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:185
    #8 0x7fabe921d376 in QtPrivate::QSlotObject<void (MainWindow::*)(Workspace*, int), QtPrivate::List<Workspace*, int>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:418
    #9 0x7fabe43062b1  (/lib/x86_64-linux-gnu/libQt5Core.so.5+0x3062b1) (BuildId: ed2abb344a128279a866aa6c4a79f3fa5c87c59e)
    #10 0x7fabe91d5ca4 in Workspace::addFeature(Workspace*, int) build-sdrangel-Desktop_qt5-Debug/sdrgui/sdrgui_autogen/DMHXEJ42XS/moc_workspace.cpp:393
    #11 0x7fabe950c6a2 in Workspace::addFeatureEmitted(int) sdrangel/sdrgui/gui/workspace.cpp:413
    #12 0x7fabe95245bb in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<int>, void, void (Workspace::*)(int)>::call(void (Workspace::*)(int), Workspace*, void**) /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:152
    #13 0x7fabe951fb83 in void QtPrivate::FunctionPointer<void (Workspace::*)(int)>::call<QtPrivate::List<int>, void>(void (Workspace::*)(int), Workspace*, void**) /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:185
    #14 0x7fabe951cc86 in QtPrivate::QSlotObject<void (Workspace::*)(int), QtPrivate::List<int>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:418
    #15 0x7fabe43062b1  (/lib/x86_64-linux-gnu/libQt5Core.so.5+0x3062b1) (BuildId: ed2abb344a128279a866aa6c4a79f3fa5c87c59e)
    #16 0x7fabe91c3c77 in FeatureAddDialog::addFeature(int) build-sdrangel-Desktop_qt5-Debug/sdrgui/sdrgui_autogen/DMHXEJ42XS/moc_featureadddialog.cpp:141
    #17 0x7fabe92d0d79 in FeatureAddDialog::apply(QAbstractButton*) sdrangel/sdrgui/gui/featureadddialog.cpp:53
    #18 0x7fabe91c380e in FeatureAddDialog::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) build-sdrangel-Desktop_qt5-Debug/sdrgui/sdrgui_autogen/DMHXEJ42XS/moc_featureadddialog.cpp:82
    #19 0x7fabe4305fcc  (/lib/x86_64-linux-gnu/libQt5Core.so.5+0x305fcc) (BuildId: ed2abb344a128279a866aa6c4a79f3fa5c87c59e)
    #20 0x7fabe51029b2 in QDialogButtonBox::clicked(QAbstractButton*) (/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x3029b2) (BuildId: dfefd27f084c0dd066215fc79825fceae604f481)

and more

CMakeLists.txt

@@ -25,7 +25,8 @@ set(sdrangel_VERSION_SUFFIX "")
 
 # SDRAngel cmake options
 option(DEBUG_OUTPUT "Print debug messages" OFF)
-option(SANITIZE_ADDRESS "Activate memory address sanitization" OFF)
+option(SANITIZE_ADDRESS "Activate detection of uninitialized memory (AddressSanitizer)" OFF)
+option(SANITIZE_MEMORY "Activate detection of leaked memory (LeakSanitizer)" OFF)
 option(RX_SAMPLE_24BIT "Internal 24 bit Rx DSP" ON)
 option(BUILD_SERVER "Build Server" ON)
 option(BUILD_GUI "Build GUI" ON)

plugins/feature/afc/afcgui.cpp

@@ -103,6 +103,7 @@ bool AFCGUI::handleMessage(const Message& message)
     {
         const AFC::MsgDeviceSetListsReport& report = (AFC::MsgDeviceSetListsReport&) message;
         updateDeviceSetLists(report);
+        return true;
     }
 
 	return false;

plugins/feature/gs232controller/gs232controller.cpp

@@ -288,11 +288,10 @@ void GS232Controller::applySettings(const GS232ControllerSettings& settings, con
         m_selectedPipe = m_availableChannelOrFeatureHandler.registerPipes(settings.m_source, {"target"});
     }
 
-    GS232ControllerWorker::MsgConfigureGS232ControllerWorker *msg = GS232ControllerWorker::MsgConfigureGS232ControllerWorker::create(
-        settings, settingsKeys, force
-    );
-
     if (m_worker) {
+        GS232ControllerWorker::MsgConfigureGS232ControllerWorker *msg = GS232ControllerWorker::MsgConfigureGS232ControllerWorker::create(
+            settings, settingsKeys, force
+            );
         m_worker->getInputMessageQueue()->push(msg);
     }
 

plugins/feature/map/mapgui.cpp

@@ -28,6 +28,7 @@
 #include <QScreen>
 #include <QSvgWidget>
 #include <QTableWidgetItem>
+#include <QtAlgorithms>
 
 #ifdef QT_WEBENGINE_FOUND
 #include <QtWebEngineWidgets/QWebEngineView>
@@ -411,6 +412,16 @@ MapGUI::~MapGUI()
         delete m_webServer;
     }
     delete m_giro;
+    qDeleteAll(*m_beacons);
+    delete m_beacons;
+    qDeleteAll(*m_navAids);
+    qDeleteAll(*m_airspaces);
+    qDeleteAll(*m_airportInfo);
+    qDeleteAll(*m_waypoints);
+    m_objectMapModel.removeAll();
+    m_imageMapModel.removeAll();
+    m_polygonMapModel.removeAll();
+    m_polylineMapModel.removeAll();
     delete ui;
 }
 

plugins/feature/map/webserver.cpp

@@ -15,6 +15,7 @@
 // along with this program. If not, see <http://www.gnu.org/licenses/>.          //
 ///////////////////////////////////////////////////////////////////////////////////
 
+#include <QtAlgorithms>
 #include <QResource>
 #include <QFile>
 #include <QRegularExpression>
@@ -41,6 +42,12 @@ WebServer::WebServer(quint16 &port, QObject* parent) :
     m_mimeTypes.insert(".geojson", new MimeType("application/geo+json"));
 }
 
+WebServer::~WebServer()
+{
+    qDeleteAll(m_substitutions);
+    qDeleteAll(m_mimeTypes);
+}
+
 void WebServer::incomingConnection(qintptr socket)
 {
     QTcpSocket* s = new QTcpSocket(this);

plugins/feature/map/webserver.h

@@ -64,6 +64,7 @@ private:
 
 public:
     WebServer(quint16 &port, QObject* parent = 0);
+    ~WebServer();
     void incomingConnection(qintptr socket) override;
     void addPathSubstitution(const QString &from, const QString &to);
     void addSubstitution(QString path, QString from, QString to);

plugins/feature/pertester/pertester.cpp

@@ -189,10 +189,10 @@ void PERTester::applySettings(const PERTesterSettings& settings, const QList<QSt
 {
     qDebug() << "PERTester::applySettings:" << settings.getDebugString(settingsKeys, force) << " force: " << force;
 
-    PERTesterWorker::MsgConfigurePERTesterWorker *msg = PERTesterWorker::MsgConfigurePERTesterWorker::create(
-        settings, settingsKeys, force
-    );
     if (m_worker) {
+        PERTesterWorker::MsgConfigurePERTesterWorker *msg = PERTesterWorker::MsgConfigurePERTesterWorker::create(
+            settings, settingsKeys, force
+            );
         m_worker->getInputMessageQueue()->push(msg);
     }
 

plugins/feature/satellitetracker/satellitetracker.cpp

@@ -208,11 +208,10 @@ void SatelliteTracker::applySettings(const SatelliteTrackerSettings& settings, c
         tlesChanged = true;
     }
 
-    SatelliteTrackerWorker::MsgConfigureSatelliteTrackerWorker *msg = SatelliteTrackerWorker::MsgConfigureSatelliteTrackerWorker::create(
-        settings, settingsKeys, force
-    );
-
     if (m_worker) {
+        SatelliteTrackerWorker::MsgConfigureSatelliteTrackerWorker *msg = SatelliteTrackerWorker::MsgConfigureSatelliteTrackerWorker::create(
+            settings, settingsKeys, force
+        );
         m_worker->getInputMessageQueue()->push(msg);
     }
 

plugins/feature/skymap/webserver.cpp

@@ -41,6 +41,12 @@ WebServer::WebServer(quint16 &port, QObject* parent) :
     m_mimeTypes.insert(".geojson", new MimeType("application/geo+json"));
 }
 
+WebServer::~WebServer()
+{
+    qDeleteAll(m_substitutions);
+    qDeleteAll(m_mimeTypes);
+}
+
 void WebServer::incomingConnection(qintptr socket)
 {
     QTcpSocket* s = new QTcpSocket(this);

plugins/feature/skymap/webserver.h

@@ -64,6 +64,7 @@ private:
 
 public:
     WebServer(quint16 &port, QObject* parent = 0);
+    ~WebServer();
     void incomingConnection(qintptr socket) override;
     void addPathSubstitution(const QString &from, const QString &to);
     void addSubstitution(QString path, QString from, QString to);

plugins/feature/startracker/startracker.cpp

@@ -163,25 +163,25 @@ bool StarTracker::handleMessage(const Message& cmd)
     }
     else if (MsgSetSolarFlux::match(cmd))
     {
-        MsgSetSolarFlux& msg = (MsgSetSolarFlux&) cmd;
-        m_solarFlux = msg.getFlux();
         if (m_worker) {
+            MsgSetSolarFlux& msg = (MsgSetSolarFlux&) cmd;
+            m_solarFlux = msg.getFlux();
             m_worker->getInputMessageQueue()->push(new MsgSetSolarFlux(msg));
         }
         return true;
     }
     else if (MainCore::MsgStarTrackerDisplaySettings::match(cmd))
     {
-        MainCore::MsgStarTrackerDisplaySettings& settings = (MainCore::MsgStarTrackerDisplaySettings&) cmd;
         if (m_guiMessageQueue) {
+            MainCore::MsgStarTrackerDisplaySettings& settings = (MainCore::MsgStarTrackerDisplaySettings&) cmd;
             m_guiMessageQueue->push(new MainCore::MsgStarTrackerDisplaySettings(settings));
         }
         return true;
     }
     else if (MainCore::MsgStarTrackerDisplayLoSSettings::match(cmd))
     {
-        MainCore::MsgStarTrackerDisplayLoSSettings& settings = (MainCore::MsgStarTrackerDisplayLoSSettings&) cmd;
         if (m_guiMessageQueue) {
+            MainCore::MsgStarTrackerDisplayLoSSettings& settings = (MainCore::MsgStarTrackerDisplayLoSSettings&) cmd;
             m_guiMessageQueue->push(new MainCore::MsgStarTrackerDisplayLoSSettings(settings));
         }
         return true;
@@ -246,10 +246,10 @@ void StarTracker::applySettings(const StarTrackerSettings& settings, const QList
         }
     }
 
-    StarTrackerWorker::MsgConfigureStarTrackerWorker *msg = StarTrackerWorker::MsgConfigureStarTrackerWorker::create(
-        settings, settingsKeys, force
-    );
     if (m_worker) {
+        StarTrackerWorker::MsgConfigureStarTrackerWorker *msg = StarTrackerWorker::MsgConfigureStarTrackerWorker::create(
+            settings, settingsKeys, force
+            );
         m_worker->getInputMessageQueue()->push(msg);
     }
 

sdrbase/device/deviceuserargs.cpp

@@ -40,8 +40,8 @@ QByteArray DeviceUserArgs::serialize() const
 {
     SimpleSerializer s(1);
     QByteArray data;
-    QDataStream *stream = new QDataStream(&data, QIODevice::WriteOnly);
-    *stream << m_argsByDevice;
+    QDataStream stream(&data, QIODevice::WriteOnly);
+    stream << m_argsByDevice;
     s.writeBlob(1, data);
     return s.final();
 }

sdrbase/maincore.cpp

@@ -209,6 +209,7 @@ void MainCore::removeLastFeatureSet()
         FeatureSet *featureSet = m_featureSets.back();
         m_featureSetsMap.remove(featureSet);
         m_featureSets.pop_back();
+        delete featureSet;
     }
 }
 
@@ -227,6 +228,7 @@ void MainCore::removeLastDeviceSet()
         DeviceSet *deviceSet = m_deviceSets.back();
         m_deviceSetsMap.remove(deviceSet);
         m_deviceSets.pop_back();
+        delete deviceSet;
     }
 }
 

sdrbase/settings/mainsettings.cpp

@@ -21,6 +21,7 @@
 
 #include <algorithm>
 
+#include "qalgorithms.h"
 #include "settings/mainsettings.h"
 #include "commands/command.h"
 #include "audio/audiodevicemanager.h"
@@ -34,24 +35,11 @@ MainSettings::MainSettings() :
 
 MainSettings::~MainSettings()
 {
-	for (int i = 0; i < m_presets.count(); ++i)
-	{
-		delete m_presets[i];
-	}
-
-	for (int i = 0; i < m_commands.count(); ++i)
-    {
-        delete m_commands[i];
-    }
-
-	for (int i = 0; i < m_featureSetPresets.count(); ++i)
-    {
-        delete m_featureSetPresets[i];
-    }
-    for (int i = 0; i < m_pluginPresets.count(); ++i)
-    {
-        delete m_pluginPresets[i];
-    }
+    qDeleteAll(m_presets);
+    qDeleteAll(m_commands);
+    qDeleteAll(m_featureSetPresets);
+    qDeleteAll(m_pluginPresets);
+    qDeleteAll(m_configurations);
 }
 
 QString MainSettings::getFileLocation() const

sdrbase/util/airlines.cpp

@@ -5560,3 +5560,8 @@ Airline::Init::Init()
         s += 4;
     }
 }
+
+Airline::Init::~Init()
+{
+    qDeleteAll(m_icaoHash);
+}

sdrbase/util/airlines.h

@@ -55,6 +55,7 @@ private:
     friend struct Init;
     struct Init {
         Init();
+        ~Init();
         static const char *m_airlines[];
     };
     static Init m_init;

sdrbase/util/ais.cpp

@@ -502,7 +502,7 @@ AISSafetyMessage::AISSafetyMessage(QByteArray ba) :
     m_sequenceNumber = ba[4] & 0x3;
     m_destinationId = ((ba[5] & 0xff) << 22) | ((ba[6] & 0xff) << 14) | ((ba[7] & 0xff) << 6) | ((ba[8] >> 2) & 0x3f);
     m_retransmitFlag = (ba[8] >> 1) & 0x1;
-    m_safetyRelatedText = AISMessage::getString(ba, 9, 0, (ba.size() - 9) * 8 / 6);
+    m_safetyRelatedText = AISMessage::getString(ba, 9, 8, (ba.size() - 9) * 8 / 6);
 }
 
 QString AISSafetyMessage::toString()
@@ -518,7 +518,7 @@ AISSafetyAck::AISSafetyAck(QByteArray ba) :
 AISSafetyBroadcast::AISSafetyBroadcast(QByteArray ba) :
     AISMessage(ba)
 {
-    m_safetyRelatedText = AISMessage::getString(ba, 5, 0, (ba.size() - 6) * 8 / 6);
+    m_safetyRelatedText = AISMessage::getString(ba, 5, 8, (ba.size() - 5) * 8 / 6);
 }
 
 QString AISSafetyBroadcast::toString()

sdrgui/gui/glshaderspectrogram.cpp

@@ -514,6 +514,8 @@ void GLShaderSpectrogram::drawSurface(SpectrumSettings::SpectrogramStyle style,
 
 void GLShaderSpectrogram::cleanup()
 {
+    delete m_vao;
+    m_vao = nullptr;
     delete m_programShaded;
     m_programShaded = nullptr;
     delete m_programSimple;

sdrgui/gui/valuedial.cpp

@@ -601,7 +601,7 @@ void ValueDial::keyPressEvent(QKeyEvent *value)
         emit changed(m_valueNew);
         m_cursor++;
 
-        if (m_text[m_cursor] == m_groupSeparator) {
+        if ((m_cursor >= 0) && (m_cursor < m_text.size()) && (m_text[m_cursor] == m_groupSeparator)) {
             m_cursor++;
         }