Merge 39a24510fa into 217c900609

Found with:
ASAN_OPTIONS="detect_odr_violation=1,strip_path_prefix=$(pwd)/" build/sdrangel

Fixes:
Direct leak of 176096 byte(s) in 5503 object(s) allocated from:
    #0 0x7f3a464f46c8 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:95
    #1 0x7f3a44009219 in Airline::Init::Init() sdrbase/util/airlines.cpp:5559
    #2 0x7f3a43dc797d in _sub_I_65535_0.0 (build/lib/libsdrbase.so+0x3c797d) (BuildId: fb568b705538a6e506ee23027626f4366b25aa50)
    #3 0x7f3a46c6ce3d in call_init elf/dl-init.c:74
    #4 0x7f3a46c6ce3d in call_init elf/dl-init.c:26

Indirect leak of 989274 byte(s) in 22012 object(s) allocated from:
    #0 0x7f3a464f3bd7 in malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7f3a410e63f1 in QArrayData::allocate(unsigned long, unsigned long, unsigned long, QFlags<QArrayData::AllocationOption>) (/lib/x86_64-linux-gnu/libQt5Core.so.5+0xe63f1) (BuildId: eaf989d675ab5f0e8e9033fa527c9ed018f70370)

CMakeLists.txt

@@ -25,7 +25,8 @@ set(sdrangel_VERSION_SUFFIX "")
 
 # SDRAngel cmake options
 option(DEBUG_OUTPUT "Print debug messages" OFF)
-option(SANITIZE_ADDRESS "Activate memory address sanitization" OFF)
+option(SANITIZE_ADDRESS "Activate detection of uninitialized memory (AddressSanitizer)" OFF)
+option(SANITIZE_MEMORY "Activate detection of leaked memory (LeakSanitizer)" OFF)
 option(RX_SAMPLE_24BIT "Internal 24 bit Rx DSP" ON)
 option(BUILD_SERVER "Build Server" ON)
 option(BUILD_GUI "Build GUI" ON)

sdrbase/device/deviceuserargs.cpp

@@ -40,8 +40,8 @@ QByteArray DeviceUserArgs::serialize() const
 {
     SimpleSerializer s(1);
     QByteArray data;
-    QDataStream *stream = new QDataStream(&data, QIODevice::WriteOnly);
-    *stream << m_argsByDevice;
+    QDataStream stream(&data, QIODevice::WriteOnly);
+    stream << m_argsByDevice;
     s.writeBlob(1, data);
     return s.final();
 }

sdrbase/maincore.cpp

@@ -209,6 +209,7 @@ void MainCore::removeLastFeatureSet()
         FeatureSet *featureSet = m_featureSets.back();
         m_featureSetsMap.remove(featureSet);
         m_featureSets.pop_back();
+        delete featureSet;
     }
 }
 
@@ -227,6 +228,7 @@ void MainCore::removeLastDeviceSet()
         DeviceSet *deviceSet = m_deviceSets.back();
         m_deviceSetsMap.remove(deviceSet);
         m_deviceSets.pop_back();
+        delete deviceSet;
     }
 }
 

sdrbase/settings/mainsettings.cpp

@@ -52,6 +52,11 @@ MainSettings::~MainSettings()
     {
         delete m_pluginPresets[i];
     }
+
+    for (int i = 0; i < m_configurations.count(); ++i)
+    {
+        delete m_configurations[i];
+    }
 }
 
 QString MainSettings::getFileLocation() const

sdrbase/util/airlines.cpp

@@ -5560,3 +5560,10 @@ Airline::Init::Init()
         s += 4;
     }
 }
+
+Airline::Init::~Init()
+{
+    foreach(const QString s, m_icaoHash.keys()) {
+        delete m_icaoHash[s];
+    }
+}

sdrbase/util/airlines.h

@@ -55,6 +55,7 @@ private:
     friend struct Init;
     struct Init {
         Init();
+        ~Init();
         static const char *m_airlines[];
     };
     static Init m_init;

sdrgui/gui/glshaderspectrogram.cpp

@@ -514,6 +514,8 @@ void GLShaderSpectrogram::drawSurface(SpectrumSettings::SpectrogramStyle style,
 
 void GLShaderSpectrogram::cleanup()
 {
+    delete m_vao;
+    m_vao  = nullptr;
     delete m_programShaded;
     m_programShaded = nullptr;
     delete m_programSimple;