VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-08-06 10:56:34 -04:00
Code Issues Projects Releases Wiki Activity
Files
bdf0fa0202e7285deaf373669d89c7dbb4ef5013
sdrangel/sdrgui/gui/valuedialz.cpp
T
Robin Getz bdf0fa0202 valuedialz: Fix signed/unsigned conversion when editing negative values 
Fix a signed/unsigned arithmetic issue in ValueDialZ::keyPressEvent()
reported by cppcheck.

The digit editing code used quint64 intermediates together with a signed
sign value:

    int sign = m_value < 0 ? -1 : 1;
    setValue(sign * v);

When editing negative values, the signed -1 was converted to an unsigned
value before multiplication, causing the result to wrap instead of
producing a negative value.

Use qint64 intermediates for the digit manipulation and apply the existing
sign explicitly when updating the value. This preserves correct behavior
when editing negative values and avoids the unintended unsigned conversion.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-08-01 18:05:44 -04:00

723 lines
21 KiB
C++
Raw Blame History

///////////////////////////////////////////////////////////////////////////////////
// Copyright (C) 2017-2022 Edouard Griffiths, F4EXB <f4exb06@gmail.com> //
// Copyright (C) 2018 fire <fire@80211.at> //
// Copyright (C) 2020 Vort <vvort@yandex.ru> //
// Copyright (C) 2021-2023 Jon Beniston, M7RCE <jon@beniston.com> //
// Copyright (C) 2022 Jiří Pinkava <jiri.pinkava@rossum.ai> //
// //
// Same as ValueDial but handles optionally positive and negative numbers with //
// sign display. //
// //
// This program is free software; you can redistribute it and/or modify //
// it under the terms of the GNU General Public License as published by //
// the Free Software Foundation as version 3 of the License, or //
// (at your option) any later version. //
// //
// This program is distributed in the hope that it will be useful, //
// but WITHOUT ANY WARRANTY; without even the implied warranty of //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
// GNU General Public License V3 for more details. //
// //
// You should have received a copy of the GNU General Public License //
// along with this program. If not, see <http://www.gnu.org/licenses/>. //
///////////////////////////////////////////////////////////////////////////////////
#include <QPainter>
#include <QMouseEvent>
#include <QWheelEvent>
#include <QKeyEvent>
#include <QLocale>
#include <QApplication>
#include <QAccessibleValueChangeEvent>
#include "gui/valuedialz.h"
ValueDialZ::ValueDialZ(bool positiveOnly, QWidget* parent, ColorMapper colorMapper) :
QWidget(parent),
m_positiveOnly(positiveOnly),
m_decimalPos(0),
m_animationState(0),
m_colorMapper(colorMapper)
{
setAutoFillBackground(false);
setAttribute(Qt::WA_OpaquePaintEvent, true);
setAttribute(Qt::WA_NoSystemBackground, true);
setAttribute(Qt::WA_InputMethodEnabled, true);
setMouseTracking(true);
setFocusPolicy(Qt::StrongFocus);
setInputMethodHints(Qt::ImhFormattedNumbersOnly);
m_background.setStart(0, 0);
m_background.setFinalStop(0, 1);
m_background.setCoordinateMode(QGradient::ObjectBoundingMode);
ColorMapper::colormap::const_iterator cmit = m_colorMapper.getDialBackgroundColorMap().begin();
ColorMapper::colormap::const_iterator cmitEnd = m_colorMapper.getDialBackgroundColorMap().end();
for (; cmit != cmitEnd; ++ cmit) {
m_background.setColorAt(cmit->first, cmit->second);
}
m_value = 0;
m_valueNew = 0;
m_valueMin = m_positiveOnly ? 0 : -2200000;
m_valueMax = 2200000;
m_numDigits = 7;
m_numThousandPoints = m_numDigits / 3;
m_cursor = -1;
m_digitWidth = 0;
m_digitHeight = 0;
m_hightlightedDigit = -1;
m_text = formatText(m_value);
m_cursorState = false;
const QLocale & cLocale = QLocale::c();
m_groupSeparator = cLocale.groupSeparator();
m_decSeparator = cLocale.decimalPoint();
connect(&m_animationTimer, SIGNAL(timeout()), this, SLOT(animate()));
connect(&m_blinkTimer, SIGNAL(timeout()), this, SLOT(blink()));
}
void ValueDialZ::setFont(const QFont& font)
{
QWidget::setFont(font);
QFontMetrics fm(font);
m_digitWidth = fm.horizontalAdvance('0');
m_digitHeight = fm.ascent();
if(m_digitWidth < m_digitHeight)
m_digitWidth = m_digitHeight;
setFixedWidth((m_numDigits + m_numThousandPoints + (m_positiveOnly ? 0 : 1)) * m_digitWidth + 2);
setFixedHeight(m_digitHeight * 2 + 2);
}
void ValueDialZ::setBold(bool bold)
{
QFont f = font();
f.setBold(bold);
setFont(f);
}
void ValueDialZ::setColorMapper(ColorMapper colorMapper)
{
m_colorMapper = colorMapper;
ColorMapper::colormap::const_iterator cmit = m_colorMapper.getDialBackgroundColorMap().begin();
ColorMapper::colormap::const_iterator cmitEnd = m_colorMapper.getDialBackgroundColorMap().end();
for (; cmit != cmitEnd; ++ cmit) {
m_background.setColorAt(cmit->first, cmit->second);
}
}
void ValueDialZ::setValue(qint64 value)
{
m_valueNew = value;
if(m_valueNew < m_valueMin) {
m_valueNew = m_valueMin;
}
else if(m_valueNew > m_valueMax) {
m_valueNew = m_valueMax;
}
QAccessibleValueChangeEvent event(this, m_valueNew);
QAccessible::updateAccessibility(&event);
if(m_valueNew < m_value) {
m_animationState = 1;
} else if(m_valueNew > m_value) {
m_animationState = -1;
} else {
return;
}
m_animationTimer.start(20);
m_textNew = formatText(m_valueNew);
emit changed(m_valueNew);
}
void ValueDialZ::setValueRange(bool positiveOnly, uint numDigits, qint64 min, qint64 max, int decimalPos)
{
m_positiveOnly = positiveOnly;
m_decimalPos = decimalPos < 0 ? 0 : decimalPos > (int) numDigits ? numDigits : decimalPos;
m_numDigits = numDigits;
m_numThousandPoints = m_numDigits < 3 ? 0 : (m_numDigits%3) == 0 ? (m_numDigits/3)-1 : m_numDigits/3;
setFixedWidth((m_numDigits + m_numThousandPoints + (m_positiveOnly ? 0 : 1)) * m_digitWidth + 2);
m_valueMin = positiveOnly ? (min < 0 ? 0 : min) : min;
m_valueMax = positiveOnly ? (max < 0 ? 0 : max) : max;
if (m_valueNew < m_valueMin)
{
setValue(m_valueMin);
}
else if (m_valueNew > m_valueMax)
{
setValue(m_valueMax);
}
else if ((m_value == 0) && (m_valueNew == 0))
{
m_text = formatText(0);
m_textNew = m_text;
update();
}
}
quint64 ValueDialZ::findExponent(int digit)
{
// digit and separators index from left to right
quint64 e = 1;
int s = (m_decimalPos % 3);
s = (3-s) % 3;
// digit and separators index from right to left starting at 1
int d = (m_numDigits + m_numThousandPoints + (m_positiveOnly ? 0 : 1)) - digit;
for (int i = s+1; i < d+s; i++)
{
// if ((i%4 == 0) || (m_positiveOnly && (i == d+s-1))) { // non digit positions
if (i%4 == 0) {
continue;
}
e *= 10;
}
// d = d - (d / 4) - 1;
// for (int i = 0; i < d; i++) {
// e *= 10;
// }
return e;
}
QChar ValueDialZ::digitNeigh(QChar c, bool dir)
{
if (c == QChar('+')) {
return QChar('-');
} else if (c == QChar('-')) {
return QChar('+');
}
if(dir)
{
if(c == QChar('0')) {
return QChar('9');
} else {
return QChar::fromLatin1(c.toLatin1() - 1);
}
}
else
{
if(c == QChar('9')) {
return QChar('0');
} else {
return QChar::fromLatin1(c.toLatin1() + 1);
}
}
}
QString ValueDialZ::formatText(qint64 value)
{
QString str = QString("%1%2").arg(m_positiveOnly ? "" : value < 0 ? "-" : "+").arg(value < 0 ? -value : value, m_numDigits, 10, QChar('0'));
int s = (m_decimalPos % 3);
s = (3-s) % 3;
int iDec = (m_decimalPos - 1) / 3;
for (int i = 0; i < m_numThousandPoints; i++)
{
int ipoint = m_numDigits + (m_positiveOnly ? 0 : 1) - 3 + s - 3 * i;
if (ipoint != 0) // do not insert leading point
{
if ((m_decimalPos != 0) && (i == iDec)) {
str.insert(ipoint, m_decSeparator);
} else {
str.insert(ipoint, m_groupSeparator);
}
}
}
return str;
}
void ValueDialZ::paintEvent(QPaintEvent*)
{
QPainter painter(this);
painter.setPen(Qt::black);
painter.setBrush(m_background);
painter.drawRect(0, 0, width() - 1, height() - 1);
painter.setPen(m_colorMapper.getBoundaryColor());
painter.setBrush(Qt::NoBrush);
for (int i = 1; i < 1 + m_numDigits + m_numThousandPoints; i++)
{
painter.setPen(m_colorMapper.getBoundaryColor());
painter.drawLine(1 + i * m_digitWidth, 1, 1 + i * m_digitWidth, height() - 1);
painter.setPen(m_colorMapper.getBoundaryAlphaColor());
painter.drawLine(0 + i * m_digitWidth, 1, 0 + i * m_digitWidth, height() - 1);
painter.drawLine(2 + i * m_digitWidth, 1, 2 + i * m_digitWidth, height() - 1);
}
painter.setPen(m_colorMapper.getBoundaryAlphaColor());
painter.drawLine(1, 1, 1, height() - 1);
painter.drawLine(width() - 2, 1, width() - 2, height() - 1);
// dial borders
painter.setPen(m_colorMapper.getDarkBorderColor());
painter.drawLine(0, 0, width() - 2, 0);
painter.drawLine(0, height() - 1, 0, 0);
painter.setPen(m_colorMapper.getLightBorderColor());
painter.drawLine(1, height() - 1, width() - 1, height() - 1);
painter.drawLine(width() - 1, height() - 1, width() - 1, 0);
if (m_hightlightedDigit >= 0)
{
painter.setPen(Qt::NoPen);
painter.setBrush(m_colorMapper.getHighlightColor());
painter.drawRect(2 + m_hightlightedDigit * m_digitWidth, 1, m_digitWidth - 1, height() - 1);
}
QColor secondaryForegroundColor = m_colorMapper.getSecondaryForegroundColor();
if (!isEnabled()) {
secondaryForegroundColor = secondaryForegroundColor.darker();
}
if (m_animationState == 0)
{
for (int i = 0; i < m_text.length(); i++)
{
painter.setClipRect(1 + i * m_digitWidth, 1, m_digitWidth, m_digitHeight * 2);
painter.setPen(secondaryForegroundColor);
painter.drawText(QRect(1 + i * m_digitWidth, m_digitHeight * 0.6, m_digitWidth, m_digitHeight), Qt::AlignCenter, m_text.mid(i, 1));
if ((m_text[i] != m_groupSeparator) && (m_text[i] != m_decSeparator))
{
painter.setPen(m_colorMapper.getForegroundColor());
painter.drawText(QRect(1 + i * m_digitWidth, m_digitHeight * -0.7, m_digitWidth, m_digitHeight), Qt::AlignCenter, digitNeigh(m_text[i], true));
painter.drawText(QRect(1 + i * m_digitWidth, m_digitHeight * 1.9, m_digitWidth, m_digitHeight), Qt::AlignCenter, digitNeigh(m_text[i], false));
}
}
painter.setClipping(false);
if ((m_cursor >= 0) && (m_cursorState))
{
painter.setPen(Qt::NoPen);
painter.setBrush(secondaryForegroundColor);
painter.drawRect(4 + m_cursor * m_digitWidth, 1 + m_digitHeight * 1.5, m_digitWidth - 5, m_digitHeight / 6);
}
}
else
{
for(int i = 0; i < m_text.length(); i++)
{
if (m_text[i] == m_textNew[i])
{
painter.setClipRect(1 + i * m_digitWidth, 1, m_digitWidth, m_digitHeight * 2);
painter.setPen(secondaryForegroundColor);
painter.drawText(QRect(1 + i * m_digitWidth, m_digitHeight * 0.6, m_digitWidth, m_digitHeight), Qt::AlignCenter, m_text.mid(i, 1));
if ((m_text[i] != m_groupSeparator) && (m_text[i] != m_decSeparator))
{
painter.setPen(m_colorMapper.getForegroundColor());
painter.drawText(QRect(1 + i * m_digitWidth, m_digitHeight * -0.7, m_digitWidth, m_digitHeight), Qt::AlignCenter, digitNeigh(m_text[i], true));
painter.drawText(QRect(1 + i * m_digitWidth, m_digitHeight * 1.9, m_digitWidth, m_digitHeight), Qt::AlignCenter, digitNeigh(m_text[i], false));
}
}
else
{
int h = m_digitHeight * 0.6 + m_digitHeight * m_animationState / 2.0;
painter.setClipRect(1 + i * m_digitWidth, 1, m_digitWidth, m_digitHeight * 2);
painter.setPen(secondaryForegroundColor);
painter.drawText(QRect(1 + i * m_digitWidth, h, m_digitWidth, m_digitHeight), Qt::AlignCenter, m_text.mid(i, 1));
if ((m_text[i] != m_groupSeparator) && (m_text[i] != m_decSeparator))
{
painter.setPen(m_colorMapper.getForegroundColor());
painter.drawText(QRect(1 + i * m_digitWidth, h + m_digitHeight * -0.7, m_digitWidth, m_digitHeight), Qt::AlignCenter, digitNeigh(m_text[i], true));
painter.drawText(QRect(1 + i * m_digitWidth, h + m_digitHeight * 1.9, m_digitWidth, m_digitHeight), Qt::AlignCenter, digitNeigh(m_text[i], false));
}
}
}
}
}
void ValueDialZ::mousePressEvent(QMouseEvent* event)
{
int i;
i = (event->x() - 1) / m_digitWidth;
if (m_positiveOnly)
if ((m_text[i] == m_groupSeparator) || (m_text[i] == m_decSeparator) || (m_text[i] == QChar('+')) || (m_text[i] == QChar('-')))
{
i++;
if (i > m_numDigits + m_numThousandPoints + (m_positiveOnly ? 0 : 1))
{
return;
}
}
Qt::MouseButton mouseButton = event->button();
if (mouseButton == Qt::RightButton) // ceil value at current digit
{
if(m_cursor >= 0)
{
m_cursor = -1;
m_blinkTimer.stop();
update();
}
qint64 e = findExponent(i);
m_valueNew = (m_value / e) * e;
setValue(m_valueNew);
//qDebug("ValueDial::mousePressEvent: Qt::RightButton: i: %d e: %ll new: %ll", i, e, valueNew);
}
else if (mouseButton == Qt::LeftButton) // set cursor at current digit
{
if (qApp->autoSipEnabled())
{
QGuiApplication::inputMethod()->show();
}
m_cursor = i;
m_cursorState = true;
m_blinkTimer.start(400);
update();
}
}
void ValueDialZ::mouseMoveEvent(QMouseEvent* event)
{
int i;
i = (event->x() - 1) / m_digitWidth;
if ((i >= m_text.size()) || (m_text[i] == m_groupSeparator) || (m_text[i] == m_decSeparator)) {
i = -1;
}
if (i != m_hightlightedDigit)
{
m_hightlightedDigit = i;
update();
}
}
void ValueDialZ::wheelEvent(QWheelEvent* event)
{
int i;
i = (event->position().x() - 1) / m_digitWidth;
if ((m_text[i] != m_groupSeparator) && (m_text[i] != m_decSeparator)) {
m_hightlightedDigit = i;
} else {
return;
}
if (m_cursor >= 0)
{
m_cursor = -1;
m_blinkTimer.stop();
update();
}
if(m_animationState == 0)
{
if (!m_positiveOnly && (m_hightlightedDigit == 0))
{
m_valueNew = (-m_value < m_valueMin) ? m_valueMin : (-m_value > m_valueMax) ? m_valueMax : -m_value;
}
else
{
qint64 e = findExponent(m_hightlightedDigit);
if(event->angleDelta().y() < 0)
{
if (event->modifiers() & Qt::ShiftModifier) {
e *= 5;
} else if (event->modifiers() & Qt::ControlModifier) {
e *= 2;
}
m_valueNew = (m_value - e < m_valueMin) ? m_valueMin : m_value - e;
}
else
{
if (event->modifiers() & Qt::ShiftModifier) {
e *= 5;
} else if (event->modifiers() & Qt::ControlModifier) {
e *= 2;
}
m_valueNew = (m_value + e > m_valueMax) ? m_valueMax : m_value + e;
}
}
setValue(m_valueNew);
event->accept();
}
}
void ValueDialZ::leaveEvent(QEvent*)
{
if(m_hightlightedDigit != -1) {
m_hightlightedDigit = -1;
update();
}
}
void ValueDialZ::inputMethodEvent(QInputMethodEvent* event)
{
// Android numeric virtual keyboard sends inputMethodEvents rather than keyPressEvent for . and -.
// No + on keyboard, so use either to flip sign
if ((event->commitString() == ".") || (event->commitString() == "-"))
{
setValue(-m_value);
update();
}
}
void ValueDialZ::keyPressEvent(QKeyEvent* value)
{
if(m_cursor >= 0)
{
if((value->key() == Qt::Key_Return) || (value->key() == Qt::Key_Enter) || (value->key() == Qt::Key_Escape))
{
m_cursor = -1;
m_cursorState = false;
m_blinkTimer.stop();
update();
return;
}
}
if((m_cursor < 0) && (m_hightlightedDigit >= 0))
{
m_cursor = m_hightlightedDigit;
if ((m_text[m_cursor] == m_groupSeparator) || (m_text[m_cursor] == m_decSeparator)) {
m_cursor++;
}
if(m_cursor >= m_numDigits + m_numThousandPoints + (m_positiveOnly ? 0 : 1)) {
return;
}
m_cursorState = true;
m_blinkTimer.start(400);
update();
}
if(m_cursor < 0) {
return;
}
if ((value->key() == Qt::Key_Left) || (value->key() == Qt::Key_Backspace))
{
if(m_cursor > 0)
{
m_cursor--;
if ((m_text[m_cursor] == m_groupSeparator) || (m_text[m_cursor] == m_decSeparator)) {
m_cursor--;
}
if (m_cursor < 0) {
m_cursor++;
}
m_cursorState = true;
update();
return;
}
}
else if(value->key() == Qt::Key_Right)
{
if(m_cursor < m_numThousandPoints + m_numDigits)
{
m_cursor++;
if ((m_text[m_cursor] == m_groupSeparator) || (m_text[m_cursor] == m_decSeparator)) {
m_cursor++;
}
if(m_cursor >= m_numThousandPoints + m_numDigits + (m_positiveOnly ? 0 : 1)) {
m_cursor--;
}
m_cursorState = true;
update();
return;
}
}
else if(value->key() == Qt::Key_Up)
{
if (!m_positiveOnly && (m_cursor == 0))
{
if(m_animationState != 0) {
m_value = m_valueNew;
}
m_valueNew = (-m_value < m_valueMin) ? m_valueMin : (-m_value > m_valueMax) ? m_valueMax : -m_value;
}
else
{
qint64 e = findExponent(m_cursor);
if (value->modifiers() & Qt::ShiftModifier) {
e *= 5;
} else if (value->modifiers() & Qt::ControlModifier) {
e *= 2;
}
if(m_animationState != 0) {
m_value = m_valueNew;
}
m_valueNew = m_value + e > m_valueMax ? m_valueMax : m_value + e;
}
setValue(m_valueNew);
}
else if(value->key() == Qt::Key_Down)
{
if (!m_positiveOnly && (m_cursor == 0))
{
if(m_animationState != 0) {
m_value = m_valueNew;
}
m_valueNew = (-m_value < m_valueMin) ? m_valueMin : (-m_value > m_valueMax) ? m_valueMax : -m_value;
}
else
{
qint64 e = findExponent(m_cursor);
if (value->modifiers() & Qt::ShiftModifier) {
e *= 5;
} else if (value->modifiers() & Qt::ControlModifier) {
e *= 2;
}
if(m_animationState != 0) {
m_value = m_valueNew;
}
m_valueNew = m_value - e < m_valueMin ? m_valueMin : m_value - e;
}
setValue(m_valueNew);
}
if(value->text().length() != 1) {
return;
}
QChar c = value->text()[0];
if ((c == QChar('+')) && (m_cursor == 0) && (m_text[m_cursor] == QChar('-'))) // change sign to positive
{
setValue(-m_value);
update();
}
else if ((c == QChar('-')) && (m_cursor == 0) && (m_text[m_cursor] == QChar('+'))) // change sign to negative
{
setValue(-m_value);
update();
}
else if ((c >= QChar('0')) && (c <= QChar('9')) && (m_cursor >= (m_positiveOnly ? 0 : 1))) // digits
{
if(m_animationState != 0) {
m_value = m_valueNew;
}
int d = c.toLatin1() - '0';
qint64 e = static_cast<qint64>(findExponent(m_cursor));
qint64 value = qAbs(m_value);
qint64 v = (value / e) % 10;
v = value - v * e;
v += d * e;
setValue(m_value < 0 ? -v : v);
m_cursor++;
if ((m_text[m_cursor] == m_groupSeparator) || (m_text[m_cursor] == m_decSeparator)) {
m_cursor++;
}
if(m_cursor >= m_numDigits + m_numThousandPoints + (m_positiveOnly ? 0 : 1))
{
m_cursor = -1;
m_blinkTimer.stop();
}
else
{
m_cursorState = true;
}
update();
}
}
void ValueDialZ::focusInEvent(QFocusEvent*)
{
if(m_cursor == -1) {
m_cursor = 0;
m_cursorState = true;
m_blinkTimer.start(400);
update();
}
}
void ValueDialZ::focusOutEvent(QFocusEvent*)
{
m_cursor = -1;
m_blinkTimer.stop();
update();
}
void ValueDialZ::animate()
{
update();
if(m_animationState > 0)
m_animationState++;
else if(m_animationState < 0)
m_animationState--;
else {
m_animationTimer.stop();
m_animationState = 0;
return;
}
if(abs(m_animationState) >= 4) {
m_animationState = 0;
m_animationTimer.stop();
m_value = m_valueNew;
m_text = m_textNew;
}
}
void ValueDialZ::blink()
{
if(m_cursor >= 0) {
m_cursorState = !m_cursorState;
update();
}
}
Reference in New Issue View Git Blame Copy Permalink