mirror of
https://github.com/f4exb/sdrangel.git
synced 2026-10-12 02:03:11 -04:00
MessageQueue::pop() transfers ownership of the popped message to the caller, but many handleInputMessages() implementations only deleted the message when handleMessage() returned true. When a message was not handled, ownership had already been transferred from the queue and the message was leaked. This was identified while investigating an ASAN leak in the audio subsystem. Update the applicable handleInputMessages() implementations to always delete messages after handleMessage() returns. Unhandled messages are also logged with the component and message identifier so unexpected message routing is visible during debugging. This change: - Ensures every message popped from a queue has its ownership resolved. - Prevents leaks when handleMessage() returns false. - Makes unhandled messages visible instead of silently discarding them. - Preserves the existing message handling logic and does not require components to handle message types that are legitimately irrelevant to them. The changes are intentionally mechanical and limited to the common message queue ownership and diagnostic pattern. Signed-off-by: Robin Getz <rgetz503@gmail.com>
466 lines
15 KiB
C++
466 lines
15 KiB
C++
///////////////////////////////////////////////////////////////////////////////////
|
|
// Copyright (C) 2015-2020, 2022 Edouard Griffiths, F4EXB <f4exb06@gmail.com> //
|
|
// Copyright (C) 2022-2023 Jon Beniston, M7RCE <jon@beniston.com> //
|
|
// //
|
|
// This program is free software; you can redistribute it and/or modify //
|
|
// it under the terms of the GNU General Public License as published by //
|
|
// the Free Software Foundation as version 3 of the License, or //
|
|
// (at your option) any later version. //
|
|
// //
|
|
// This program is distributed in the hope that it will be useful, //
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of //
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
|
|
// GNU General Public License V3 for more details. //
|
|
// //
|
|
// You should have received a copy of the GNU General Public License //
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>. //
|
|
///////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include <QDebug>
|
|
#include <QMessageBox>
|
|
#include <QFileDialog>
|
|
|
|
#include "device/deviceapi.h"
|
|
#include "device/deviceuiset.h"
|
|
|
|
#include "ui_perseusgui.h"
|
|
#include "gui/colormapper.h"
|
|
#include "gui/glspectrum.h"
|
|
#include "gui/basicdevicesettingsdialog.h"
|
|
#include "gui/dialogpositioner.h"
|
|
#include "mainspectrum/mainspectrumgui.h"
|
|
#include "dsp/dspcommands.h"
|
|
#include "perseusgui.h"
|
|
|
|
PerseusGui::PerseusGui(DeviceUISet *deviceUISet, QWidget* parent) :
|
|
DeviceGUI(parent),
|
|
ui(new Ui::PerseusGui),
|
|
m_doApplySettings(true),
|
|
m_forceSettings(true),
|
|
m_settings(),
|
|
m_sampleSource(0),
|
|
m_lastEngineState(DeviceAPI::StNotStarted)
|
|
{
|
|
m_deviceUISet = deviceUISet;
|
|
setAttribute(Qt::WA_DeleteOnClose, true);
|
|
m_sampleSource = (PerseusInput*) m_deviceUISet->m_deviceAPI->getSampleSource();
|
|
|
|
ui->setupUi(getContents());
|
|
sizeToContents();
|
|
getContents()->setStyleSheet("#PerseusGui { background-color: rgb(64, 64, 64); }");
|
|
m_helpURL = "plugins/samplesource/perseus/readme.md";
|
|
ui->centerFrequency->setColorMapper(ColorMapper(ColorMapper::GrayGold));
|
|
updateFrequencyLimits();
|
|
|
|
connect(&m_updateTimer, SIGNAL(timeout()), this, SLOT(updateHardware()));
|
|
connect(&m_statusTimer, SIGNAL(timeout()), this, SLOT(updateStatus()));
|
|
m_statusTimer.start(500);
|
|
|
|
connect(this, SIGNAL(customContextMenuRequested(const QPoint &)), this, SLOT(openDeviceSettingsDialog(const QPoint &)));
|
|
|
|
displaySettings();
|
|
|
|
m_rates = m_sampleSource->getSampleRates();
|
|
displaySampleRates();
|
|
connect(&m_inputMessageQueue, SIGNAL(messageEnqueued()), this, SLOT(handleInputMessages()), Qt::QueuedConnection);
|
|
m_sampleSource->setMessageQueueToGUI(&m_inputMessageQueue);
|
|
|
|
sendSettings();
|
|
makeUIConnections();
|
|
m_resizer.enableChildMouseTracking();
|
|
}
|
|
|
|
PerseusGui::~PerseusGui()
|
|
{
|
|
m_statusTimer.stop();
|
|
m_updateTimer.stop();
|
|
delete ui;
|
|
}
|
|
|
|
void PerseusGui::destroy()
|
|
{
|
|
delete this;
|
|
}
|
|
|
|
void PerseusGui::resetToDefaults()
|
|
{
|
|
m_settings.resetToDefaults();
|
|
displaySettings();
|
|
m_forceSettings = true;
|
|
sendSettings();
|
|
}
|
|
|
|
QByteArray PerseusGui::serialize() const
|
|
{
|
|
return m_settings.serialize();
|
|
}
|
|
|
|
bool PerseusGui::deserialize(const QByteArray& data)
|
|
{
|
|
if(m_settings.deserialize(data)) {
|
|
displaySettings();
|
|
m_forceSettings = true;
|
|
sendSettings();
|
|
return true;
|
|
} else {
|
|
resetToDefaults();
|
|
return false;
|
|
}
|
|
}
|
|
|
|
bool PerseusGui::handleMessage(const Message& message)
|
|
{
|
|
// Returned messages to update the GUI (usually from web interface)
|
|
if (PerseusInput::MsgConfigurePerseus::match(message))
|
|
{
|
|
const PerseusInput::MsgConfigurePerseus& cfg = (PerseusInput::MsgConfigurePerseus&) message;
|
|
|
|
if (cfg.getForce()) {
|
|
m_settings = cfg.getSettings();
|
|
} else {
|
|
m_settings.applySettings(cfg.getSettingsKeys(), cfg.getSettings());
|
|
}
|
|
|
|
blockApplySettings(true);
|
|
displaySettings();
|
|
blockApplySettings(false);
|
|
return true;
|
|
}
|
|
else if (PerseusInput::MsgStartStop::match(message))
|
|
{
|
|
PerseusInput::MsgStartStop& notif = (PerseusInput::MsgStartStop&) message;
|
|
blockApplySettings(true);
|
|
ui->startStop->setChecked(notif.getStartStop());
|
|
blockApplySettings(false);
|
|
|
|
return true;
|
|
}
|
|
else
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
|
|
void PerseusGui::handleInputMessages()
|
|
{
|
|
Message* message;
|
|
|
|
while ((message = m_inputMessageQueue.pop()) != 0)
|
|
{
|
|
if (DSPSignalNotification::match(*message))
|
|
{
|
|
DSPSignalNotification* notif = (DSPSignalNotification*) message;
|
|
m_sampleRate = notif->getSampleRate();
|
|
m_deviceCenterFrequency = notif->getCenterFrequency();
|
|
qDebug("PerseusGui::handleInputMessages: DSPSignalNotification: SampleRate:%d, CenterFrequency:%llu", notif->getSampleRate(), notif->getCenterFrequency());
|
|
updateSampleRateAndFrequency();
|
|
|
|
delete message;
|
|
}
|
|
else
|
|
{
|
|
if (!handleMessage(*message))
|
|
{
|
|
qDebug("%s: unhandled message: %s", Q_FUNC_INFO, message->getIdentifier());
|
|
}
|
|
delete message;
|
|
}
|
|
}
|
|
}
|
|
|
|
void PerseusGui::updateSampleRateAndFrequency()
|
|
{
|
|
m_deviceUISet->getSpectrum()->setSampleRate(m_sampleRate);
|
|
m_deviceUISet->getSpectrum()->setCenterFrequency(m_deviceCenterFrequency);
|
|
ui->deviceRateText->setText(tr("%1k").arg((float)m_sampleRate / 1000));
|
|
}
|
|
|
|
void PerseusGui::displaySettings()
|
|
{
|
|
blockApplySettings(true);
|
|
setTitle(m_settings.m_title);
|
|
getDeviceUISet()->m_mainSpectrumGUI->setTitle(m_settings.m_title);
|
|
updateFrequencyLimits();
|
|
ui->transverter->setDeltaFrequency(m_settings.m_transverterDeltaFrequency);
|
|
ui->transverter->setDeltaFrequencyActive(m_settings.m_transverterMode);
|
|
ui->transverter->setIQOrder(m_settings.m_iqOrder);
|
|
ui->centerFrequency->setValue(m_settings.m_centerFrequency / 1000);
|
|
ui->LOppm->setValue(m_settings.m_LOppmTenths);
|
|
ui->LOppmText->setText(QString("%1").arg(QString::number(m_settings.m_LOppmTenths/10.0, 'f', 1)));
|
|
ui->sampleRate->setCurrentIndex(m_settings.m_devSampleRateIndex);
|
|
ui->decim->setCurrentIndex(m_settings.m_log2Decim);
|
|
ui->wideband->setChecked(m_settings.m_wideBand);
|
|
ui->adcDither->setChecked(m_settings.m_adcDither);
|
|
ui->adcPreamp->setChecked(m_settings.m_adcPreamp);
|
|
ui->attenuator->setCurrentIndex((int) m_settings.m_attenuator);
|
|
blockApplySettings(false);
|
|
}
|
|
|
|
void PerseusGui::displaySampleRates()
|
|
{
|
|
unsigned int savedIndex = m_settings.m_devSampleRateIndex;
|
|
ui->sampleRate->blockSignals(true);
|
|
|
|
if (m_rates.size() > 0)
|
|
{
|
|
ui->sampleRate->clear();
|
|
|
|
for (unsigned int i = 0; i < m_rates.size(); i++)
|
|
{
|
|
int sampleRate = m_rates[i]/1000;
|
|
ui->sampleRate->addItem(QString("%1").arg(QString("%1").arg(sampleRate, 5, 10, QChar(' '))));
|
|
}
|
|
}
|
|
|
|
ui->sampleRate->blockSignals(false);
|
|
|
|
if (savedIndex < m_rates.size())
|
|
{
|
|
ui->sampleRate->setCurrentIndex(savedIndex);
|
|
}
|
|
else
|
|
{
|
|
ui->sampleRate->setCurrentIndex((int) m_rates.size()-1);
|
|
}
|
|
}
|
|
|
|
void PerseusGui::updateFrequencyLimits()
|
|
{
|
|
// values in kHz
|
|
qint64 deltaFrequency = m_settings.m_transverterMode ? m_settings.m_transverterDeltaFrequency/1000 : 0;
|
|
|
|
qint64 minLimit = 10 + deltaFrequency;
|
|
qint64 maxLimit = 40000 + deltaFrequency;
|
|
|
|
if (m_settings.m_transverterMode)
|
|
{
|
|
minLimit = minLimit < 0 ? 0 : minLimit > 999999999 ? 999999999 : minLimit;
|
|
maxLimit = maxLimit < 0 ? 0 : maxLimit > 999999999 ? 999999999 : maxLimit;
|
|
ui->centerFrequency->setValueRange(9, minLimit, maxLimit);
|
|
}
|
|
else
|
|
{
|
|
minLimit = minLimit < 0 ? 0 : minLimit > 99999 ? 99999 : minLimit;
|
|
maxLimit = maxLimit < 0 ? 0 : maxLimit > 99999 ? 99999 : maxLimit;
|
|
ui->centerFrequency->setValueRange(5, minLimit, maxLimit);
|
|
}
|
|
qDebug("PerseusGui::updateFrequencyLimits: delta: %lld min: %lld max: %lld", deltaFrequency, minLimit, maxLimit);
|
|
}
|
|
|
|
void PerseusGui::sendSettings()
|
|
{
|
|
if(!m_updateTimer.isActive())
|
|
m_updateTimer.start(100);
|
|
}
|
|
|
|
void PerseusGui::on_centerFrequency_changed(quint64 value)
|
|
{
|
|
m_settings.m_centerFrequency = value * 1000;
|
|
m_settingsKeys.append("centerFrequency");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_LOppm_valueChanged(int value)
|
|
{
|
|
m_settings.m_LOppmTenths = value;
|
|
ui->LOppmText->setText(QString("%1").arg(QString::number(m_settings.m_LOppmTenths/10.0, 'f', 1)));
|
|
m_settingsKeys.append("LOppmTenths");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_resetLOppm_clicked()
|
|
{
|
|
ui->LOppm->setValue(0);
|
|
}
|
|
|
|
void PerseusGui::on_sampleRate_currentIndexChanged(int index)
|
|
{
|
|
m_settings.m_devSampleRateIndex = index;
|
|
m_settingsKeys.append("devSampleRateIndex");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_wideband_toggled(bool checked)
|
|
{
|
|
m_settings.m_wideBand = checked;
|
|
m_settingsKeys.append("wideBand");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_decim_currentIndexChanged(int index)
|
|
{
|
|
if ((index < 0) || (index > 5)) {
|
|
return;
|
|
}
|
|
|
|
m_settings.m_log2Decim = index;
|
|
m_settingsKeys.append("log2Decim");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_startStop_toggled(bool checked)
|
|
{
|
|
if (m_doApplySettings)
|
|
{
|
|
PerseusInput::MsgStartStop *message = PerseusInput::MsgStartStop::create(checked);
|
|
m_sampleSource->getInputMessageQueue()->push(message);
|
|
}
|
|
}
|
|
|
|
void PerseusGui::on_transverter_clicked()
|
|
{
|
|
m_settings.m_transverterMode = ui->transverter->getDeltaFrequencyAcive();
|
|
m_settings.m_transverterDeltaFrequency = ui->transverter->getDeltaFrequency();
|
|
m_settings.m_iqOrder = ui->transverter->getIQOrder();
|
|
qDebug("PerseusGui::on_transverter_clicked: %lld Hz %s", m_settings.m_transverterDeltaFrequency, m_settings.m_transverterMode ? "on" : "off");
|
|
updateFrequencyLimits();
|
|
m_settings.m_centerFrequency = ui->centerFrequency->getValueNew()*1000;
|
|
m_settingsKeys.append("transverterMode");
|
|
m_settingsKeys.append("transverterDeltaFrequency");
|
|
m_settingsKeys.append("iqOrder");
|
|
m_settingsKeys.append("centerFrequency");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_attenuator_currentIndexChanged(int index)
|
|
{
|
|
if ((index < 0) || (index >= (int) PerseusSettings::Attenuator_last)) {
|
|
return;
|
|
}
|
|
|
|
m_settings.m_attenuator = (PerseusSettings::Attenuator) index;
|
|
m_settingsKeys.append("attenuator");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_adcDither_toggled(bool checked)
|
|
{
|
|
m_settings.m_adcDither = checked;
|
|
m_settingsKeys.append("adcDither");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::on_adcPreamp_toggled(bool checked)
|
|
{
|
|
m_settings.m_adcPreamp = checked;
|
|
m_settingsKeys.append("adcPreamp");
|
|
sendSettings();
|
|
}
|
|
|
|
void PerseusGui::updateHardware()
|
|
{
|
|
qDebug() << "PerseusGui::updateHardware";
|
|
PerseusInput::MsgConfigurePerseus* message = PerseusInput::MsgConfigurePerseus::create(m_settings, m_settingsKeys, m_forceSettings);
|
|
m_sampleSource->getInputMessageQueue()->push(message);
|
|
m_forceSettings = false;
|
|
m_settingsKeys.clear();
|
|
m_updateTimer.stop();
|
|
}
|
|
|
|
void PerseusGui::updateStatus()
|
|
{
|
|
int state = m_deviceUISet->m_deviceAPI->state();
|
|
|
|
if(m_lastEngineState != state)
|
|
{
|
|
switch(state)
|
|
{
|
|
case DeviceAPI::StNotStarted:
|
|
ui->startStop->setStyleSheet("QToolButton { background:rgb(79,79,79); }");
|
|
break;
|
|
case DeviceAPI::StIdle:
|
|
ui->startStop->setStyleSheet("QToolButton { background-color : blue; }");
|
|
break;
|
|
case DeviceAPI::StRunning:
|
|
ui->startStop->setStyleSheet("QToolButton { background-color : green; }");
|
|
break;
|
|
case DeviceAPI::StError:
|
|
ui->startStop->setStyleSheet("QToolButton { background-color : red; }");
|
|
QMessageBox::information(this, tr("Message"), m_deviceUISet->m_deviceAPI->errorMessage());
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
m_lastEngineState = state;
|
|
}
|
|
}
|
|
|
|
uint32_t PerseusGui::getDevSampleRate(unsigned int rate_index)
|
|
{
|
|
if (rate_index < m_rates.size())
|
|
{
|
|
return m_rates[rate_index];
|
|
}
|
|
else
|
|
{
|
|
return m_rates[0];
|
|
}
|
|
}
|
|
|
|
int PerseusGui::getDevSampleRateIndex(uint32_t sampeRate)
|
|
{
|
|
for (unsigned int i=0; i < m_rates.size(); i++)
|
|
{
|
|
if (sampeRate == m_rates[i])
|
|
{
|
|
return i;
|
|
}
|
|
}
|
|
|
|
return -1;
|
|
}
|
|
|
|
void PerseusGui::openDeviceSettingsDialog(const QPoint& p)
|
|
{
|
|
if (m_contextMenuType == ContextMenuDeviceSettings)
|
|
{
|
|
BasicDeviceSettingsDialog dialog(this);
|
|
dialog.setUseReverseAPI(m_settings.m_useReverseAPI);
|
|
dialog.setReverseAPIAddress(m_settings.m_reverseAPIAddress);
|
|
dialog.setReverseAPIPort(m_settings.m_reverseAPIPort);
|
|
dialog.setReverseAPIDeviceIndex(m_settings.m_reverseAPIDeviceIndex);
|
|
dialog.setTitle(m_settings.m_title);
|
|
dialog.setDefaultTitle(getDefaultTitle());
|
|
|
|
dialog.move(p);
|
|
new DialogPositioner(&dialog, false);
|
|
dialog.exec();
|
|
|
|
if (dialog.result() == QDialog::Accepted)
|
|
{
|
|
m_settings.m_title = dialog.getTitle();
|
|
setTitle(m_settings.m_title);
|
|
getDeviceUISet()->m_mainSpectrumGUI->setTitle(m_settings.m_title);
|
|
m_settings.m_useReverseAPI = dialog.useReverseAPI();
|
|
m_settings.m_reverseAPIAddress = dialog.getReverseAPIAddress();
|
|
m_settings.m_reverseAPIPort = dialog.getReverseAPIPort();
|
|
m_settings.m_reverseAPIDeviceIndex = dialog.getReverseAPIDeviceIndex();
|
|
m_settingsKeys.append("title");
|
|
m_settingsKeys.append("useReverseAPI");
|
|
m_settingsKeys.append("reverseAPIAddress");
|
|
m_settingsKeys.append("reverseAPIPort");
|
|
m_settingsKeys.append("reverseAPIDeviceIndex");
|
|
|
|
sendSettings();
|
|
}
|
|
}
|
|
|
|
resetContextMenuType();
|
|
}
|
|
|
|
void PerseusGui::makeUIConnections()
|
|
{
|
|
QObject::connect(ui->centerFrequency, &ValueDial::changed, this, &PerseusGui::on_centerFrequency_changed);
|
|
QObject::connect(ui->LOppm, &QSlider::valueChanged, this, &PerseusGui::on_LOppm_valueChanged);
|
|
QObject::connect(ui->resetLOppm, &QPushButton::clicked, this, &PerseusGui::on_resetLOppm_clicked);
|
|
QObject::connect(ui->sampleRate, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PerseusGui::on_sampleRate_currentIndexChanged);
|
|
QObject::connect(ui->wideband, &ButtonSwitch::toggled, this, &PerseusGui::on_wideband_toggled);
|
|
QObject::connect(ui->decim, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PerseusGui::on_decim_currentIndexChanged);
|
|
QObject::connect(ui->startStop, &ButtonSwitch::toggled, this, &PerseusGui::on_startStop_toggled);
|
|
QObject::connect(ui->transverter, &TransverterButton::clicked, this, &PerseusGui::on_transverter_clicked);
|
|
QObject::connect(ui->attenuator, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PerseusGui::on_attenuator_currentIndexChanged);
|
|
QObject::connect(ui->adcDither, &ButtonSwitch::toggled, this, &PerseusGui::on_adcDither_toggled);
|
|
QObject::connect(ui->adcPreamp, &ButtonSwitch::toggled, this, &PerseusGui::on_adcPreamp_toggled);
|
|
}
|