1
0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-07-12 05:44:25 -04:00
Files
sdrangel/devices/plutosdr/deviceplutosdrscan.cpp
T
Robin Getz cfeac1dc11 plutosdr: refactor device identity and backend-based grouping
Improve PlutoSDR device identity handling to correctly distinguish
multiple libiio backends (IP, USB, etc.) and provide stable grouping
of physically identical hardware in the UI.
- Append backend prefix to scanned device serials to ensure uniqueness
  across multiple discovery paths (e.g. "<serial>_ip", "<serial>_usb").
  This prevents collisions when the same device is visible through
  different transports.
- Add physical serial extraction and grouping logic so that devices
  discovered via multiple backends are treated as a single physical
  unit for display purposes. This stabilizes UI numbering and avoids
  duplicate entries for the same hardware.
- Update enumOriginDevices() to:
  - group devices by physical serial rather than scan index
  - assign stable per-device indices independent of backend enumeration
  - include backend label in the display name to distinguish connection
    paths when multiple backends are active
- Introduce helper utilities:
  - createBackendSuffix(): extract backend identifier from libiio URI
  - getPhysicalSerial(): strip backend suffix for grouping logic
  - getBackendLabel(): format backend suffix for user-facing display

These changes ensure:
- unique internal identifiers per backend connection
- consistent grouping per physical device across discovery mechanisms
- improved UI clarity when multiple access paths exist for the same SDR

No change to RF/data path behavior; this is purely a discovery and
presentation-layer refactor.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
2026-07-04 16:41:16 -04:00

287 lines
9.2 KiB
C++

///////////////////////////////////////////////////////////////////////////////////
// Copyright (C) 2017, 2019 Edouard Griffiths, F4EXB <f4exb06@gmail.com> //
// Copyright (C) 2019 Sebastian Weiss <dl3yc@darc.de> //
// Copyright (C) 2021 Andreas Baulig <free.geronimo@hotmail.de> //
// //
// This program is free software; you can redistribute it and/or modify //
// it under the terms of the GNU General Public License as published by //
// the Free Software Foundation as version 3 of the License, or //
// (at your option) any later version. //
// //
// This program is distributed in the hope that it will be useful, //
// but WITHOUT ANY WARRANTY; without even the implied warranty of //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
// GNU General Public License V3 for more details. //
// //
// You should have received a copy of the GNU General Public License //
// along with this program. If not, see <http://www.gnu.org/licenses/>. //
///////////////////////////////////////////////////////////////////////////////////
#include <iostream>
#include <cstdio>
#include <cstring>
#include <regex>
#include <memory>
#include <string_view>
#include <iio.h>
#include <QtGlobal>
#include "deviceplutosdrbox.h"
#include "deviceplutosdrscan.h"
void DevicePlutoSDRScan::scan()
{
int i, num_contexts;
struct iio_scan_context *scan_ctx;
struct iio_context_info **info;
scan_ctx = iio_create_scan_context(0, 0);
if (!scan_ctx)
{
qCritical("PlutoSDRScan::scan: could not create scan context");
return;
}
num_contexts = iio_scan_context_get_info_list(scan_ctx, &info);
if (num_contexts < 0)
{
qCritical("PlutoSDRScan::scan: could not get contexts");
return;
}
m_scans.clear();
m_scans.reserve(num_contexts);
qDebug("PlutoSDRScan::scan: found %d contexts", num_contexts);
for (i = 0; i < num_contexts; i++)
{
const char *description = iio_context_info_get_description(info[i]);
const char *uri = iio_context_info_get_uri(info[i]);
if (!DevicePlutoSDRBox::probeURI(std::string(uri))) { // continue if not accessible
continue;
}
qDebug("PlutoSDRScan::scan: %d: %s [%s]", i, description, uri);
const std::string_view descriptionView = description ? std::string_view{description} : std::string_view{};
const bool isPlutoDescription =
(descriptionView.find("PlutoSDR") != std::string_view::npos) ||
(descriptionView.find("AD93") != std::string_view::npos);
if (isPlutoDescription)
{
// As device scan is used across multiple vectors it's best to use a
// managed pointer, as to keep track of when it's safe to delete.
std::shared_ptr<DeviceScan> dev_scan = std::make_shared<DeviceScan>(
DeviceScan({
std::string(description),
std::string("TBD"),
std::string(uri)
}));
m_scans.push_back(dev_scan);
m_urilMap[m_scans.back()->m_uri] = m_scans.back();
std::regex desc_regex(".*serial=(.+)");
std::smatch desc_match;
std::regex_search(m_scans.back()->m_name, desc_match, desc_regex);
if (desc_match.size() == 2)
{
// A device can be discovered through multiple backends (e.g. USB and IP).
// Keep the backend in the serial key so each scanned entry remains unique.
m_scans.back()->m_serial = desc_match[1].str() + createBackendSuffix(uri);
m_serialMap[m_scans.back()->m_serial] = m_scans.back();
}
}
}
iio_context_info_list_free(info);
iio_scan_context_destroy(scan_ctx);
}
const std::string* DevicePlutoSDRScan::getURIAt(unsigned int index) const
{
if (index < m_scans.size()) {
return &(m_scans[index]->m_uri);
} else {
return 0;
}
}
const std::string* DevicePlutoSDRScan::getSerialAt(unsigned int index) const
{
if (index < m_scans.size()) {
return &(m_scans[index]->m_serial);
} else {
return 0;
}
}
const std::string* DevicePlutoSDRScan::getURIFromSerial(
const std::string& serial) const
{
std::map<std::string, std::shared_ptr<DeviceScan>>::const_iterator it = m_serialMap.find(serial);
if (it == m_serialMap.end()) {
return 0;
} else {
return &((it->second)->m_uri);
}
}
void DevicePlutoSDRScan::getSerials(std::vector<std::string>& serials) const
{
std::vector<std::shared_ptr<DeviceScan>>::const_iterator it = m_scans.begin();
serials.clear();
for (; it != m_scans.end(); ++it) {
serials.push_back((*it)->m_serial);
}
}
void DevicePlutoSDRScan::enumOriginDevices(const QString& hardwareId, PluginInterface::OriginDevices& originDevices)
{
scan();
std::vector<std::string> serials;
getSerials(serials);
// Multiple backends can refer to the same physical device.
// Keep a separate list of physical serials for stable display numbering.
// Example: Pluto[0] (ip) and Pluto[0] (usb) refer to the same hardware.
std::map<std::string, int> physicalSerialIndexes;
std::vector<std::string>::const_iterator it = serials.begin();
int i;
for (i = 0; it != serials.end(); ++it, ++i)
{
// Keep the backend-qualified serial as the device identifier.
QString serial_str = QString::fromLocal8Bit(it->c_str());
// Remove backend suffix for display and grouping.
std::string physicalSerial = getPhysicalSerial(*it);
// Find the existing physical device index so USB/IP instances share a label.
auto pos = physicalSerialIndexes.find(physicalSerial);
// Display index is based on physical devices, not backend instances.
int physical_idx;
if (pos == physicalSerialIndexes.end())
{
physical_idx = physicalSerialIndexes.size();
physicalSerialIndexes[physicalSerial] = physical_idx;
}
else
{
physical_idx = pos->second;
}
// Show backend information to distinguish multiple connections to the same device.
QString displayableName(
QString("PlutoSDR%1%2 %3")
.arg(physical_idx)
.arg(getBackendLabel(*it))
.arg(QString::fromLocal8Bit(physicalSerial.c_str())));
originDevices.append(PluginInterface::OriginDevice(
displayableName,
hardwareId,
serial_str,
i, // sequence
1, // Nb Rx
1 // Nb Tx
));
qDebug("DevicePlutoSDRScan::enumOriginDevices: enumerated PlutoSDR device #%d", i);
}
}
/**
* @brief Creates a backend prefix from a libiio URI.
*
* The backend is converted into a serial suffix so that devices
* discovered through different backends remain unique.
*
* Examples:
* ip:192.168.2.1 -> "_ip"
* usb:3.32.5 -> "_usb"
* serial:/dev/ttyUSB0 -> "_serial"
* local: -> "_local"
*
* @param uri Device URI returned by libiio.
*
* @return iio backend suffix including the separator, or an empty string
* if no backend prefix is present.
*/
std::string DevicePlutoSDRScan::createBackendSuffix(const char *uri) const
{
if (!uri) {
return {};
}
const char *sep = std::strchr(uri, ':');
if (!sep) {
return {};
}
return std::string(1, BACKEND_SEPARATOR) + std::string(uri, sep - uri);
}
/**
* @brief Creates a display string for the backend portion of a serial.
*
* The scan process appends the backend to make serial numbers unique.
* This function recovers the backend suffix into a user-facing label for
* display purposes.
*
* Examples:
* ABC123_ip -> " (ip)"
* ABC123_usb -> " (usb)"
*
* @param serial backend-qualified serial number.
*
* @return Display label suffix.
*/
QString DevicePlutoSDRScan::getBackendLabel(const std::string& serial) const
{
size_t sep = serial.rfind(BACKEND_SEPARATOR);
if (sep == std::string::npos)
{
return {};
}
return QString(" (%1)").arg(
QString::fromStdString(serial.substr(sep + 1)));
}
/**
* @brief Removes the backend suffix from a serial number.
*
* The scan process appends the backend to make serial numbers unique.
* This function recovers the physical device serial for grouping and
* display purposes.
*
* Examples:
* ABC123_ip -> ABC123
* ABC123_usb -> ABC123
*
* @param serial backend-qualified serial number.
*
* @return Physical device serial number.
*/
std::string DevicePlutoSDRScan::getPhysicalSerial(const std::string& serial) const
{
size_t sep = serial.rfind(BACKEND_SEPARATOR);
if (sep == std::string::npos)
{
return serial;
}
return serial.substr(0, sep);
}