comicsansg/CubicSDR
comicsansg/CubicSDR
1
0
Fork 0
mirror of https://github.com/cjcliffe/CubicSDR.git synced 2025-08-23 07:22:26 -04:00
Code Issues Projects Releases Wiki Activity

FIX audioVisOutputQueue nullptr crash

Browse Source
This commit is contained in:
vsonnier 2016-06-01 19:32:22 +02:00
parent a75faaf4f2
commit 41ca39eab7
2 changed files with 37 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/demod/DemodulatorThread.cpp
View File

@ -13,7 +13,9 @@
#include <pthread.h> #include <pthread.h>
#endif #endif
DemodulatorThread::DemodulatorThread(DemodulatorInstance *parent) : IOThread(), outputBuffers("DemodulatorThreadBuffers"), squelchLevel(-100), signalLevel(-100), squelchEnabled(false), cModem(nullptr), cModemKit(nullptr), iqInputQueue(NULL), audioOutputQueue(NULL), audioVisOutputQueue(NULL), threadQueueControl(NULL), threadQueueNotify(NULL) { DemodulatorThread::DemodulatorThread(DemodulatorInstance *parent)
: IOThread(), outputBuffers("DemodulatorThreadBuffers"), squelchLevel(-100),
signalLevel(-100), squelchEnabled(false) {
demodInstance = parent; demodInstance = parent;
muted.store(false); muted.store(false);
@ -26,6 +28,10 @@ DemodulatorThread::~DemodulatorThread() {
void DemodulatorThread::onBindOutput(std::string name, ThreadQueueBase *threadQueue) { void DemodulatorThread::onBindOutput(std::string name, ThreadQueueBase *threadQueue) {
if (name == "AudioVisualOutput") { if (name == "AudioVisualOutput") {
//protects because it may be changed at runtime
std::lock_guard < std::mutex > lock(m_mutexAudioVisOutputQueue);
audioVisOutputQueue = (DemodulatorThreadOutputQueue *)threadQueue; audioVisOutputQueue = (DemodulatorThreadOutputQueue *)threadQueue;
} }
} }
@ -119,7 +125,7 @@ void DemodulatorThread::run() {
modemData.data.assign(inputData->begin(), inputData->end()); modemData.data.assign(inputData->begin(), inputData->end());
modemData.setRefCount(1); modemData.setRefCount(1);
AudioThreadInput *ati = NULL; AudioThreadInput *ati = nullptr;
ModemAnalog *modemAnalog = (cModem->getType() == "analog")?((ModemAnalog *)cModem):nullptr; ModemAnalog *modemAnalog = (cModem->getType() == "analog")?((ModemAnalog *)cModem):nullptr;
ModemDigital *modemDigital = (cModem->getType() == "digital")?((ModemDigital *)cModem):nullptr; ModemDigital *modemDigital = (cModem->getType() == "digital")?((ModemDigital *)cModem):nullptr;
@ -159,7 +165,7 @@ void DemodulatorThread::run() {
} }
} }
if (audioOutputQueue != NULL && ati && !squelched) { if (audioOutputQueue != nullptr && ati && !squelched) {
std::vector<float>::iterator data_i; std::vector<float>::iterator data_i;
ati->peak = 0; ati->peak = 0;
for (data_i = ati->data.begin(); data_i != ati->data.end(); data_i++) { for (data_i = ati->data.begin(); data_i != ati->data.end(); data_i++) {
@ -173,8 +179,17 @@ void DemodulatorThread::run() {
ati = nullptr; ati = nullptr;
} }
if (ati && audioVisOutputQueue != NULL && audioVisOutputQueue->empty()) { //At that point, capture the current state of audioVisOutputQueue in a local
//variable, and works with it with now on until the next while-turn.
DemodulatorThreadOutputQueue* localAudioVisOutputQueue = nullptr;
{
std::lock_guard < std::mutex > lock(m_mutexAudioVisOutputQueue);
localAudioVisOutputQueue = audioVisOutputQueue;
}
if (ati && localAudioVisOutputQueue != nullptr && localAudioVisOutputQueue->empty()) {
AudioThreadInput *ati_vis = audioVisBuffers.getBuffer(); AudioThreadInput *ati_vis = audioVisBuffers.getBuffer();
ati_vis->setRefCount(1); ati_vis->setRefCount(1);
ati_vis->sampleRate = inp->sampleRate; ati_vis->sampleRate = inp->sampleRate;
ati_vis->inputRate = inp->sampleRate; ati_vis->inputRate = inp->sampleRate;
@ -230,11 +245,11 @@ void DemodulatorThread::run() {
ati_vis->type = 0; ati_vis->type = 0;
} }
audioVisOutputQueue->push(ati_vis); localAudioVisOutputQueue->push(ati_vis);
} }
if (ati != NULL) { if (ati != nullptr) {
if (!muted.load() && (!wxGetApp().getSoloMode() || (demodInstance == wxGetApp().getDemodMgr().getLastActiveDemodulator()))) { if (!muted.load() && (!wxGetApp().getSoloMode() || (demodInstance == wxGetApp().getDemodMgr().getLastActiveDemodulator()))) {
audioOutputQueue->push(ati); audioOutputQueue->push(ati);
} else { } else {
@ -266,7 +281,10 @@ void DemodulatorThread::run() {
outputBuffers.purge(); outputBuffers.purge();
if (audioVisOutputQueue && !audioVisOutputQueue->empty()) { //Guard the cleanup of audioVisOutputQueue properly.
std::lock_guard < std::mutex > lock(m_mutexAudioVisOutputQueue);
if (audioVisOutputQueue != nullptr && !audioVisOutputQueue->empty()) {
AudioThreadInput *dummy_vis; AudioThreadInput *dummy_vis;
audioVisOutputQueue->pop(dummy_vis); audioVisOutputQueue->pop(dummy_vis);
} }

21
src/demod/DemodulatorThread.h
View File

@ -40,8 +40,8 @@ protected:
float abMagnitude(double alpha, double beta, float inphase, float quadrature); float abMagnitude(double alpha, double beta, float inphase, float quadrature);
float linearToDb(float linear); float linearToDb(float linear);
DemodulatorInstance *demodInstance; DemodulatorInstance *demodInstance = nullptr;
ReBuffer<AudioThreadInput> outputBuffers; ReBuffer<AudioThreadInput> outputBuffers = nullptr;
std::atomic_bool muted; std::atomic_bool muted;
@ -49,12 +49,15 @@ protected:
std::atomic<float> signalLevel; std::atomic<float> signalLevel;
bool squelchEnabled, squelchBreak; bool squelchEnabled, squelchBreak;
Modem *cModem; Modem *cModem = nullptr;
ModemKit *cModemKit; ModemKit *cModemKit = nullptr;
DemodulatorThreadPostInputQueue* iqInputQueue; DemodulatorThreadPostInputQueue* iqInputQueue = nullptr;
AudioThreadInputQueue *audioOutputQueue; AudioThreadInputQueue *audioOutputQueue = nullptr;
DemodulatorThreadOutputQueue* audioVisOutputQueue; DemodulatorThreadOutputQueue* audioVisOutputQueue = nullptr;
DemodulatorThreadControlCommandQueue *threadQueueControl; DemodulatorThreadControlCommandQueue *threadQueueControl = nullptr;
DemodulatorThreadCommandQueue* threadQueueNotify; DemodulatorThreadCommandQueue* threadQueueNotify = nullptr;
//protects the audioVisOutputQueue dynamic binding change at runtime (in DemodulatorMgr)
mutable std::mutex m_mutexAudioVisOutputQueue;
}; };