Replace mutex lock/unlock pairs with guards, cleanups

src/AppConfig.cpp

@@ -47,39 +47,39 @@ bool DeviceConfig::getAGCMode() {
 
 
 void DeviceConfig::setDeviceId(std::string deviceId) {
-    busy_lock.lock();
+    std::lock_guard < std::mutex > lock(busy_lock);
     this->deviceId = deviceId;
-    busy_lock.unlock();
+    
 }
 
 std::string DeviceConfig::getDeviceId() {
     std::string tmp;
 
-    busy_lock.lock();
+    std::lock_guard < std::mutex > lock(busy_lock);
     tmp = deviceId;
-    busy_lock.unlock();
+    
 
     return tmp;
 }
 
 void DeviceConfig::setDeviceName(std::string deviceName) {
-    busy_lock.lock();
+    std::lock_guard < std::mutex > lock(busy_lock);
     this->deviceName = deviceName;
-    busy_lock.unlock();
+   
 }
 
 std::string DeviceConfig::getDeviceName() {
     std::string tmp;
     
-    busy_lock.lock();
+    std::lock_guard < std::mutex > lock(busy_lock);
     tmp = (deviceName=="")?deviceId:deviceName;
-    busy_lock.unlock();
+   
     
     return tmp;
 }
 
 void DeviceConfig::save(DataNode *node) {
-    busy_lock.lock();
+    std::lock_guard < std::mutex > lock(busy_lock);
     *node->newChild("id") = deviceId;
     *node->newChild("name") = deviceName;
     *node->newChild("ppm") = (int)ppm.load();
@@ -115,11 +115,11 @@ void DeviceConfig::save(DataNode *node) {
             *gainNode->newChild("value") = gain_i->second;
         }
     }
-    busy_lock.unlock();
+   
 }
 
 void DeviceConfig::load(DataNode *node) {
-    busy_lock.lock();
+    std::lock_guard < std::mutex > lock(busy_lock);
     if (node->hasAnother("name")) {
         deviceName = node->getNext("name")->element()->toString();
     }
@@ -201,7 +201,7 @@ void DeviceConfig::load(DataNode *node) {
             }
         }
     }
-    busy_lock.unlock();
+   
 }
 
 void DeviceConfig::setStreamOpts(ConfigSettings opts) {

src/AppFrame.cpp

@@ -1611,10 +1611,10 @@ bool AppFrame::loadSession(std::string fileName) {
         if (header->hasAnother("center_freq")) {
         long long center_freq = *header->getNext("center_freq");
 //            std::cout << "\tCenter Frequency: " << center_freq << std::endl;
+
         wxGetApp().setFrequency(center_freq);
         }
 
-
         if (header->hasAnother("sample_rate")) {
             int sample_rate = *header->getNext("sample_rate");
             
@@ -1739,7 +1739,7 @@ bool AppFrame::loadSession(std::string fileName) {
             newDemod->run();
             newDemod->setActive(true);
             demodsLoaded.push_back(newDemod);
-    //            wxGetApp().bindDemodulator(newDemod);
+//            wxGetApp().bindDemodulator(newDemod);
 
                 std::cout << "\tAdded demodulator at frequency " << newDemod->getFrequency() << " type " << type << std::endl;
 //                std::cout << "\t\tBandwidth: " << bandwidth << std::endl;

src/CubicSDR.cpp

@@ -397,7 +397,10 @@ void CubicSDR::removeRemote(std::string remoteAddr) {
 }
 
 void CubicSDR::sdrThreadNotify(SDRThread::SDRThreadState state, std::string message) {
-    notify_busy.lock();
+
+    std::lock_guard < std::mutex > lock(notify_busy);
+
+   
     if (state == SDRThread::SDR_THREAD_INITIALIZED) {
         appframe->initDeviceParams(getDevice());
     }
@@ -415,12 +418,13 @@ void CubicSDR::sdrThreadNotify(SDRThread::SDRThreadState state, std::string mess
 //        info->ShowModal();
     }
     //if (appframe) { appframe->SetStatusText(message); }
-    notify_busy.unlock();
+  
 }
 
 
 void CubicSDR::sdrEnumThreadNotify(SDREnumerator::SDREnumState state, std::string message) {
-    notify_busy.lock();
+    std::lock_guard < std::mutex > lock(notify_busy);
+
     if (state == SDREnumerator::SDR_ENUM_MESSAGE) {
         notifyMessage = message;
     }
@@ -432,7 +436,7 @@ void CubicSDR::sdrEnumThreadNotify(SDREnumerator::SDREnumState state, std::strin
         devicesFailed.store(true);
     }
     //if (appframe) { appframe->SetStatusText(message); }
-    notify_busy.unlock();
+   
 
 }
 
@@ -748,9 +752,9 @@ bool CubicSDR::areModulesMissing() {
 
 std::string CubicSDR::getNotification() {
     std::string msg;
-    notify_busy.lock();
+    std::lock_guard < std::mutex > lock(notify_busy);
     msg = notifyMessage;
-    notify_busy.unlock();
+   
     return msg;
 }
 

src/CubicSDR.h

@@ -212,7 +212,9 @@ private:
     std::atomic_bool useLocalMod;
     std::string notifyMessage;
     std::string modulePath;
+    
     std::mutex notify_busy;
+    
     std::atomic_bool frequency_locked;
     std::atomic_llong lock_freq;
     FrequencyDialog::FrequencyDialogTarget fdlgTarget;

src/IOThread.h

@@ -37,6 +37,12 @@ public:
         std::lock_guard < std::recursive_mutex > lock(m_mutex);
         return refCount;
     }
+
+    // Access to the own mutex protecting the ReferenceCounter, i.e the monitor of the class
+     std::recursive_mutex& getMonitor() const {
+        return m_mutex;
+    }
+
 protected:
     //this is a basic mutex for all ReferenceCounter derivatives operations INCLUDING the counter itself for consistency !
    mutable std::recursive_mutex m_mutex;

src/audio/AudioThread.h

@@ -20,7 +20,6 @@ public:
     float peak;
     int type;
     std::vector<float> data;
-    std::mutex busy_update;
 
     AudioThreadInput() :
             frequency(0), sampleRate(0), channels(0), peak(0) {

src/demod/DemodDefs.h

@@ -53,7 +53,7 @@ public:
     long long frequency;
     long long sampleRate;
     std::vector<liquid_float_complex> data;
-    std::mutex busy_rw;
+   
 
     DemodulatorThreadIQData() :
             frequency(0), sampleRate(0) {

src/demod/DemodulatorMgr.cpp

@@ -31,7 +31,7 @@ DemodulatorMgr::~DemodulatorMgr() {
 }
 
 DemodulatorInstance *DemodulatorMgr::newThread() {
-    std::lock_guard < std::mutex > lock(demods_busy);
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     DemodulatorInstance *newDemod = new DemodulatorInstance;
 
     std::stringstream label;
@@ -44,8 +44,9 @@ DemodulatorInstance *DemodulatorMgr::newThread() {
 }
 
 void DemodulatorMgr::terminateAll() {
-    std::lock_guard < std::mutex > lock(demods_busy);
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     while (demods.size()) {
+
         DemodulatorInstance *d = demods.back();
         demods.pop_back();
         wxGetApp().removeDemodulator(d);
@@ -54,11 +55,12 @@ void DemodulatorMgr::terminateAll() {
 }
 
 std::vector<DemodulatorInstance *> &DemodulatorMgr::getDemodulators() {
-    std::lock_guard < std::mutex > lock(demods_busy);
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     return demods;
 }
 
 std::vector<DemodulatorInstance *> DemodulatorMgr::getOrderedDemodulators(bool actives) {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     std::vector<DemodulatorInstance *> demods_ordered = demods;
     if (actives) {
         std::sort(demods_ordered.begin(), demods_ordered.end(), inactiveCompare);
@@ -74,11 +76,13 @@ std::vector<DemodulatorInstance *> DemodulatorMgr::getOrderedDemodulators(bool a
             demods_ordered.erase(demods_ordered.begin(), i);
         }
     }
-    std::sort(demods_ordered.begin(), demods_ordered.end(), demodFreqCompare);
+    //if by chance they have the same frequency, keep their relative order
+    std::stable_sort(demods_ordered.begin(), demods_ordered.end(), demodFreqCompare);
     return demods_ordered;
 }
 
 DemodulatorInstance *DemodulatorMgr::getPreviousDemodulator(DemodulatorInstance *demod, bool actives) {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     if (!getLastActiveDemodulator()) {
         return nullptr;
     }
@@ -94,6 +98,7 @@ DemodulatorInstance *DemodulatorMgr::getPreviousDemodulator(DemodulatorInstance
 }
 
 DemodulatorInstance *DemodulatorMgr::getNextDemodulator(DemodulatorInstance *demod, bool actives) {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     if (!getLastActiveDemodulator()) {
         return nullptr;
     }
@@ -112,16 +117,20 @@ DemodulatorInstance *DemodulatorMgr::getNextDemodulator(DemodulatorInstance *dem
 }
 
 DemodulatorInstance *DemodulatorMgr::getLastDemodulator() {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     std::vector<DemodulatorInstance *> demods_ordered = getOrderedDemodulators();
     return *(demods_ordered.end());
 }
 
 DemodulatorInstance *DemodulatorMgr::getFirstDemodulator() {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     std::vector<DemodulatorInstance *> demods_ordered = getOrderedDemodulators();
     return *(demods_ordered.begin());
 }
 
 void DemodulatorMgr::deleteThread(DemodulatorInstance *demod) {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
+    
     std::vector<DemodulatorInstance *>::iterator i;
 
     i = std::find(demods.begin(), demods.end(), demod);
@@ -145,7 +154,7 @@ void DemodulatorMgr::deleteThread(DemodulatorInstance *demod) {
 }
 
 std::vector<DemodulatorInstance *> *DemodulatorMgr::getDemodulatorsAt(long long freq, int bandwidth) {
-    std::lock_guard < std::mutex > lock(demods_busy);
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     std::vector<DemodulatorInstance *> *foundDemods = new std::vector<DemodulatorInstance *>();
 
     for (int i = 0, iMax = demods.size(); i < iMax; i++) {
@@ -166,7 +175,7 @@ std::vector<DemodulatorInstance *> *DemodulatorMgr::getDemodulatorsAt(long long
 }
 
 bool DemodulatorMgr::anyDemodulatorsAt(long long freq, int bandwidth) {
-    std::lock_guard < std::mutex > lock(demods_busy);
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     for (int i = 0, iMax = demods.size(); i < iMax; i++) {
         DemodulatorInstance *testDemod = demods[i];
 
@@ -177,6 +186,7 @@ bool DemodulatorMgr::anyDemodulatorsAt(long long freq, int bandwidth) {
         long long halfBuffer = bandwidth / 2;
         
         if ((freq <= (freqTest + ((testDemod->getDemodulatorType() != "LSB")?halfBandwidthTest:0) + halfBuffer)) && (freq >= (freqTest - ((testDemod->getDemodulatorType() != "USB")?halfBandwidthTest:0) - halfBuffer))) {
+           
             return true;
         }
     }
@@ -186,6 +196,7 @@ bool DemodulatorMgr::anyDemodulatorsAt(long long freq, int bandwidth) {
 
 
 void DemodulatorMgr::setActiveDemodulator(DemodulatorInstance *demod, bool temporary) {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     if (!temporary) {
         if (activeDemodulator != NULL) {
             lastActiveDemodulator = activeDemodulator;
@@ -218,6 +229,7 @@ void DemodulatorMgr::setActiveDemodulator(DemodulatorInstance *demod, bool tempo
     }
 
     activeDemodulator = demod;
+
 }
 
 DemodulatorInstance *DemodulatorMgr::getActiveDemodulator() {
@@ -231,9 +243,10 @@ DemodulatorInstance *DemodulatorMgr::getLastActiveDemodulator() {
     return lastActiveDemodulator;
 }
 
+//Private internal method, no need to protect it with demods_busy
 void DemodulatorMgr::garbageCollect() {
-    std::lock_guard < std::mutex > lock(demods_busy);
     if (demods_deleted.size()) {
+      
         std::vector<DemodulatorInstance *>::iterator i;
 
         for (i = demods_deleted.begin(); i != demods_deleted.end(); i++) {
@@ -245,13 +258,16 @@ void DemodulatorMgr::garbageCollect() {
 
                 delete deleted;
 
+              
                 return;
             }
         }
+      
     }
 }
 
 void DemodulatorMgr::updateLastState() {
+    std::lock_guard < std::recursive_mutex > lock(demods_busy);
     if (std::find(demods.begin(), demods.end(), lastActiveDemodulator) == demods.end()) {
         if (activeDemodulator && activeDemodulator->isActive()) {
             lastActiveDemodulator = activeDemodulator;

src/demod/DemodulatorMgr.h

@@ -72,7 +72,9 @@ private:
     bool lastMuted;
     bool lastDeltaLock;
     
-    std::mutex demods_busy;
+    //protects access to demods lists and such, need to be recursive
+    //because of the usage of public re-entrant methods 
+    std::recursive_mutex demods_busy;
     
     std::map<std::string, ModemSettings> lastModemSettings;
 };

src/process/SpectrumVisualProcessor.cpp

@@ -54,24 +54,27 @@ bool SpectrumVisualProcessor::isView() {
 }
 
 void SpectrumVisualProcessor::setView(bool bView) {
-    busy_run.lock();
+    
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
     is_view.store(bView);
-    busy_run.unlock();
+    
 }
 
 void SpectrumVisualProcessor::setView(bool bView, long long centerFreq_in, long bandwidth_in) {
-    busy_run.lock();
+    
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
     is_view.store(bView);
     bandwidth.store(bandwidth_in);
     centerFreq.store(centerFreq_in);
-    busy_run.unlock();
+   
 }
 
 
 void SpectrumVisualProcessor::setFFTAverageRate(float fftAverageRate) {
-    busy_run.lock();
+   
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
     this->fft_average_rate.store(fftAverageRate);
-    busy_run.unlock();
+    
 }
 
 float SpectrumVisualProcessor::getFFTAverageRate() {
@@ -79,9 +82,10 @@ float SpectrumVisualProcessor::getFFTAverageRate() {
 }
 
 void SpectrumVisualProcessor::setCenterFrequency(long long centerFreq_in) {
-    busy_run.lock();
+   
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
     centerFreq.store(centerFreq_in);
-    busy_run.unlock();
+   
 }
 
 long long SpectrumVisualProcessor::getCenterFrequency() {
@@ -89,9 +93,10 @@ long long SpectrumVisualProcessor::getCenterFrequency() {
 }
 
 void SpectrumVisualProcessor::setBandwidth(long bandwidth_in) {
-    busy_run.lock();
+   
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
     bandwidth.store(bandwidth_in);
-    busy_run.unlock();
+   
 }
 
 long SpectrumVisualProcessor::getBandwidth() {
@@ -99,6 +104,7 @@ long SpectrumVisualProcessor::getBandwidth() {
 }
 
 void SpectrumVisualProcessor::setPeakHold(bool peakHold_in) {
+   
     if (peakHold.load() && peakHold_in) {
         peakReset.store(PEAK_RESET_COUNT);
     } else {
@@ -116,7 +122,8 @@ int SpectrumVisualProcessor::getDesiredInputSize() {
 }
 
 void SpectrumVisualProcessor::setup(unsigned int fftSize_in) {
-    busy_run.lock();
+
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
 
     fftSize = fftSize_in;
     fftSizeInternal = fftSize_in * SPECTRUM_VZM;
@@ -190,7 +197,6 @@ void SpectrumVisualProcessor::setup(unsigned int fftSize_in) {
     fftPlan = fft_create_plan(fftSizeInternal, fftInput, fftOutput, LIQUID_FFT_FORWARD, 0);
 #endif
     
-    busy_run.unlock();
 }
 
 void SpectrumVisualProcessor::setFFTSize(unsigned int fftSize_in) {
@@ -235,8 +241,15 @@ void SpectrumVisualProcessor::process() {
         return;
     }
 
-    iqData->busy_rw.lock();
-    busy_run.lock();
+   
+    //Start by locking concurrent access to iqData
+    std::lock_guard < std::recursive_mutex > lock(iqData->getMonitor());
+
+    //then get the busy_lock
+    std::lock_guard < std::mutex > busy_lock(busy_run);    
+
+
+   
     bool doPeak = peakHold.load() && (peakReset.load() == 0);
     
     if (fft_result.size() != fftSizeInternal) {
@@ -275,8 +288,7 @@ void SpectrumVisualProcessor::process() {
         if (is_view.load()) {
             if (!iqData->frequency || !iqData->sampleRate) {
                 iqData->decRefCount();
-                iqData->busy_rw.unlock();
-                busy_run.unlock();
+               
                 return;
             }
             
@@ -706,8 +718,7 @@ void SpectrumVisualProcessor::process() {
     }
  
     iqData->decRefCount();
-    iqData->busy_rw.unlock();
-    busy_run.unlock();
+   
     
     lastView = is_view.load();
 }

src/process/SpectrumVisualProcessor.h

@@ -97,6 +97,7 @@ private:
     std::vector<liquid_float_complex> shiftBuffer;
     std::vector<liquid_float_complex> resampleBuffer;
     std::atomic_int desiredInputSize;
+   
     std::mutex busy_run;
     std::atomic_bool hideDC, peakHold;
     std::atomic_int peakReset;

src/process/VisualProcessor.h

@@ -13,10 +13,14 @@ public:
 	}
     
     bool isInputEmpty() {
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
+
         return input->empty();
     }
     
     bool isOutputEmpty() {
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
+
         for (outputs_i = outputs.begin(); outputs_i != outputs.end(); outputs_i++) {
             if ((*outputs_i)->full()) {
                 return false;
@@ -26,6 +30,8 @@ public:
     }
     
     bool isAnyOutputEmpty() {
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
+
         for (outputs_i = outputs.begin(); outputs_i != outputs.end(); outputs_i++) {
             if (!(*outputs_i)->full()) {
                 return true;
@@ -35,34 +41,37 @@ public:
     }
 
     void setInput(ThreadQueue<InputDataType *> *vis_in) {
-        busy_update.lock();
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
         input = vis_in;
-        busy_update.unlock();
+        
     }
     
     void attachOutput(ThreadQueue<OutputDataType *> *vis_out) {
         // attach an output queue
-        busy_update.lock();
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
         outputs.push_back(vis_out);
-        busy_update.unlock();
+       
     }
     
     void removeOutput(ThreadQueue<OutputDataType *> *vis_out) {
         // remove an output queue
-        busy_update.lock();
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
+
         typename std::vector<ThreadQueue<OutputDataType *> *>::iterator i = std::find(outputs.begin(), outputs.end(), vis_out);
         if (i != outputs.end()) {
             outputs.erase(i);
         }
-        busy_update.unlock();
+      
     }
     
     void run() {
-        busy_update.lock();
+        
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
+
         if (input && !input->empty()) {
             process();
         }
-        busy_update.unlock();
+       
     }
     
 protected:
@@ -73,6 +82,8 @@ protected:
 
     void distribute(OutputDataType *output) {
         // distribute outputs
+        std::lock_guard < std::recursive_mutex > busy_lock(busy_update);
+
         output->setRefCount(outputs.size());
         for (outputs_i = outputs.begin(); outputs_i != outputs.end(); outputs_i++) {
         	if ((*outputs_i)->full()) {
@@ -86,7 +97,9 @@ protected:
     ThreadQueue<InputDataType *> *input;
     std::vector<ThreadQueue<OutputDataType *> *> outputs;
 	typename std::vector<ThreadQueue<OutputDataType *> *>::iterator outputs_i;
-    std::mutex busy_update;
+
+    //protects input and outputs, must be recursive because ao reentrance
+    std::recursive_mutex busy_update;
 };
 
 

src/sdr/SDRPostThread.cpp

@@ -27,9 +27,12 @@ SDRPostThread::~SDRPostThread() {
 }
 
 void SDRPostThread::bindDemodulator(DemodulatorInstance *demod) {
+    
     std::lock_guard < std::mutex > lock(busy_demod);
+
     demodulators.push_back(demod);
     doRefresh.store(true);
+   
 }
 
 void SDRPostThread::bindDemodulators(std::vector<DemodulatorInstance *> *demods) {
@@ -37,10 +40,12 @@ void SDRPostThread::bindDemodulators(std::vector<DemodulatorInstance *> *demods)
         return;
     }
     std::lock_guard < std::mutex > lock(busy_demod);
+
     for (std::vector<DemodulatorInstance *>::iterator di = demods->begin(); di != demods->end(); di++) {
         demodulators.push_back(*di);
         doRefresh.store(true);
     }
+   
 }
 
 void SDRPostThread::removeDemodulator(DemodulatorInstance *demod) {
@@ -49,12 +54,14 @@ void SDRPostThread::removeDemodulator(DemodulatorInstance *demod) {
     }
 
     std::lock_guard < std::mutex > lock(busy_demod);
+
     std::vector<DemodulatorInstance *>::iterator i = std::find(demodulators.begin(), demodulators.end(), demod);
     
     if (i != demodulators.end()) {
         demodulators.erase(i);
         doRefresh.store(true);
     }
+  
 }
 
 void SDRPostThread::initPFBChannelizer() {

src/sdr/SDRPostThread.h

@@ -29,10 +29,14 @@ protected:
     DemodulatorThreadInputQueue *iqVisualQueue;
     DemodulatorThreadInputQueue *iqActiveDemodVisualQueue;
     
+    //protects access to demodulators lists and such
     std::mutex busy_demod;
     std::vector<DemodulatorInstance *> demodulators;
 
+    
+
 private:
+
     void initPFBChannelizer();
     void updateActiveDemodulators();
     void updateChannels();

src/sdr/SoapySDRThread.cpp

@@ -126,7 +126,9 @@ void SDRThread::init() {
         settingChanged.erase(settingChanged.begin(), settingChanged.end());
     }
     
-    setting_busy.lock();
+    { //enter scoped-lock
+        std::lock_guard < std::mutex > lock(setting_busy);
+
         for (settings_i = settingsInfo.begin(); settings_i != settingsInfo.end(); settings_i++) {
             SoapySDR::ArgInfo setting = (*settings_i);
             if ((settingChanged.find(setting.key) != settingChanged.end()) && (settings.find(setting.key) != settings.end())) {
@@ -139,7 +141,7 @@ void SDRThread::init() {
         }
         setting_value_changed.store(false);
 
-    setting_busy.unlock();
+    } //leave lock guard scope
     
     updateSettings();
     
@@ -316,21 +318,22 @@ void SDRThread::updateSettings() {
     }
     
     if (gain_value_changed.load() && !agc_mode.load()) {
-        gain_busy.lock();
+        std::lock_guard < std::mutex > lock(gain_busy); 
+
         for (std::map<std::string,bool>::iterator gci = gainChanged.begin(); gci != gainChanged.end(); gci++) {
             if (gci->second) {
                 device->setGain(SOAPY_SDR_RX, 0, gci->first, gainValues[gci->first]);
                 gainChanged[gci->first] = false;
             }
         }
-        gain_busy.unlock();
         
         gain_value_changed.store(false);
     }
     
     
     if (setting_value_changed.load()) {
-        setting_busy.lock();
+
+        std::lock_guard < std::mutex > lock(setting_busy);
         
         for (std::map<std::string, bool>::iterator sci = settingChanged.begin(); sci != settingChanged.end(); sci++) {
             if (sci->second) {
@@ -340,7 +343,6 @@ void SDRThread::updateSettings() {
         }
         
         setting_value_changed.store(false);
-        setting_busy.unlock();
         
         doUpdate = true;
     }
@@ -511,11 +513,10 @@ bool SDRThread::getIQSwap() {
 }
 
 void SDRThread::setGain(std::string name, float value) {
-    gain_busy.lock();
+    std::lock_guard < std::mutex > lock(gain_busy);
     gainValues[name] = value;
     gainChanged[name] = true;
     gain_value_changed.store(true);
-    gain_busy.unlock();
     
     DeviceConfig *devConfig = deviceConfig.load();
     if (devConfig) {
@@ -524,28 +525,30 @@ void SDRThread::setGain(std::string name, float value) {
 }
 
 float SDRThread::getGain(std::string name) {
-	gain_busy.lock();
+    std::lock_guard < std::mutex > lock(gain_busy);
 	float val = gainValues[name];
-	gain_busy.unlock();
+	
 	return val;
 }
 
 void SDRThread::writeSetting(std::string name, std::string value) {
-    setting_busy.lock();
+
+    std::lock_guard < std::mutex > lock(setting_busy);
+
     settings[name] = value;
     settingChanged[name] = true;
     setting_value_changed.store(true);
     if (deviceConfig.load() != nullptr) {
         deviceConfig.load()->setSetting(name, value);
     }
-    setting_busy.unlock();
 }
 
 std::string SDRThread::readSetting(std::string name) {
     std::string val;
-    setting_busy.lock();
+    std::lock_guard < std::mutex > lock(setting_busy);
+
     val = device->readSetting(name);
-    setting_busy.unlock();
+   
     return val;
 }
 

src/visual/WaterfallCanvas.cpp

@@ -83,7 +83,7 @@ void WaterfallCanvas::attachSpectrumCanvas(SpectrumCanvas *canvas_in) {
 }
 
 void WaterfallCanvas::processInputQueue() {
-    tex_update.lock();
+    std::lock_guard < std::mutex > lock(tex_update);
     
     gTimer.update();
     
@@ -118,11 +118,11 @@ void WaterfallCanvas::processInputQueue() {
         glContext->SetCurrent(*this);
         waterfallPanel.update();
     }
-    tex_update.unlock();
+   
 }
 
 void WaterfallCanvas::OnPaint(wxPaintEvent& WXUNUSED(event)) {
-    tex_update.lock();
+    std::lock_guard < std::mutex > lock(tex_update);
     wxPaintDC dc(this);
     
     const wxSize ClientSize = GetClientSize();
@@ -341,7 +341,6 @@ void WaterfallCanvas::OnPaint(wxPaintEvent& WXUNUSED(event)) {
     glContext->EndDraw();
 
     SwapBuffers();
-    tex_update.unlock();
 }
 
 void WaterfallCanvas::OnKeyUp(wxKeyEvent& event) {
@@ -905,7 +904,7 @@ void WaterfallCanvas::updateCenterFrequency(long long freq) {
 }
 
 void WaterfallCanvas::setLinesPerSecond(int lps) {
-    tex_update.lock();
+    std::lock_guard < std::mutex > lock(tex_update);
     linesPerSecond = lps;
     while (!visualDataQueue.empty()) {
         SpectrumVisualData *vData;
@@ -915,7 +914,6 @@ void WaterfallCanvas::setLinesPerSecond(int lps) {
             vData->decRefCount();
         }
     }
-    tex_update.unlock();
 }
 
 void WaterfallCanvas::setMinBandwidth(int min) {