donjohanliebert/hardware_xiaomi
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

power: Ignore system hint sessions for universal boost

Browse Source 
Currently PowerHAL does not distinguish between system processes and
apps when deciding whether to apply universal boost. This patch
distinguishes system sessions and app sessions and ignores system ones,
making the disabling of universal boost dependent on the presence of app
hint sessions.

Bug: b/230511824
Test: manual
Change-Id: I08dea29b3a45f2ba69ed99a9f188fa83ba143423
This commit is contained in:
Matt Buckley 2022-04-29 21:05:38 +00:00 committed by Bruno Martins
parent 295d5f53ed
commit 895962ed16
4 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
aidl/power-libperfmgr/PowerHintSession.cpp
View File

@ -24,6 +24,7 @@
#include <android-base/properties.h>
#include <android-base/stringprintf.h>
#include <perfmgr/AdpfConfig.h>
#include <private/android_filesystem_config.h>
#include <sys/syscall.h>
#include <time.h>
#include <utils/Trace.h>
@ -183,7 +184,15 @@ std::string PowerHintSession::getIdString() const {
return idstr;
}
bool PowerHintSession::isAppSession() {
// Check if uid is in range reserved for applications
return mDescriptor->uid >= AID_APP_START;
}
void PowerHintSession::updateUniveralBoostMode() {
if (!isAppSession()) {
return;
}
if (ATRACE_ENABLED()) {
const std::string tag = StringPrintf("%s:updateUniveralBoostMode()", getIdString().c_str());
ATRACE_BEGIN(tag.c_str());

2
aidl/power-libperfmgr/PowerHintSession.h
View File

@ -87,6 +87,8 @@ class PowerHintSession : public BnPowerHintSession {
const std::vector<WorkDuration> &actualDurations) override;
bool isActive();
bool isStale();
// Is this hint session for a user application
bool isAppSession();
const std::vector<int> &getTidList() const;
int restoreUclamp();

6
aidl/power-libperfmgr/PowerSessionManager.cpp
View File

@ -91,12 +91,12 @@ void PowerSessionManager::removePowerSession(PowerHintSession *session) {
mSessions.erase(session);
}
std::optional<bool> PowerSessionManager::isAnySessionActive() {
std::optional<bool> PowerSessionManager::isAnyAppSessionActive() {
std::lock_guard<std::mutex> guard(mLock);
bool active = false;
for (PowerHintSession *s : mSessions) {
// session active and not stale is actually active.
if (s->isActive() && !s->isStale()) {
if (s->isActive() && !s->isStale() && s->isAppSession()) {
active = true;
break;
}
@ -111,7 +111,7 @@ std::optional<bool> PowerSessionManager::isAnySessionActive() {
}
void PowerSessionManager::handleMessage(const Message &) {
auto active = isAnySessionActive();
auto active = isAnyAppSessionActive();
if (!active.has_value()) {
return;
}

2
aidl/power-libperfmgr/PowerSessionManager.h
View File

@ -59,7 +59,7 @@ class PowerSessionManager : public MessageHandler {
}
private:
std::optional<bool> isAnySessionActive();
std::optional<bool> isAnyAppSessionActive();
void disableSystemTopAppBoost();
void enableSystemTopAppBoost();
const std::string kDisableBoostHintName;