From 4ea9e33e202d9d1a5f12dc57efe2476d5583cf37 Mon Sep 17 00:00:00 2001 From: "Walter A. Boring IV" Date: Fri, 28 Aug 2026 12:10:50 -0400 Subject: [PATCH] fix: APRSISDriver.is_configured() returns False when driver is disabled (#236) The final `return True` in is_configured() should be `return False`. When APRS-IS is not enabled, the method always returned True, so the startup guard in server.py never fired for misconfigured instances. Closes #2 --- ChangeLog.md | 2 ++ aprsd/client/drivers/aprsis.py | 2 +- tests/client/drivers/test_aprsis_driver.py | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index 20ac03f..cbea7e4 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -8,6 +8,8 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). ##### Bug Fixes +- Fix APRSISDriver.is_configured() always returning True when driver is disabled [`a9ef65f`](https://github.com/craigerl/aprsd/commit/a9ef65f) + - Fix PacketList.tx() docstring: "received" → "transmitted" [`2e3d556`](https://github.com/craigerl/aprsd/commit/2e3d556) - Add aprsd/~/ to .gitignore; remove stale tilde directory from repo [`1b08e1c`](https://github.com/craigerl/aprsd/commit/1b08e1c) diff --git a/aprsd/client/drivers/aprsis.py b/aprsd/client/drivers/aprsis.py index 37a1898..8f2d2fd 100644 --- a/aprsd/client/drivers/aprsis.py +++ b/aprsd/client/drivers/aprsis.py @@ -73,7 +73,7 @@ class APRSISDriver: ) return True - return True + return False @property def is_alive(self): diff --git a/tests/client/drivers/test_aprsis_driver.py b/tests/client/drivers/test_aprsis_driver.py index bf5b420..358eb7b 100644 --- a/tests/client/drivers/test_aprsis_driver.py +++ b/tests/client/drivers/test_aprsis_driver.py @@ -162,9 +162,9 @@ class TestAPRSISDriver(unittest.TestCase): APRSISDriver.is_configured() def test_is_configured_disabled(self): - """Test is_configured returns True when not enabled.""" + """Test is_configured returns False when not enabled.""" with mock.patch.object(APRSISDriver, 'is_enabled', return_value=False): - self.assertTrue(APRSISDriver.is_configured()) + self.assertFalse(APRSISDriver.is_configured()) def test_is_alive_no_client(self): """Test is_alive returns False when no client."""