From 7ba36f043f775419cf41898b806f5bb0f23d9ec0 Mon Sep 17 00:00:00 2001 From: Daniel Mentz Date: Tue, 16 Oct 2018 11:17:47 -0700 Subject: [PATCH] sm8350-common: Remove ineffective BOARD_KERNEL_TAGS_OFFSET variable Remove various variables related to where kernel and ramdisk are loaded by the bootloader. There are two reasons for this: 1. Our bootloader ignores all the offset values for kernel, ramdisk and tags. 2. The variables BOARD_KERNEL_TAGS_OFFSET and BOARD_RAMDISK_OFFSET are ignored by the Android build system (unless they are copied into the BOARD_MKBOOTIMG_ARGS variable). This is in contrast to the variables BOARD_KERNEL_BASE, BOARD_KERNEL_PAGESIZE and BOARD_MKBOOTIMG_ARGS which are referenced by build/make/core/Makefile Bug: 117832711 Change-Id: I3404a4e084ed063d51077a3a80229854362c768b --- BoardConfigCommon.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/BoardConfigCommon.mk b/BoardConfigCommon.mk index d0ed5cc..aa0e755 100644 --- a/BoardConfigCommon.mk +++ b/BoardConfigCommon.mk @@ -86,8 +86,6 @@ BOARD_KERNEL_BASE := 0x00000000 BOARD_KERNEL_IMAGE_NAME := Image BOARD_KERNEL_PAGESIZE := 4096 BOARD_KERNEL_SEPARATED_DTBO := true -BOARD_KERNEL_TAGS_OFFSET := 0x00000100 -BOARD_RAMDISK_OFFSET := 0x01000000 BOARD_BOOT_HEADER_VERSION := 3 BOARD_MKBOOTIMG_ARGS += --header_version $(BOARD_BOOT_HEADER_VERSION)