Commit Graph

16 Commits

Author SHA1 Message Date
Madhanraj Chelladurai
a20d1da042 sm8350-common: gps: Add NULL check before object access
Correct the NULL check code block and add NULL check before
object access.

Change-Id: Ic41b781b41fb4e21bbff8801d500a41a6d7219d0
CRs-fixed: 3084543
2023-10-28 23:54:17 +08:00
me-cafebabe
f09da84023 sm8350-common: gps: Fix compilation on U
Change-Id: I7ca7e78addd6385289b8449edae8b682839ecc91
2023-10-28 23:46:39 +08:00
Michael Bestas
3017c2408c sm8350-common: Implement xtra-daemon control via property
Default to false if the property is not set.
Device init scripts will need to be adapted to restart
loc_launcher service when property change is detected.

Change-Id: Icbda789cd2a9a3391f437af2c07fc5127f2f09ab
2023-08-21 13:04:53 +00:00
Michael Bestas
a82c5a3af1 sm8350-common: gps: Remove all Wno-error flags
Almost all warnings/errors have been fixed.
Ignore undefined bool conversion error on purpose.

Change-Id: I00cb5f38711fa9f873da030fc6a0ebc6cde3ceeb
2023-08-21 13:04:53 +00:00
Albert I
77d363cd53 sm8350-common: gps: Implement list empty error code for msg_q
This fixes enum-conversion warning due to implicit type enum casting
between linked_list and msg_q which happens only for status -6.

Change-Id: I27ba74c4d840b7ba0cb1017d69a30fc25b80d6b9
2023-08-21 13:04:53 +00:00
Albert I
356462e0b6 sm8350-common: gps: Address logical-op-parentheses warning
Change-Id: I45d621a2b995afeb7757df3f89614a0d95552f33
2023-08-21 13:04:53 +00:00
Albert I
e05f48f56c sm8350-common: gps: Reorder initializations list to satisfy warnings
-Wreorder-ctor is a compile-time, Clang-only flag which is enabled by
default since Clang 12, which will warn whenever a specified field will
be initialized right after field specified below it. However, since it
doesn't sweep through all fields, compiler may miss some of them.

This order has been checked thoroughly through many trial and errors to
ensure that no such warns will be triggered anymore.

Change-Id: Id24cbb7277dc8d6c02767f8f365818ab6c017683
2023-08-21 13:04:53 +00:00
Michael Bestas
c3b3bc2886 sm8350-common: gps: Resolve unused parameter warnings
Change-Id: I0acef3da2c3567a28edd0a71dac89a5828f7725d
2023-08-21 13:04:53 +00:00
Pirama Arumuga Nainar
886c8c28e4 sm8350-common: gps: Fix -Wbitwise-instead-of-logical
Bug: http://b/215753485

Reported by clang-r445002

error: use of bitwise '|' with boolean operands [-Werro
r,-Wbitwise-instead-of-logical]

  if (gnssCbIface != nullptr || gnssCbIface_2_0 != nullptr| gnssCbIface_2_1 != nullptr) {
                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                          ||

Test: build with clang-r445002
Change-Id: I9410eb5208227dd70bd036aee02fb2aeb912f266
Merged-In: I9410eb5208227dd70bd036aee02fb2aeb912f266
2023-04-16 17:37:35 +02:00
Giovanni Ricca
3c565193f5 sm8350-common: gps: Revert oem changes
Change-Id: Ia13ce8d80233a493aa90723a1e974871ddce641b
2022-09-26 17:12:40 +02:00
Giovanni Ricca
467b1af609 sm8350-common: gps: Update to LA.UM.9.14.r1-19200.02-LAHAINA.QSSI13.0
Change-Id: I467ece57b82127382f11e48d0dd80e362df0d1c9
2022-09-26 17:12:40 +02:00
Michael Bestas
19ff681784 sm8350-common: gps: Lower debug level
* Kill logcat spam

Change-Id: I20d1f698d3c2d1b56e79f6eb6c5c17069e43c60f
2022-04-02 00:06:07 +02:00
TheStrix
fd3b078743 sm8350-common: gps: Disable xtwifi location services
Squashed with:
Author: Michael Bestas <mkbestas@lineageos.org>
Date:   Fri Jan 15 22:14:25 2021 +0200

    sm8350-common: Remove unused gps certificates

    * They are used by xtwifi-inet-agent which we disabled.

    Change-Id: I4fbf6e02276b508a27f320e630ddad3c9aada5a8

Author: Arian <arian.kulmer@web.de>
Date:   Thu Apr 1 01:09:38 2021 +0200

    sm8350-common: Remove xtwfi-client and xtwifi-inet-agent

    Change-Id: I232fd3b351f0e47b86f7d5d7b2a2bd0f28712d64

Change-Id: I70f39d8d611167f65bb3912590b05f8a8d121c80
2022-04-02 00:06:02 +02:00
dianlujitao
eae8e1d90f sm8350-common: Fix non-ASCII character in gps.conf
:caf:

Change-Id: Iea9c44c0fbad574cbc077feea3d9f1de83d7d99a
2022-04-02 00:05:42 +02:00
Arian
8cf9c727e7 sm8350-common: Build GPS HAL from source and import proprietary configs
Configs from odin V12.5.12.0.RKMCNXM
slim_daemon is disabled in izat.conf, hence drop it.

Change-Id: Ia1ed33f6250b898d149970389befe8033cc8eaf3
2022-04-02 00:05:33 +02:00
Arian
75da4c0eee sm8350-common: Import gps hal from LA.UM.9.14.r1-16700-LAHAINA.0
Change-Id: I134d6418f1357a4d7ce37358481d6b765d93e1a5
2022-04-02 00:03:09 +02:00