2005-04-16 18:20:36 -04:00
|
|
|
/*
|
2007-10-18 18:30:08 -04:00
|
|
|
* linux/drivers/ide/pci/piix.c Version 0.54 Sep 5, 2007
|
2005-04-16 18:20:36 -04:00
|
|
|
*
|
|
|
|
* Copyright (C) 1998-1999 Andrzej Krzysztofowicz, Author and Maintainer
|
|
|
|
* Copyright (C) 1998-2000 Andre Hedrick <andre@linux-ide.org>
|
|
|
|
* Copyright (C) 2003 Red Hat Inc <alan@redhat.com>
|
2007-03-03 11:48:53 -05:00
|
|
|
* Copyright (C) 2006-2007 MontaVista Software, Inc. <source@mvista.com>
|
2005-04-16 18:20:36 -04:00
|
|
|
*
|
|
|
|
* May be copied or modified under the terms of the GNU General Public License
|
|
|
|
*
|
2006-12-29 19:49:26 -05:00
|
|
|
* PIO mode setting function for Intel chipsets.
|
2005-04-16 18:20:36 -04:00
|
|
|
* For use instead of BIOS settings.
|
|
|
|
*
|
|
|
|
* 40-41
|
|
|
|
* 42-43
|
|
|
|
*
|
|
|
|
* 41
|
|
|
|
* 43
|
|
|
|
*
|
2007-10-11 17:54:00 -04:00
|
|
|
* | PIO 0 | c0 | 80 | 0 |
|
|
|
|
* | PIO 2 | SW2 | d0 | 90 | 4 |
|
|
|
|
* | PIO 3 | MW1 | e1 | a1 | 9 |
|
|
|
|
* | PIO 4 | MW2 | e3 | a3 | b |
|
|
|
|
*
|
2005-04-16 18:20:36 -04:00
|
|
|
* sitre = word40 & 0x4000; primary
|
|
|
|
* sitre = word42 & 0x4000; secondary
|
|
|
|
*
|
|
|
|
* 44 8421|8421 hdd|hdb
|
2006-12-29 19:49:26 -05:00
|
|
|
*
|
2005-04-16 18:20:36 -04:00
|
|
|
* 48 8421 hdd|hdc|hdb|hda udma enabled
|
|
|
|
*
|
|
|
|
* 0001 hda
|
|
|
|
* 0010 hdb
|
|
|
|
* 0100 hdc
|
|
|
|
* 1000 hdd
|
|
|
|
*
|
|
|
|
* 4a 84|21 hdb|hda
|
|
|
|
* 4b 84|21 hdd|hdc
|
|
|
|
*
|
|
|
|
* ata-33/82371AB
|
|
|
|
* ata-33/82371EB
|
|
|
|
* ata-33/82801AB ata-66/82801AA
|
|
|
|
* 00|00 udma 0 00|00 reserved
|
|
|
|
* 01|01 udma 1 01|01 udma 3
|
|
|
|
* 10|10 udma 2 10|10 udma 4
|
|
|
|
* 11|11 reserved 11|11 reserved
|
|
|
|
*
|
|
|
|
* 54 8421|8421 ata66 drive|ata66 enable
|
|
|
|
*
|
|
|
|
* pci_read_config_word(HWIF(drive)->pci_dev, 0x40, ®40);
|
|
|
|
* pci_read_config_word(HWIF(drive)->pci_dev, 0x42, ®42);
|
|
|
|
* pci_read_config_word(HWIF(drive)->pci_dev, 0x44, ®44);
|
|
|
|
* pci_read_config_byte(HWIF(drive)->pci_dev, 0x48, ®48);
|
|
|
|
* pci_read_config_word(HWIF(drive)->pci_dev, 0x4a, ®4a);
|
|
|
|
* pci_read_config_byte(HWIF(drive)->pci_dev, 0x54, ®54);
|
|
|
|
*
|
|
|
|
* Documentation
|
|
|
|
* Publically available from Intel web site. Errata documentation
|
|
|
|
* is also publically available. As an aide to anyone hacking on this
|
|
|
|
* driver the list of errata that are relevant is below.going back to
|
|
|
|
* PIIX4. Older device documentation is now a bit tricky to find.
|
|
|
|
*
|
|
|
|
* Errata of note:
|
|
|
|
*
|
|
|
|
* Unfixable
|
|
|
|
* PIIX4 errata #9 - Only on ultra obscure hw
|
|
|
|
* ICH3 errata #13 - Not observed to affect real hw
|
|
|
|
* by Intel
|
|
|
|
*
|
|
|
|
* Things we must deal with
|
|
|
|
* PIIX4 errata #10 - BM IDE hang with non UDMA
|
|
|
|
* (must stop/start dma to recover)
|
|
|
|
* 440MX errata #15 - As PIIX4 errata #10
|
|
|
|
* PIIX4 errata #15 - Must not read control registers
|
|
|
|
* during a PIO transfer
|
|
|
|
* 440MX errata #13 - As PIIX4 errata #15
|
|
|
|
* ICH2 errata #21 - DMA mode 0 doesn't work right
|
|
|
|
* ICH0/1 errata #55 - As ICH2 errata #21
|
|
|
|
* ICH2 spec c #9 - Extra operations needed to handle
|
|
|
|
* drive hotswap [NOT YET SUPPORTED]
|
|
|
|
* ICH2 spec c #20 - IDE PRD must not cross a 64K boundary
|
|
|
|
* and must be dword aligned
|
|
|
|
* ICH2 spec c #24 - UDMA mode 4,5 t85/86 should be 6ns not 3.3
|
|
|
|
*
|
|
|
|
* Should have been BIOS fixed:
|
|
|
|
* 450NX: errata #19 - DMA hangs on old 450NX
|
|
|
|
* 450NX: errata #20 - DMA hangs on old 450NX
|
|
|
|
* 450NX: errata #25 - Corruption with DMA on old 450NX
|
|
|
|
* ICH3 errata #15 - IDE deadlock under high load
|
|
|
|
* (BIOS must set dev 31 fn 0 bit 23)
|
|
|
|
* ICH3 errata #18 - Don't use native mode
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/ioport.h>
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/hdreg.h>
|
|
|
|
#include <linux/ide.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
|
|
|
|
#include <asm/io.h>
|
|
|
|
|
|
|
|
static int no_piix_dma;
|
|
|
|
|
|
|
|
/**
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
* piix_set_pio_mode - set host controller for PIO mode
|
|
|
|
* @drive: drive
|
|
|
|
* @pio: PIO mode number
|
2005-04-16 18:20:36 -04:00
|
|
|
*
|
2007-03-03 11:48:53 -05:00
|
|
|
* Set the interface PIO mode based upon the settings done by AMI BIOS.
|
2005-04-16 18:20:36 -04:00
|
|
|
*/
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
|
|
|
|
static void piix_set_pio_mode(ide_drive_t *drive, const u8 pio)
|
2005-04-16 18:20:36 -04:00
|
|
|
{
|
|
|
|
ide_hwif_t *hwif = HWIF(drive);
|
|
|
|
struct pci_dev *dev = hwif->pci_dev;
|
2007-02-07 12:18:28 -05:00
|
|
|
int is_slave = drive->dn & 1;
|
2005-04-16 18:20:36 -04:00
|
|
|
int master_port = hwif->channel ? 0x42 : 0x40;
|
|
|
|
int slave_port = 0x44;
|
|
|
|
unsigned long flags;
|
|
|
|
u16 master_data;
|
|
|
|
u8 slave_data;
|
2006-06-26 03:26:12 -04:00
|
|
|
static DEFINE_SPINLOCK(tune_lock);
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
int control = 0;
|
2006-06-26 03:26:12 -04:00
|
|
|
|
2007-02-07 12:18:28 -05:00
|
|
|
/* ISP RTC */
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
static const u8 timings[][2]= {
|
|
|
|
{ 0, 0 },
|
|
|
|
{ 0, 0 },
|
|
|
|
{ 1, 0 },
|
|
|
|
{ 2, 1 },
|
|
|
|
{ 2, 3 }, };
|
2005-04-16 18:20:36 -04:00
|
|
|
|
2006-06-26 03:26:12 -04:00
|
|
|
/*
|
|
|
|
* Master vs slave is synchronized above us but the slave register is
|
|
|
|
* shared by the two hwifs so the corner case of two slave timeouts in
|
|
|
|
* parallel must be locked.
|
|
|
|
*/
|
|
|
|
spin_lock_irqsave(&tune_lock, flags);
|
2005-04-16 18:20:36 -04:00
|
|
|
pci_read_config_word(dev, master_port, &master_data);
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
|
2007-02-07 12:18:28 -05:00
|
|
|
if (pio > 1)
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
control |= 1; /* Programmable timing on */
|
|
|
|
if (drive->media == ide_disk)
|
|
|
|
control |= 4; /* Prefetch, post write */
|
2007-02-07 12:18:28 -05:00
|
|
|
if (pio > 2)
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
control |= 2; /* IORDY */
|
2005-04-16 18:20:36 -04:00
|
|
|
if (is_slave) {
|
2007-02-07 12:18:28 -05:00
|
|
|
master_data |= 0x4000;
|
|
|
|
master_data &= ~0x0070;
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
if (pio > 1) {
|
2007-03-03 11:48:53 -05:00
|
|
|
/* Set PPE, IE and TIME */
|
|
|
|
master_data |= control << 4;
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
}
|
2005-04-16 18:20:36 -04:00
|
|
|
pci_read_config_byte(dev, slave_port, &slave_data);
|
2007-03-03 11:48:53 -05:00
|
|
|
slave_data &= hwif->channel ? 0x0f : 0xf0;
|
|
|
|
slave_data |= ((timings[pio][0] << 2) | timings[pio][1]) <<
|
|
|
|
(hwif->channel ? 4 : 0);
|
2005-04-16 18:20:36 -04:00
|
|
|
} else {
|
2007-02-07 12:18:28 -05:00
|
|
|
master_data &= ~0x3307;
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
if (pio > 1) {
|
2005-04-16 18:20:36 -04:00
|
|
|
/* enable PPE, IE and TIME */
|
2007-03-03 11:48:53 -05:00
|
|
|
master_data |= control;
|
[PATCH] ide: backport piix fixes from libata into the legacy driver
There are three flags being set by default by the PIIX driver for speeds >
PIO 1, and one not being cleared properly on fallback to PIO0. The most
important one is the prefetch/post write control which only works for ATA
and can do bad things with ATAPI.
The patch does its best to set the flags correctly for drivers/ide. Its
not 100% perfect but its closer than the original. 100% perfect requires
proper IORDY handling but this isn't critical (and its not right in libata
either .. yet)
Sergei Shtylyov <sshtylyov@ru.mvista.com> said:
> + { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
>
> pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
BTW, there's quite obvious error here which leads to access outside of
timings[] if somebody passes PIO mode 5 (or autotuning code finds out that
drive supports PIO mode 5). Could have been fixed while at it... Those drives
should be rare, though...
> + }
> master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
> }
> pci_write_config_word(dev, master_port, master_data);
Actually, there's one more serious issue with piix_tune_drive() -- it
doesn't actually set the drive's own transfer mode.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-03 04:14:23 -04:00
|
|
|
}
|
2007-03-03 11:48:53 -05:00
|
|
|
master_data |= (timings[pio][0] << 12) | (timings[pio][1] << 8);
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
pci_write_config_word(dev, master_port, master_data);
|
|
|
|
if (is_slave)
|
|
|
|
pci_write_config_byte(dev, slave_port, slave_data);
|
2006-06-26 03:26:12 -04:00
|
|
|
spin_unlock_irqrestore(&tune_lock, flags);
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
2007-03-03 11:48:53 -05:00
|
|
|
/**
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
* piix_set_dma_mode - set host controller for DMA mode
|
|
|
|
* @drive: drive
|
|
|
|
* @speed: DMA mode
|
2005-04-16 18:20:36 -04:00
|
|
|
*
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
* Set a PIIX host controller to the desired DMA mode. This involves
|
|
|
|
* programming the right timing data into the PCI configuration space.
|
2005-04-16 18:20:36 -04:00
|
|
|
*/
|
2007-10-11 17:53:59 -04:00
|
|
|
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
static void piix_set_dma_mode(ide_drive_t *drive, const u8 speed)
|
2005-04-16 18:20:36 -04:00
|
|
|
{
|
|
|
|
ide_hwif_t *hwif = HWIF(drive);
|
|
|
|
struct pci_dev *dev = hwif->pci_dev;
|
|
|
|
u8 maslave = hwif->channel ? 0x42 : 0x40;
|
|
|
|
int a_speed = 3 << (drive->dn * 4);
|
|
|
|
int u_flag = 1 << drive->dn;
|
|
|
|
int v_flag = 0x01 << drive->dn;
|
|
|
|
int w_flag = 0x10 << drive->dn;
|
|
|
|
int u_speed = 0;
|
|
|
|
int sitre;
|
|
|
|
u16 reg4042, reg4a;
|
2007-10-16 16:29:56 -04:00
|
|
|
u8 reg48, reg54, reg55;
|
2005-04-16 18:20:36 -04:00
|
|
|
|
|
|
|
pci_read_config_word(dev, maslave, ®4042);
|
|
|
|
sitre = (reg4042 & 0x4000) ? 1 : 0;
|
|
|
|
pci_read_config_byte(dev, 0x48, ®48);
|
|
|
|
pci_read_config_word(dev, 0x4a, ®4a);
|
|
|
|
pci_read_config_byte(dev, 0x54, ®54);
|
|
|
|
pci_read_config_byte(dev, 0x55, ®55);
|
|
|
|
|
|
|
|
switch(speed) {
|
|
|
|
case XFER_UDMA_4:
|
|
|
|
case XFER_UDMA_2: u_speed = 2 << (drive->dn * 4); break;
|
|
|
|
case XFER_UDMA_5:
|
|
|
|
case XFER_UDMA_3:
|
|
|
|
case XFER_UDMA_1: u_speed = 1 << (drive->dn * 4); break;
|
|
|
|
case XFER_UDMA_0: u_speed = 0 << (drive->dn * 4); break;
|
|
|
|
case XFER_MW_DMA_2:
|
|
|
|
case XFER_MW_DMA_1:
|
|
|
|
case XFER_SW_DMA_2: break;
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
default: return;
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
if (speed >= XFER_UDMA_0) {
|
|
|
|
if (!(reg48 & u_flag))
|
|
|
|
pci_write_config_byte(dev, 0x48, reg48 | u_flag);
|
|
|
|
if (speed == XFER_UDMA_5) {
|
|
|
|
pci_write_config_byte(dev, 0x55, (u8) reg55|w_flag);
|
|
|
|
} else {
|
|
|
|
pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag);
|
|
|
|
}
|
|
|
|
if ((reg4a & a_speed) != u_speed)
|
|
|
|
pci_write_config_word(dev, 0x4a, (reg4a & ~a_speed) | u_speed);
|
|
|
|
if (speed > XFER_UDMA_2) {
|
|
|
|
if (!(reg54 & v_flag))
|
|
|
|
pci_write_config_byte(dev, 0x54, reg54 | v_flag);
|
|
|
|
} else
|
|
|
|
pci_write_config_byte(dev, 0x54, reg54 & ~v_flag);
|
|
|
|
} else {
|
2007-10-16 16:29:54 -04:00
|
|
|
const u8 mwdma_to_pio[] = { 0, 3, 4 };
|
2007-10-16 16:29:56 -04:00
|
|
|
u8 pio;
|
2007-10-16 16:29:54 -04:00
|
|
|
|
2005-04-16 18:20:36 -04:00
|
|
|
if (reg48 & u_flag)
|
|
|
|
pci_write_config_byte(dev, 0x48, reg48 & ~u_flag);
|
|
|
|
if (reg4a & a_speed)
|
|
|
|
pci_write_config_word(dev, 0x4a, reg4a & ~a_speed);
|
|
|
|
if (reg54 & v_flag)
|
|
|
|
pci_write_config_byte(dev, 0x54, reg54 & ~v_flag);
|
|
|
|
if (reg55 & w_flag)
|
|
|
|
pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag);
|
2007-10-16 16:29:54 -04:00
|
|
|
|
|
|
|
if (speed >= XFER_MW_DMA_0)
|
|
|
|
pio = mwdma_to_pio[speed - XFER_MW_DMA_0];
|
|
|
|
else
|
|
|
|
pio = 2; /* only SWDMA2 is allowed */
|
2005-04-16 18:20:36 -04:00
|
|
|
|
2007-10-16 16:29:56 -04:00
|
|
|
piix_set_pio_mode(drive, pio);
|
|
|
|
}
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2007-10-18 18:30:10 -04:00
|
|
|
* init_chipset_ich - set up the ICH chipset
|
2007-02-16 20:40:21 -05:00
|
|
|
* @dev: PCI device to set up
|
|
|
|
* @name: Name of the device
|
|
|
|
*
|
2007-10-18 18:30:10 -04:00
|
|
|
* Initialize the PCI device as required. For the ICH this turns
|
|
|
|
* out to be nice and simple.
|
2007-02-16 20:40:21 -05:00
|
|
|
*/
|
|
|
|
|
2007-10-18 18:30:10 -04:00
|
|
|
static unsigned int __devinit init_chipset_ich(struct pci_dev *dev, const char *name)
|
2007-02-16 20:40:21 -05:00
|
|
|
{
|
2007-10-18 18:30:10 -04:00
|
|
|
u32 extra = 0;
|
|
|
|
|
|
|
|
pci_read_config_dword(dev, 0x54, &extra);
|
|
|
|
pci_write_config_dword(dev, 0x54, extra | 0x400);
|
2007-02-16 20:40:21 -05:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* piix_dma_clear_irq - clear BMDMA status
|
|
|
|
* @drive: IDE drive to clear
|
|
|
|
*
|
|
|
|
* Called from ide_intr() for PIO interrupts
|
|
|
|
* to clear BMDMA status as needed by ICHx
|
|
|
|
*/
|
|
|
|
static void piix_dma_clear_irq(ide_drive_t *drive)
|
|
|
|
{
|
|
|
|
ide_hwif_t *hwif = HWIF(drive);
|
|
|
|
u8 dma_stat;
|
|
|
|
|
|
|
|
/* clear the INTR & ERROR bits */
|
2007-10-18 18:30:08 -04:00
|
|
|
dma_stat = inb(hwif->dma_status);
|
2007-02-16 20:40:21 -05:00
|
|
|
/* Should we force the bit as well ? */
|
2007-10-18 18:30:08 -04:00
|
|
|
outb(dma_stat, hwif->dma_status);
|
2007-02-16 20:40:21 -05:00
|
|
|
}
|
|
|
|
|
2007-07-09 17:17:58 -04:00
|
|
|
struct ich_laptop {
|
|
|
|
u16 device;
|
|
|
|
u16 subvendor;
|
|
|
|
u16 subdevice;
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* List of laptops that use short cables rather than 80 wire
|
|
|
|
*/
|
|
|
|
|
|
|
|
static const struct ich_laptop ich_laptop[] = {
|
|
|
|
/* devid, subvendor, subdev */
|
|
|
|
{ 0x27DF, 0x0005, 0x0280 }, /* ICH7 on Acer 5602WLMi */
|
|
|
|
{ 0x27DF, 0x1025, 0x0110 }, /* ICH7 on Acer 3682WLMi */
|
|
|
|
{ 0x27DF, 0x1043, 0x1267 }, /* ICH7 on Asus W5F */
|
|
|
|
{ 0x24CA, 0x1025, 0x0061 }, /* ICH4 on Acer Aspire 2023WLMi */
|
|
|
|
/* end marker */
|
|
|
|
{ 0, }
|
|
|
|
};
|
|
|
|
|
2007-07-09 17:17:58 -04:00
|
|
|
static u8 __devinit piix_cable_detect(ide_hwif_t *hwif)
|
2007-02-16 20:40:23 -05:00
|
|
|
{
|
2007-07-09 17:17:58 -04:00
|
|
|
struct pci_dev *pdev = hwif->pci_dev;
|
|
|
|
const struct ich_laptop *lap = &ich_laptop[0];
|
2007-02-16 20:40:23 -05:00
|
|
|
u8 reg54h = 0, mask = hwif->channel ? 0xc0 : 0x30;
|
|
|
|
|
2007-07-09 17:17:58 -04:00
|
|
|
/* check for specials */
|
|
|
|
while (lap->device) {
|
|
|
|
if (lap->device == pdev->device &&
|
|
|
|
lap->subvendor == pdev->subsystem_vendor &&
|
|
|
|
lap->subdevice == pdev->subsystem_device) {
|
|
|
|
return ATA_CBL_PATA40_SHORT;
|
|
|
|
}
|
|
|
|
lap++;
|
|
|
|
}
|
|
|
|
|
|
|
|
pci_read_config_byte(pdev, 0x54, ®54h);
|
2007-02-16 20:40:23 -05:00
|
|
|
|
2007-07-09 17:17:58 -04:00
|
|
|
return (reg54h & mask) ? ATA_CBL_PATA80 : ATA_CBL_PATA40;
|
2007-02-16 20:40:23 -05:00
|
|
|
}
|
|
|
|
|
2005-04-16 18:20:36 -04:00
|
|
|
/**
|
|
|
|
* init_hwif_piix - fill in the hwif for the PIIX
|
|
|
|
* @hwif: IDE interface
|
|
|
|
*
|
|
|
|
* Set up the ide_hwif_t for the PIIX interface according to the
|
|
|
|
* capabilities of the hardware.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void __devinit init_hwif_piix(ide_hwif_t *hwif)
|
|
|
|
{
|
2007-10-11 17:54:00 -04:00
|
|
|
hwif->set_pio_mode = &piix_set_pio_mode;
|
ide: move ide_config_drive_speed() calls to upper layers (take 2)
* Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program
the host for the transfer mode after programming the device. Set it
in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
and via82cxxx host drivers.
* Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
skip programming of host/device for the transfer mode ("smart" hosts).
Set it in it821x host driver and check it in ide_tune_dma().
* Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
direct ->set_pio_mode/->speedproc users to use these helpers.
* Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
methods to callers.
* Rename ->speedproc method to ->set_dma_mode, make it void and update
all implementations accordingly.
* Update ide_set_xfer_rate() comments.
* Unexport ide_config_drive_speed().
v2:
* Fix issues noticed by Sergei:
- export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
to setting DMA modes from sc1200_set_pio_mode() to do_special()
- check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
- check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
- check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
- return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
- don't set ->set_{pio,dma}_mode on it821x in "smart" mode
- fix build problem in pmac.c
- minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
- improve patch description
Changes in behavior caused by this patch:
- HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
PIO mode if it821x controller is in "smart" mode
- removal of two debugging printk-s (from cs5530.c and sc1200.c)
- transfer modes 0x00-0x07 passed from user space may be programmed twice on
the device (not really an issue since 0x00 is not supported correctly by
any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2007-10-13 11:47:51 -04:00
|
|
|
hwif->set_dma_mode = &piix_set_dma_mode;
|
|
|
|
|
2005-04-16 18:20:36 -04:00
|
|
|
if (!hwif->dma_base)
|
|
|
|
return;
|
|
|
|
|
2007-05-09 18:01:07 -04:00
|
|
|
if (hwif->ultra_mask & 0x78) {
|
2007-07-09 17:17:58 -04:00
|
|
|
if (hwif->cbl != ATA_CBL_PATA40_SHORT)
|
|
|
|
hwif->cbl = piix_cable_detect(hwif);
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
2007-02-16 20:40:23 -05:00
|
|
|
if (no_piix_dma)
|
|
|
|
hwif->ultra_mask = hwif->mwdma_mask = hwif->swdma_mask = 0;
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
2007-10-18 18:30:10 -04:00
|
|
|
static void __devinit init_hwif_ich(ide_hwif_t *hwif)
|
|
|
|
{
|
|
|
|
init_hwif_piix(hwif);
|
|
|
|
|
|
|
|
/* ICHx need to clear the BMDMA status for all interrupts */
|
|
|
|
if (hwif->dma_base)
|
|
|
|
hwif->ide_dma_clear_irq = &piix_dma_clear_irq;
|
|
|
|
}
|
|
|
|
|
2007-10-18 18:30:11 -04:00
|
|
|
#ifndef CONFIG_IA64
|
|
|
|
#define IDE_HFLAGS_PIIX (IDE_HFLAG_LEGACY_IRQS | IDE_HFLAG_BOOTABLE)
|
|
|
|
#else
|
|
|
|
#define IDE_HFLAGS_PIIX IDE_HFLAG_BOOTABLE
|
|
|
|
#endif
|
|
|
|
|
2007-05-09 18:01:07 -04:00
|
|
|
#define DECLARE_PIIX_DEV(name_str, udma) \
|
2005-04-16 18:20:36 -04:00
|
|
|
{ \
|
|
|
|
.name = name_str, \
|
|
|
|
.init_hwif = init_hwif_piix, \
|
|
|
|
.enablebits = {{0x41,0x80,0x80}, {0x43,0x80,0x80}}, \
|
2007-10-18 18:30:11 -04:00
|
|
|
.host_flags = IDE_HFLAGS_PIIX, \
|
2007-07-19 19:11:59 -04:00
|
|
|
.pio_mask = ATA_PIO4, \
|
2007-10-18 18:30:07 -04:00
|
|
|
.swdma_mask = ATA_SWDMA2_ONLY, \
|
|
|
|
.mwdma_mask = ATA_MWDMA12_ONLY, \
|
2007-05-09 18:01:07 -04:00
|
|
|
.udma_mask = udma, \
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
2007-10-18 18:30:10 -04:00
|
|
|
#define DECLARE_ICH_DEV(name_str, udma) \
|
|
|
|
{ \
|
|
|
|
.name = name_str, \
|
|
|
|
.init_chipset = init_chipset_ich, \
|
|
|
|
.init_hwif = init_hwif_ich, \
|
|
|
|
.enablebits = {{0x41,0x80,0x80}, {0x43,0x80,0x80}}, \
|
2007-10-18 18:30:11 -04:00
|
|
|
.host_flags = IDE_HFLAGS_PIIX, \
|
2007-10-18 18:30:10 -04:00
|
|
|
.pio_mask = ATA_PIO4, \
|
|
|
|
.swdma_mask = ATA_SWDMA2_ONLY, \
|
|
|
|
.mwdma_mask = ATA_MWDMA12_ONLY, \
|
|
|
|
.udma_mask = udma, \
|
|
|
|
}
|
|
|
|
|
2007-10-19 18:32:34 -04:00
|
|
|
static const struct ide_port_info piix_pci_info[] __devinitdata = {
|
2007-10-18 18:30:07 -04:00
|
|
|
/* 0 */ DECLARE_PIIX_DEV("PIIXa", 0x00), /* no udma */
|
|
|
|
/* 1 */ DECLARE_PIIX_DEV("PIIXb", 0x00), /* no udma */
|
2005-04-16 18:20:36 -04:00
|
|
|
|
2007-02-07 12:18:25 -05:00
|
|
|
/* 2 */
|
|
|
|
{ /*
|
|
|
|
* MPIIX actually has only a single IDE channel mapped to
|
|
|
|
* the primary or secondary ports depending on the value
|
|
|
|
* of the bit 14 of the IDETIM register at offset 0x6c
|
|
|
|
*/
|
2005-04-16 18:20:36 -04:00
|
|
|
.name = "MPIIX",
|
2007-02-07 12:18:25 -05:00
|
|
|
.enablebits = {{0x6d,0xc0,0x80}, {0x6d,0xc0,0xc0}},
|
2007-10-18 18:30:06 -04:00
|
|
|
.host_flags = IDE_HFLAG_ISA_PORTS | IDE_HFLAG_NO_DMA |
|
2007-10-18 18:30:11 -04:00
|
|
|
IDE_HFLAGS_PIIX,
|
2007-07-19 19:11:59 -04:00
|
|
|
.pio_mask = ATA_PIO4,
|
2007-10-18 18:30:11 -04:00
|
|
|
/* This is a painful system best to let it self tune for now */
|
2005-04-16 18:20:36 -04:00
|
|
|
},
|
|
|
|
|
2007-10-18 18:30:07 -04:00
|
|
|
/* 3 */ DECLARE_PIIX_DEV("PIIX3", 0x00), /* no udma */
|
|
|
|
/* 4 */ DECLARE_PIIX_DEV("PIIX4", ATA_UDMA2),
|
2007-10-18 18:30:10 -04:00
|
|
|
/* 5 */ DECLARE_ICH_DEV("ICH0", ATA_UDMA2),
|
2007-10-18 18:30:07 -04:00
|
|
|
/* 6 */ DECLARE_PIIX_DEV("PIIX4", ATA_UDMA2),
|
2007-10-18 18:30:10 -04:00
|
|
|
/* 7 */ DECLARE_ICH_DEV("ICH", ATA_UDMA4),
|
2007-10-18 18:30:07 -04:00
|
|
|
/* 8 */ DECLARE_PIIX_DEV("PIIX4", ATA_UDMA4),
|
|
|
|
/* 9 */ DECLARE_PIIX_DEV("PIIX4", ATA_UDMA2),
|
2007-10-18 18:30:10 -04:00
|
|
|
/* 10 */ DECLARE_ICH_DEV("ICH2", ATA_UDMA5),
|
|
|
|
/* 11 */ DECLARE_ICH_DEV("ICH2M", ATA_UDMA5),
|
|
|
|
/* 12 */ DECLARE_ICH_DEV("ICH3M", ATA_UDMA5),
|
|
|
|
/* 13 */ DECLARE_ICH_DEV("ICH3", ATA_UDMA5),
|
|
|
|
/* 14 */ DECLARE_ICH_DEV("ICH4", ATA_UDMA5),
|
|
|
|
/* 15 */ DECLARE_ICH_DEV("ICH5", ATA_UDMA5),
|
|
|
|
/* 16 */ DECLARE_ICH_DEV("C-ICH", ATA_UDMA5),
|
|
|
|
/* 17 */ DECLARE_ICH_DEV("ICH4", ATA_UDMA5),
|
|
|
|
/* 18 */ DECLARE_ICH_DEV("ICH5-SATA", ATA_UDMA5),
|
|
|
|
/* 19 */ DECLARE_ICH_DEV("ICH5", ATA_UDMA5),
|
|
|
|
/* 20 */ DECLARE_ICH_DEV("ICH6", ATA_UDMA5),
|
|
|
|
/* 21 */ DECLARE_ICH_DEV("ICH7", ATA_UDMA5),
|
|
|
|
/* 22 */ DECLARE_ICH_DEV("ICH4", ATA_UDMA5),
|
|
|
|
/* 23 */ DECLARE_ICH_DEV("ESB2", ATA_UDMA5),
|
|
|
|
/* 24 */ DECLARE_ICH_DEV("ICH8M", ATA_UDMA5),
|
2005-04-16 18:20:36 -04:00
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* piix_init_one - called when a PIIX is found
|
|
|
|
* @dev: the piix device
|
|
|
|
* @id: the matching pci id
|
|
|
|
*
|
|
|
|
* Called when the PCI registration layer (or the IDE initialization)
|
|
|
|
* finds a device matching our IDE device tables.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int __devinit piix_init_one(struct pci_dev *dev, const struct pci_device_id *id)
|
|
|
|
{
|
2007-10-19 18:32:34 -04:00
|
|
|
return ide_setup_pci_device(dev, &piix_pci_info[id->driver_data]);
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* piix_check_450nx - Check for problem 450NX setup
|
|
|
|
*
|
|
|
|
* Check for the present of 450NX errata #19 and errata #25. If
|
|
|
|
* they are found, disable use of DMA IDE
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void __devinit piix_check_450nx(void)
|
|
|
|
{
|
|
|
|
struct pci_dev *pdev = NULL;
|
|
|
|
u16 cfg;
|
2006-10-01 02:27:28 -04:00
|
|
|
while((pdev=pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
|
2005-04-16 18:20:36 -04:00
|
|
|
{
|
|
|
|
/* Look for 450NX PXB. Check for problem configurations
|
|
|
|
A PCI quirk checks bit 6 already */
|
|
|
|
pci_read_config_word(pdev, 0x41, &cfg);
|
|
|
|
/* Only on the original revision: IDE DMA can hang */
|
2007-06-08 18:46:36 -04:00
|
|
|
if (pdev->revision == 0x00)
|
2005-04-16 18:20:36 -04:00
|
|
|
no_piix_dma = 1;
|
|
|
|
/* On all revisions below 5 PXB bus lock must be disabled for IDE */
|
2007-06-08 18:46:36 -04:00
|
|
|
else if (cfg & (1<<14) && pdev->revision < 5)
|
2005-04-16 18:20:36 -04:00
|
|
|
no_piix_dma = 2;
|
|
|
|
}
|
|
|
|
if(no_piix_dma)
|
|
|
|
printk(KERN_WARNING "piix: 450NX errata present, disabling IDE DMA.\n");
|
|
|
|
if(no_piix_dma == 2)
|
|
|
|
printk(KERN_WARNING "piix: A BIOS update may resolve this.\n");
|
|
|
|
}
|
|
|
|
|
2007-10-16 16:29:56 -04:00
|
|
|
static const struct pci_device_id piix_pci_tbl[] = {
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82371FB_0), 0 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82371FB_1), 1 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82371MX), 2 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82371SB_1), 3 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82371AB), 4 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801AB_1), 5 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82443MX_1), 6 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801AA_1), 7 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82372FB_1), 8 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82451NX), 9 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801BA_9), 10 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801BA_8), 11 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801CA_10), 12 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801CA_11), 13 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801DB_11), 14 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801EB_11), 15 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801E_11), 16 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801DB_10), 17 },
|
2005-04-16 18:20:36 -04:00
|
|
|
#ifdef CONFIG_BLK_DEV_IDE_SATA
|
2007-10-16 16:29:56 -04:00
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801EB_1), 18 },
|
2005-04-16 18:20:36 -04:00
|
|
|
#endif
|
2007-10-16 16:29:56 -04:00
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ESB_2), 19 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ICH6_19), 20 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ICH7_21), 21 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82801DB_1), 22 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ESB2_18), 23 },
|
|
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ICH8_6), 24 },
|
2005-04-16 18:20:36 -04:00
|
|
|
{ 0, },
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(pci, piix_pci_tbl);
|
|
|
|
|
|
|
|
static struct pci_driver driver = {
|
|
|
|
.name = "PIIX_IDE",
|
|
|
|
.id_table = piix_pci_tbl,
|
|
|
|
.probe = piix_init_one,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init piix_ide_init(void)
|
|
|
|
{
|
|
|
|
piix_check_450nx();
|
|
|
|
return ide_pci_register_driver(&driver);
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(piix_ide_init);
|
|
|
|
|
|
|
|
MODULE_AUTHOR("Andre Hedrick, Andrzej Krzysztofowicz");
|
|
|
|
MODULE_DESCRIPTION("PCI driver module for Intel PIIX IDE");
|
|
|
|
MODULE_LICENSE("GPL");
|