2008-02-08 07:20:09 -05:00
|
|
|
/* Copyright (c) 2007 Coraid, Inc. See COPYING for GPL terms. */
|
2005-04-16 18:20:36 -04:00
|
|
|
/*
|
|
|
|
* aoenet.c
|
|
|
|
* Ethernet portion of AoE driver
|
|
|
|
*/
|
|
|
|
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 04:04:11 -04:00
|
|
|
#include <linux/gfp.h>
|
2005-04-16 18:20:36 -04:00
|
|
|
#include <linux/hdreg.h>
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
#include <linux/netdevice.h>
|
2005-04-29 10:24:03 -04:00
|
|
|
#include <linux/moduleparam.h>
|
2007-09-17 14:53:39 -04:00
|
|
|
#include <net/net_namespace.h>
|
2007-03-01 21:30:08 -05:00
|
|
|
#include <asm/unaligned.h>
|
2005-04-16 18:20:36 -04:00
|
|
|
#include "aoe.h"
|
|
|
|
|
|
|
|
#define NECODES 5
|
|
|
|
|
|
|
|
static char *aoe_errlist[] =
|
|
|
|
{
|
|
|
|
"no such error",
|
|
|
|
"unrecognized command code",
|
|
|
|
"bad argument parameter",
|
|
|
|
"device unavailable",
|
|
|
|
"config string present",
|
|
|
|
"unsupported version"
|
|
|
|
};
|
|
|
|
|
|
|
|
enum {
|
|
|
|
IFLISTSZ = 1024,
|
|
|
|
};
|
|
|
|
|
|
|
|
static char aoe_iflist[IFLISTSZ];
|
2005-04-29 10:24:03 -04:00
|
|
|
module_param_string(aoe_iflist, aoe_iflist, IFLISTSZ, 0600);
|
2008-07-31 03:07:23 -04:00
|
|
|
MODULE_PARM_DESC(aoe_iflist, "aoe_iflist=\"dev1 [dev2 ...]\"");
|
2005-04-29 10:24:03 -04:00
|
|
|
|
|
|
|
#ifndef MODULE
|
|
|
|
static int __init aoe_iflist_setup(char *str)
|
|
|
|
{
|
|
|
|
strncpy(aoe_iflist, str, IFLISTSZ);
|
|
|
|
aoe_iflist[IFLISTSZ - 1] = '\0';
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
__setup("aoe_iflist=", aoe_iflist_setup);
|
|
|
|
#endif
|
2005-04-16 18:20:36 -04:00
|
|
|
|
|
|
|
int
|
|
|
|
is_aoe_netif(struct net_device *ifp)
|
|
|
|
{
|
|
|
|
register char *p, *q;
|
|
|
|
register int len;
|
|
|
|
|
|
|
|
if (aoe_iflist[0] == '\0')
|
|
|
|
return 1;
|
|
|
|
|
2005-04-29 10:24:03 -04:00
|
|
|
p = aoe_iflist + strspn(aoe_iflist, WHITESPACE);
|
|
|
|
for (; *p; p = q + strspn(q, WHITESPACE)) {
|
2005-04-16 18:20:36 -04:00
|
|
|
q = p + strcspn(p, WHITESPACE);
|
|
|
|
if (q != p)
|
|
|
|
len = q - p;
|
|
|
|
else
|
|
|
|
len = strlen(p); /* last token in aoe_iflist */
|
|
|
|
|
|
|
|
if (strlen(ifp->name) == len && !strncmp(ifp->name, p, len))
|
|
|
|
return 1;
|
|
|
|
if (q == p)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
set_aoe_iflist(const char __user *user_str, size_t size)
|
|
|
|
{
|
|
|
|
if (size >= IFLISTSZ)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (copy_from_user(aoe_iflist, user_str, size)) {
|
2006-09-20 14:36:51 -04:00
|
|
|
printk(KERN_INFO "aoe: copy from user failed\n");
|
2005-04-16 18:20:36 -04:00
|
|
|
return -EFAULT;
|
|
|
|
}
|
|
|
|
aoe_iflist[size] = 0x00;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
2008-09-22 01:36:49 -04:00
|
|
|
aoenet_xmit(struct sk_buff_head *queue)
|
2005-04-16 18:20:36 -04:00
|
|
|
{
|
2008-09-22 01:36:49 -04:00
|
|
|
struct sk_buff *skb, *tmp;
|
2005-04-16 18:20:36 -04:00
|
|
|
|
2008-09-23 23:47:22 -04:00
|
|
|
skb_queue_walk_safe(queue, skb, tmp) {
|
|
|
|
__skb_unlink(skb, queue);
|
2005-04-16 18:20:36 -04:00
|
|
|
dev_queue_xmit(skb);
|
2008-09-23 23:47:22 -04:00
|
|
|
}
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* (1) len doesn't include the header by default. I want this.
|
|
|
|
*/
|
|
|
|
static int
|
2005-08-09 22:34:12 -04:00
|
|
|
aoenet_rcv(struct sk_buff *skb, struct net_device *ifp, struct packet_type *pt, struct net_device *orig_dev)
|
2005-04-16 18:20:36 -04:00
|
|
|
{
|
|
|
|
struct aoe_hdr *h;
|
2005-04-19 01:00:20 -04:00
|
|
|
u32 n;
|
2005-04-16 18:20:36 -04:00
|
|
|
|
2008-03-25 08:47:49 -04:00
|
|
|
if (dev_net(ifp) != &init_net)
|
2007-09-17 14:53:39 -04:00
|
|
|
goto exit;
|
|
|
|
|
2006-02-07 11:26:39 -05:00
|
|
|
skb = skb_share_check(skb, GFP_ATOMIC);
|
|
|
|
if (skb == NULL)
|
2005-04-16 18:20:36 -04:00
|
|
|
return 0;
|
2006-06-09 19:10:40 -04:00
|
|
|
if (skb_linearize(skb))
|
2006-02-07 11:26:39 -05:00
|
|
|
goto exit;
|
2005-04-16 18:20:36 -04:00
|
|
|
if (!is_aoe_netif(ifp))
|
|
|
|
goto exit;
|
|
|
|
skb_push(skb, ETH_HLEN); /* (1) */
|
|
|
|
|
2007-10-17 02:27:03 -04:00
|
|
|
h = (struct aoe_hdr *) skb_mac_header(skb);
|
2008-04-29 04:03:30 -04:00
|
|
|
n = get_unaligned_be32(&h->tag);
|
2005-04-16 18:20:36 -04:00
|
|
|
if ((h->verfl & AOEFL_RSP) == 0 || (n & 1<<31))
|
|
|
|
goto exit;
|
|
|
|
|
|
|
|
if (h->verfl & AOEFL_ERR) {
|
|
|
|
n = h->err;
|
|
|
|
if (n > NECODES)
|
|
|
|
n = 0;
|
|
|
|
if (net_ratelimit())
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 07:20:00 -05:00
|
|
|
printk(KERN_ERR
|
|
|
|
"%s%d.%d@%s; ecode=%d '%s'\n",
|
|
|
|
"aoe: error packet from ",
|
2008-04-29 04:03:30 -04:00
|
|
|
get_unaligned_be16(&h->major),
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 07:20:00 -05:00
|
|
|
h->minor, skb->dev->name,
|
|
|
|
h->err, aoe_errlist[n]);
|
2005-04-16 18:20:36 -04:00
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (h->cmd) {
|
|
|
|
case AOECMD_ATA:
|
|
|
|
aoecmd_ata_rsp(skb);
|
|
|
|
break;
|
|
|
|
case AOECMD_CFG:
|
|
|
|
aoecmd_cfg_rsp(skb);
|
|
|
|
break;
|
|
|
|
default:
|
2009-02-18 17:48:13 -05:00
|
|
|
if (h->cmd >= AOECMD_VEND_MIN)
|
|
|
|
break; /* don't complain about vendor commands */
|
2006-09-20 14:36:51 -04:00
|
|
|
printk(KERN_INFO "aoe: unknown cmd %d\n", h->cmd);
|
2005-04-16 18:20:36 -04:00
|
|
|
}
|
|
|
|
exit:
|
|
|
|
dev_kfree_skb(skb);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-03-09 04:18:29 -04:00
|
|
|
static struct packet_type aoe_pt __read_mostly = {
|
2005-04-16 18:20:36 -04:00
|
|
|
.type = __constant_htons(ETH_P_AOE),
|
|
|
|
.func = aoenet_rcv,
|
|
|
|
};
|
|
|
|
|
|
|
|
int __init
|
|
|
|
aoenet_init(void)
|
|
|
|
{
|
|
|
|
dev_add_pack(&aoe_pt);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
aoenet_exit(void)
|
|
|
|
{
|
|
|
|
dev_remove_pack(&aoe_pt);
|
|
|
|
}
|
|
|
|
|