2005-12-15 17:29:43 -05:00
|
|
|
/* -*- mode: c; c-basic-offset: 8; -*-
|
|
|
|
* vim: noexpandtab sw=8 ts=8 sts=0:
|
|
|
|
*
|
|
|
|
* symlink.c - operations for configfs symlinks.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public
|
|
|
|
* License along with this program; if not, write to the
|
|
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
|
|
* Boston, MA 021110-1307, USA.
|
|
|
|
*
|
|
|
|
* Based on sysfs:
|
|
|
|
* sysfs is Copyright (C) 2001, 2002, 2003 Patrick Mochel
|
|
|
|
*
|
|
|
|
* configfs Copyright (C) 2005 Oracle. All rights reserved.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/namei.h>
|
|
|
|
|
|
|
|
#include <linux/configfs.h>
|
|
|
|
#include "configfs_internal.h"
|
|
|
|
|
2008-06-20 08:09:22 -04:00
|
|
|
/* Protects attachments of new symlinks */
|
|
|
|
DEFINE_MUTEX(configfs_symlink_mutex);
|
|
|
|
|
2005-12-15 17:29:43 -05:00
|
|
|
static int item_depth(struct config_item * item)
|
|
|
|
{
|
|
|
|
struct config_item * p = item;
|
|
|
|
int depth = 0;
|
|
|
|
do { depth++; } while ((p = p->ci_parent) && !configfs_is_root(p));
|
|
|
|
return depth;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int item_path_length(struct config_item * item)
|
|
|
|
{
|
|
|
|
struct config_item * p = item;
|
|
|
|
int length = 1;
|
|
|
|
do {
|
|
|
|
length += strlen(config_item_name(p)) + 1;
|
|
|
|
p = p->ci_parent;
|
|
|
|
} while (p && !configfs_is_root(p));
|
|
|
|
return length;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fill_item_path(struct config_item * item, char * buffer, int length)
|
|
|
|
{
|
|
|
|
struct config_item * p;
|
|
|
|
|
|
|
|
--length;
|
|
|
|
for (p = item; p && !configfs_is_root(p); p = p->ci_parent) {
|
|
|
|
int cur = strlen(config_item_name(p));
|
|
|
|
|
|
|
|
/* back up enough to print this bus id with '/' */
|
|
|
|
length -= cur;
|
|
|
|
strncpy(buffer + length,config_item_name(p),cur);
|
|
|
|
*(buffer + --length) = '/';
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int create_link(struct config_item *parent_item,
|
2006-03-10 14:42:30 -05:00
|
|
|
struct config_item *item,
|
2005-12-15 17:29:43 -05:00
|
|
|
struct dentry *dentry)
|
|
|
|
{
|
|
|
|
struct configfs_dirent *target_sd = item->ci_dentry->d_fsdata;
|
|
|
|
struct configfs_symlink *sl;
|
|
|
|
int ret;
|
|
|
|
|
[PATCH] configfs: Prevent userspace from creating new entries under attaching directories
process 1: process 2:
configfs_mkdir("A")
attach_group("A")
attach_item("A")
d_instantiate("A")
populate_groups("A")
mutex_lock("A")
attach_group("A/B")
attach_item("A")
d_instantiate("A/B")
mkdir("A/B/C")
do_path_lookup("A/B/C", LOOKUP_PARENT)
ok
lookup_create("A/B/C")
mutex_lock("A/B")
ok
configfs_mkdir("A/B/C")
ok
attach_group("A/C")
attach_item("A/C")
d_instantiate("A/C")
populate_groups("A/C")
mutex_lock("A/C")
attach_group("A/C/D")
attach_item("A/C/D")
failure
mutex_unlock("A/C")
detach_groups("A/C")
nothing to do
mkdir("A/C/E")
do_path_lookup("A/C/E", LOOKUP_PARENT)
ok
lookup_create("A/C/E")
mutex_lock("A/C")
ok
configfs_mkdir("A/C/E")
ok
detach_item("A/C")
d_delete("A/C")
mutex_unlock("A")
detach_groups("A")
mutex_lock("A/B")
detach_group("A/B")
detach_groups("A/B")
nothing since no _default_ group
detach_item("A/B")
mutex_unlock("A/B")
d_delete("A/B")
detach_item("A")
d_delete("A")
Two bugs:
1/ "A/B/C" and "A/C/E" are created, but never removed while their parent are
removed in the end. The same could happen with symlink() instead of mkdir().
2/ "A" and "A/C" inodes are not locked while detach_item() is called on them,
which may probably confuse VFS.
This commit fixes 1/, tagging new directories with CONFIGFS_USET_CREATING before
building the inode and instantiating the dentry, and validating the whole
group+default groups hierarchy in a second pass by clearing
CONFIGFS_USET_CREATING.
mkdir(), symlink(), lookup(), and dir_open() simply return -ENOENT if
called in (or linking to) a directory tagged with CONFIGFS_USET_CREATING. This
does not prevent userspace from calling stat() successfuly on such directories,
but this prevents userspace from adding (children to | symlinking from/to |
read/write attributes of | listing the contents of) not validated items. In
other words, userspace will not interact with the subsystem on a new item until
the new item creation completes correctly.
It was first proposed to re-use CONFIGFS_USET_IN_MKDIR instead of a new
flag CONFIGFS_USET_CREATING, but this generated conflicts when checking the
target of a new symlink: a valid target directory in the middle of attaching
a new user-created child item could be wrongly detected as being attached.
2/ is fixed by next commit.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
2008-07-04 10:56:05 -04:00
|
|
|
ret = -ENOENT;
|
|
|
|
if (!configfs_dirent_is_ready(target_sd))
|
|
|
|
goto out;
|
2005-12-15 17:29:43 -05:00
|
|
|
ret = -ENOMEM;
|
|
|
|
sl = kmalloc(sizeof(struct configfs_symlink), GFP_KERNEL);
|
|
|
|
if (sl) {
|
|
|
|
sl->sl_target = config_item_get(item);
|
2008-06-16 13:00:59 -04:00
|
|
|
spin_lock(&configfs_dirent_lock);
|
2008-06-23 08:16:17 -04:00
|
|
|
if (target_sd->s_type & CONFIGFS_USET_DROPPING) {
|
|
|
|
spin_unlock(&configfs_dirent_lock);
|
|
|
|
config_item_put(item);
|
|
|
|
kfree(sl);
|
|
|
|
return -ENOENT;
|
|
|
|
}
|
2005-12-15 17:29:43 -05:00
|
|
|
list_add(&sl->sl_list, &target_sd->s_links);
|
2008-06-16 13:00:59 -04:00
|
|
|
spin_unlock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
ret = configfs_create_link(sl, parent_item->ci_dentry,
|
|
|
|
dentry);
|
|
|
|
if (ret) {
|
2008-06-16 13:00:59 -04:00
|
|
|
spin_lock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
list_del_init(&sl->sl_list);
|
2008-06-16 13:00:59 -04:00
|
|
|
spin_unlock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
config_item_put(item);
|
|
|
|
kfree(sl);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[PATCH] configfs: Prevent userspace from creating new entries under attaching directories
process 1: process 2:
configfs_mkdir("A")
attach_group("A")
attach_item("A")
d_instantiate("A")
populate_groups("A")
mutex_lock("A")
attach_group("A/B")
attach_item("A")
d_instantiate("A/B")
mkdir("A/B/C")
do_path_lookup("A/B/C", LOOKUP_PARENT)
ok
lookup_create("A/B/C")
mutex_lock("A/B")
ok
configfs_mkdir("A/B/C")
ok
attach_group("A/C")
attach_item("A/C")
d_instantiate("A/C")
populate_groups("A/C")
mutex_lock("A/C")
attach_group("A/C/D")
attach_item("A/C/D")
failure
mutex_unlock("A/C")
detach_groups("A/C")
nothing to do
mkdir("A/C/E")
do_path_lookup("A/C/E", LOOKUP_PARENT)
ok
lookup_create("A/C/E")
mutex_lock("A/C")
ok
configfs_mkdir("A/C/E")
ok
detach_item("A/C")
d_delete("A/C")
mutex_unlock("A")
detach_groups("A")
mutex_lock("A/B")
detach_group("A/B")
detach_groups("A/B")
nothing since no _default_ group
detach_item("A/B")
mutex_unlock("A/B")
d_delete("A/B")
detach_item("A")
d_delete("A")
Two bugs:
1/ "A/B/C" and "A/C/E" are created, but never removed while their parent are
removed in the end. The same could happen with symlink() instead of mkdir().
2/ "A" and "A/C" inodes are not locked while detach_item() is called on them,
which may probably confuse VFS.
This commit fixes 1/, tagging new directories with CONFIGFS_USET_CREATING before
building the inode and instantiating the dentry, and validating the whole
group+default groups hierarchy in a second pass by clearing
CONFIGFS_USET_CREATING.
mkdir(), symlink(), lookup(), and dir_open() simply return -ENOENT if
called in (or linking to) a directory tagged with CONFIGFS_USET_CREATING. This
does not prevent userspace from calling stat() successfuly on such directories,
but this prevents userspace from adding (children to | symlinking from/to |
read/write attributes of | listing the contents of) not validated items. In
other words, userspace will not interact with the subsystem on a new item until
the new item creation completes correctly.
It was first proposed to re-use CONFIGFS_USET_IN_MKDIR instead of a new
flag CONFIGFS_USET_CREATING, but this generated conflicts when checking the
target of a new symlink: a valid target directory in the middle of attaching
a new user-created child item could be wrongly detected as being attached.
2/ is fixed by next commit.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
2008-07-04 10:56:05 -04:00
|
|
|
out:
|
2005-12-15 17:29:43 -05:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-08-02 01:04:36 -04:00
|
|
|
static int get_target(const char *symname, struct path *path,
|
2005-12-15 17:29:43 -05:00
|
|
|
struct config_item **target)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2008-08-02 01:04:36 -04:00
|
|
|
ret = kern_path(symname, LOOKUP_FOLLOW|LOOKUP_DIRECTORY, path);
|
2005-12-15 17:29:43 -05:00
|
|
|
if (!ret) {
|
2008-08-02 01:04:36 -04:00
|
|
|
if (path->dentry->d_sb == configfs_sb) {
|
|
|
|
*target = configfs_get_config_item(path->dentry);
|
2005-12-15 17:29:43 -05:00
|
|
|
if (!*target) {
|
|
|
|
ret = -ENOENT;
|
2008-08-02 01:04:36 -04:00
|
|
|
path_put(path);
|
2005-12-15 17:29:43 -05:00
|
|
|
}
|
|
|
|
} else
|
|
|
|
ret = -EPERM;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
int configfs_symlink(struct inode *dir, struct dentry *dentry, const char *symname)
|
|
|
|
{
|
|
|
|
int ret;
|
2008-08-02 01:04:36 -04:00
|
|
|
struct path path;
|
[PATCH] configfs: Prevent userspace from creating new entries under attaching directories
process 1: process 2:
configfs_mkdir("A")
attach_group("A")
attach_item("A")
d_instantiate("A")
populate_groups("A")
mutex_lock("A")
attach_group("A/B")
attach_item("A")
d_instantiate("A/B")
mkdir("A/B/C")
do_path_lookup("A/B/C", LOOKUP_PARENT)
ok
lookup_create("A/B/C")
mutex_lock("A/B")
ok
configfs_mkdir("A/B/C")
ok
attach_group("A/C")
attach_item("A/C")
d_instantiate("A/C")
populate_groups("A/C")
mutex_lock("A/C")
attach_group("A/C/D")
attach_item("A/C/D")
failure
mutex_unlock("A/C")
detach_groups("A/C")
nothing to do
mkdir("A/C/E")
do_path_lookup("A/C/E", LOOKUP_PARENT)
ok
lookup_create("A/C/E")
mutex_lock("A/C")
ok
configfs_mkdir("A/C/E")
ok
detach_item("A/C")
d_delete("A/C")
mutex_unlock("A")
detach_groups("A")
mutex_lock("A/B")
detach_group("A/B")
detach_groups("A/B")
nothing since no _default_ group
detach_item("A/B")
mutex_unlock("A/B")
d_delete("A/B")
detach_item("A")
d_delete("A")
Two bugs:
1/ "A/B/C" and "A/C/E" are created, but never removed while their parent are
removed in the end. The same could happen with symlink() instead of mkdir().
2/ "A" and "A/C" inodes are not locked while detach_item() is called on them,
which may probably confuse VFS.
This commit fixes 1/, tagging new directories with CONFIGFS_USET_CREATING before
building the inode and instantiating the dentry, and validating the whole
group+default groups hierarchy in a second pass by clearing
CONFIGFS_USET_CREATING.
mkdir(), symlink(), lookup(), and dir_open() simply return -ENOENT if
called in (or linking to) a directory tagged with CONFIGFS_USET_CREATING. This
does not prevent userspace from calling stat() successfuly on such directories,
but this prevents userspace from adding (children to | symlinking from/to |
read/write attributes of | listing the contents of) not validated items. In
other words, userspace will not interact with the subsystem on a new item until
the new item creation completes correctly.
It was first proposed to re-use CONFIGFS_USET_IN_MKDIR instead of a new
flag CONFIGFS_USET_CREATING, but this generated conflicts when checking the
target of a new symlink: a valid target directory in the middle of attaching
a new user-created child item could be wrongly detected as being attached.
2/ is fixed by next commit.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
2008-07-04 10:56:05 -04:00
|
|
|
struct configfs_dirent *sd;
|
2005-12-15 17:29:43 -05:00
|
|
|
struct config_item *parent_item;
|
2009-04-18 15:40:03 -04:00
|
|
|
struct config_item *target_item = NULL;
|
2005-12-15 17:29:43 -05:00
|
|
|
struct config_item_type *type;
|
|
|
|
|
|
|
|
ret = -EPERM; /* What lack-of-symlink returns */
|
|
|
|
if (dentry->d_parent == configfs_sb->s_root)
|
|
|
|
goto out;
|
|
|
|
|
[PATCH] configfs: Prevent userspace from creating new entries under attaching directories
process 1: process 2:
configfs_mkdir("A")
attach_group("A")
attach_item("A")
d_instantiate("A")
populate_groups("A")
mutex_lock("A")
attach_group("A/B")
attach_item("A")
d_instantiate("A/B")
mkdir("A/B/C")
do_path_lookup("A/B/C", LOOKUP_PARENT)
ok
lookup_create("A/B/C")
mutex_lock("A/B")
ok
configfs_mkdir("A/B/C")
ok
attach_group("A/C")
attach_item("A/C")
d_instantiate("A/C")
populate_groups("A/C")
mutex_lock("A/C")
attach_group("A/C/D")
attach_item("A/C/D")
failure
mutex_unlock("A/C")
detach_groups("A/C")
nothing to do
mkdir("A/C/E")
do_path_lookup("A/C/E", LOOKUP_PARENT)
ok
lookup_create("A/C/E")
mutex_lock("A/C")
ok
configfs_mkdir("A/C/E")
ok
detach_item("A/C")
d_delete("A/C")
mutex_unlock("A")
detach_groups("A")
mutex_lock("A/B")
detach_group("A/B")
detach_groups("A/B")
nothing since no _default_ group
detach_item("A/B")
mutex_unlock("A/B")
d_delete("A/B")
detach_item("A")
d_delete("A")
Two bugs:
1/ "A/B/C" and "A/C/E" are created, but never removed while their parent are
removed in the end. The same could happen with symlink() instead of mkdir().
2/ "A" and "A/C" inodes are not locked while detach_item() is called on them,
which may probably confuse VFS.
This commit fixes 1/, tagging new directories with CONFIGFS_USET_CREATING before
building the inode and instantiating the dentry, and validating the whole
group+default groups hierarchy in a second pass by clearing
CONFIGFS_USET_CREATING.
mkdir(), symlink(), lookup(), and dir_open() simply return -ENOENT if
called in (or linking to) a directory tagged with CONFIGFS_USET_CREATING. This
does not prevent userspace from calling stat() successfuly on such directories,
but this prevents userspace from adding (children to | symlinking from/to |
read/write attributes of | listing the contents of) not validated items. In
other words, userspace will not interact with the subsystem on a new item until
the new item creation completes correctly.
It was first proposed to re-use CONFIGFS_USET_IN_MKDIR instead of a new
flag CONFIGFS_USET_CREATING, but this generated conflicts when checking the
target of a new symlink: a valid target directory in the middle of attaching
a new user-created child item could be wrongly detected as being attached.
2/ is fixed by next commit.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
2008-07-04 10:56:05 -04:00
|
|
|
sd = dentry->d_parent->d_fsdata;
|
|
|
|
/*
|
|
|
|
* Fake invisibility if dir belongs to a group/default groups hierarchy
|
|
|
|
* being attached
|
|
|
|
*/
|
|
|
|
ret = -ENOENT;
|
|
|
|
if (!configfs_dirent_is_ready(sd))
|
|
|
|
goto out;
|
|
|
|
|
2005-12-15 17:29:43 -05:00
|
|
|
parent_item = configfs_get_config_item(dentry->d_parent);
|
|
|
|
type = parent_item->ci_type;
|
|
|
|
|
[PATCH] configfs: Prevent userspace from creating new entries under attaching directories
process 1: process 2:
configfs_mkdir("A")
attach_group("A")
attach_item("A")
d_instantiate("A")
populate_groups("A")
mutex_lock("A")
attach_group("A/B")
attach_item("A")
d_instantiate("A/B")
mkdir("A/B/C")
do_path_lookup("A/B/C", LOOKUP_PARENT)
ok
lookup_create("A/B/C")
mutex_lock("A/B")
ok
configfs_mkdir("A/B/C")
ok
attach_group("A/C")
attach_item("A/C")
d_instantiate("A/C")
populate_groups("A/C")
mutex_lock("A/C")
attach_group("A/C/D")
attach_item("A/C/D")
failure
mutex_unlock("A/C")
detach_groups("A/C")
nothing to do
mkdir("A/C/E")
do_path_lookup("A/C/E", LOOKUP_PARENT)
ok
lookup_create("A/C/E")
mutex_lock("A/C")
ok
configfs_mkdir("A/C/E")
ok
detach_item("A/C")
d_delete("A/C")
mutex_unlock("A")
detach_groups("A")
mutex_lock("A/B")
detach_group("A/B")
detach_groups("A/B")
nothing since no _default_ group
detach_item("A/B")
mutex_unlock("A/B")
d_delete("A/B")
detach_item("A")
d_delete("A")
Two bugs:
1/ "A/B/C" and "A/C/E" are created, but never removed while their parent are
removed in the end. The same could happen with symlink() instead of mkdir().
2/ "A" and "A/C" inodes are not locked while detach_item() is called on them,
which may probably confuse VFS.
This commit fixes 1/, tagging new directories with CONFIGFS_USET_CREATING before
building the inode and instantiating the dentry, and validating the whole
group+default groups hierarchy in a second pass by clearing
CONFIGFS_USET_CREATING.
mkdir(), symlink(), lookup(), and dir_open() simply return -ENOENT if
called in (or linking to) a directory tagged with CONFIGFS_USET_CREATING. This
does not prevent userspace from calling stat() successfuly on such directories,
but this prevents userspace from adding (children to | symlinking from/to |
read/write attributes of | listing the contents of) not validated items. In
other words, userspace will not interact with the subsystem on a new item until
the new item creation completes correctly.
It was first proposed to re-use CONFIGFS_USET_IN_MKDIR instead of a new
flag CONFIGFS_USET_CREATING, but this generated conflicts when checking the
target of a new symlink: a valid target directory in the middle of attaching
a new user-created child item could be wrongly detected as being attached.
2/ is fixed by next commit.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
2008-07-04 10:56:05 -04:00
|
|
|
ret = -EPERM;
|
2005-12-15 17:29:43 -05:00
|
|
|
if (!type || !type->ct_item_ops ||
|
|
|
|
!type->ct_item_ops->allow_link)
|
|
|
|
goto out_put;
|
|
|
|
|
2008-08-02 01:04:36 -04:00
|
|
|
ret = get_target(symname, &path, &target_item);
|
2005-12-15 17:29:43 -05:00
|
|
|
if (ret)
|
|
|
|
goto out_put;
|
|
|
|
|
|
|
|
ret = type->ct_item_ops->allow_link(parent_item, target_item);
|
2008-06-12 11:26:47 -04:00
|
|
|
if (!ret) {
|
2008-06-20 08:09:22 -04:00
|
|
|
mutex_lock(&configfs_symlink_mutex);
|
2005-12-15 17:29:43 -05:00
|
|
|
ret = create_link(parent_item, target_item, dentry);
|
2008-06-20 08:09:22 -04:00
|
|
|
mutex_unlock(&configfs_symlink_mutex);
|
2008-06-12 11:26:47 -04:00
|
|
|
if (ret && type->ct_item_ops->drop_link)
|
|
|
|
type->ct_item_ops->drop_link(parent_item,
|
|
|
|
target_item);
|
|
|
|
}
|
2005-12-15 17:29:43 -05:00
|
|
|
|
|
|
|
config_item_put(target_item);
|
2008-08-02 01:04:36 -04:00
|
|
|
path_put(&path);
|
2005-12-15 17:29:43 -05:00
|
|
|
|
|
|
|
out_put:
|
|
|
|
config_item_put(parent_item);
|
|
|
|
|
|
|
|
out:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int configfs_unlink(struct inode *dir, struct dentry *dentry)
|
|
|
|
{
|
|
|
|
struct configfs_dirent *sd = dentry->d_fsdata;
|
|
|
|
struct configfs_symlink *sl;
|
|
|
|
struct config_item *parent_item;
|
|
|
|
struct config_item_type *type;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = -EPERM; /* What lack-of-symlink returns */
|
|
|
|
if (!(sd->s_type & CONFIGFS_ITEM_LINK))
|
|
|
|
goto out;
|
|
|
|
|
2006-01-27 04:32:24 -05:00
|
|
|
BUG_ON(dentry->d_parent == configfs_sb->s_root);
|
2005-12-15 17:29:43 -05:00
|
|
|
|
|
|
|
sl = sd->s_element;
|
|
|
|
|
|
|
|
parent_item = configfs_get_config_item(dentry->d_parent);
|
|
|
|
type = parent_item->ci_type;
|
|
|
|
|
2008-06-16 13:00:58 -04:00
|
|
|
spin_lock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
list_del_init(&sd->s_sibling);
|
2008-06-16 13:00:58 -04:00
|
|
|
spin_unlock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
configfs_drop_dentry(sd, dentry->d_parent);
|
|
|
|
dput(dentry);
|
|
|
|
configfs_put(sd);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* drop_link() must be called before
|
|
|
|
* list_del_init(&sl->sl_list), so that the order of
|
|
|
|
* drop_link(this, target) and drop_item(target) is preserved.
|
|
|
|
*/
|
|
|
|
if (type && type->ct_item_ops &&
|
|
|
|
type->ct_item_ops->drop_link)
|
|
|
|
type->ct_item_ops->drop_link(parent_item,
|
|
|
|
sl->sl_target);
|
|
|
|
|
2008-06-16 13:00:59 -04:00
|
|
|
spin_lock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
list_del_init(&sl->sl_list);
|
2008-06-16 13:00:59 -04:00
|
|
|
spin_unlock(&configfs_dirent_lock);
|
2005-12-15 17:29:43 -05:00
|
|
|
|
|
|
|
/* Put reference from create_link() */
|
|
|
|
config_item_put(sl->sl_target);
|
|
|
|
kfree(sl);
|
|
|
|
|
|
|
|
config_item_put(parent_item);
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int configfs_get_target_path(struct config_item * item, struct config_item * target,
|
|
|
|
char *path)
|
|
|
|
{
|
|
|
|
char * s;
|
|
|
|
int depth, size;
|
|
|
|
|
|
|
|
depth = item_depth(item);
|
|
|
|
size = item_path_length(target) + depth * 3 - 1;
|
|
|
|
if (size > PATH_MAX)
|
|
|
|
return -ENAMETOOLONG;
|
|
|
|
|
2008-04-30 03:55:09 -04:00
|
|
|
pr_debug("%s: depth = %d, size = %d\n", __func__, depth, size);
|
2005-12-15 17:29:43 -05:00
|
|
|
|
|
|
|
for (s = path; depth--; s += 3)
|
|
|
|
strcpy(s,"../");
|
|
|
|
|
|
|
|
fill_item_path(target, path, size);
|
2008-04-30 03:55:09 -04:00
|
|
|
pr_debug("%s: path = '%s'\n", __func__, path);
|
2005-12-15 17:29:43 -05:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int configfs_getlink(struct dentry *dentry, char * path)
|
|
|
|
{
|
|
|
|
struct config_item *item, *target_item;
|
|
|
|
int error = 0;
|
|
|
|
|
|
|
|
item = configfs_get_config_item(dentry->d_parent);
|
|
|
|
if (!item)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
target_item = configfs_get_config_item(dentry);
|
|
|
|
if (!target_item) {
|
|
|
|
config_item_put(item);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
down_read(&configfs_rename_sem);
|
|
|
|
error = configfs_get_target_path(item, target_item, path);
|
|
|
|
up_read(&configfs_rename_sem);
|
|
|
|
|
|
|
|
config_item_put(item);
|
|
|
|
config_item_put(target_item);
|
|
|
|
return error;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *configfs_follow_link(struct dentry *dentry, struct nameidata *nd)
|
|
|
|
{
|
|
|
|
int error = -ENOMEM;
|
|
|
|
unsigned long page = get_zeroed_page(GFP_KERNEL);
|
|
|
|
|
|
|
|
if (page) {
|
|
|
|
error = configfs_getlink(dentry, (char *)page);
|
|
|
|
if (!error) {
|
|
|
|
nd_set_link(nd, (char *)page);
|
|
|
|
return (void *)page;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
nd_set_link(nd, ERR_PTR(error));
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void configfs_put_link(struct dentry *dentry, struct nameidata *nd,
|
|
|
|
void *cookie)
|
|
|
|
{
|
|
|
|
if (cookie) {
|
|
|
|
unsigned long page = (unsigned long)cookie;
|
|
|
|
free_page(page);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-02-12 03:55:38 -05:00
|
|
|
const struct inode_operations configfs_symlink_inode_operations = {
|
2005-12-15 17:29:43 -05:00
|
|
|
.follow_link = configfs_follow_link,
|
|
|
|
.readlink = generic_readlink,
|
|
|
|
.put_link = configfs_put_link,
|
2006-01-25 16:31:07 -05:00
|
|
|
.setattr = configfs_setattr,
|
2005-12-15 17:29:43 -05:00
|
|
|
};
|
|
|
|
|