lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

techpack: video: fix integer overflow issue for blur resolution

Browse Source 
Use S32_MAX instead of U32_MAX for maximum ctrl val for
blur resolution, as ctrl val is s32.

Change-Id: Ie92f6ba831ffead2d56c9eee24917b8a42cdd564
Signed-off-by: Qiwei Liu <qiweil@codeaurora.org>
This commit is contained in:
Qiwei Liu 2019-05-10 11:39:07 +08:00 committed by Gerrit - the friendly Code Review server
parent 70e7d6b0ba
commit 05f2237d39
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
msm/vidc/msm_venc.c
View File

@ -792,7 +792,7 @@ static struct msm_vidc_ctrl msm_venc_ctrls[] = {
.name = "Set Blur width/height",
.type = V4L2_CTRL_TYPE_INTEGER,
.minimum = 0,
.maximum = 0xFFFFFFFF,
.maximum = S32_MAX,
.default_value = 0,
.step = 1,
},
@ -3788,7 +3788,9 @@ int msm_venc_set_blur_resolution(struct msm_vidc_inst *inst)
frame_sz.buffer_type = HFI_BUFFER_INPUT;
frame_sz.height = ctrl->val & 0xFFFF;
frame_sz.width = (ctrl->val & 0xFFFF0000) >> 16;
frame_sz.width = (ctrl->val & 0x7FFF0000) >> 16;
dprintk(VIDC_DBG, "%s: type %u, height %u, width %u\n", __func__,
frame_sz.buffer_type, frame_sz.height, frame_sz.width);
rc = call_hfi_op(hdev, session_set_property, inst->session,
HFI_PROPERTY_CONFIG_VENC_BLUR_FRAME_SIZE, &frame_sz,
sizeof(frame_sz));