lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asoc: codecs: wcd938x: Add boundary checks before accessing array

Browse Source 
Add null checks before pointer access and array boundary
checks in tx mode function.

Change-Id: I8c8b086b4aed4185b1d1aee68cc9e7c42da6ae27
Signed-off-by: Karthikeyan Mani <kmani@codeaurora.org>
This commit is contained in:
Karthikeyan Mani 2019-05-01 15:31:52 -07:00
parent 9ef70dacaa
commit 09d510c699
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
asoc/codecs/wcd938x/wcd938x.c
View File

@ -1655,13 +1655,20 @@ static int wcd938x_tx_mode_get(struct snd_kcontrol *kcontrol,
snd_soc_dapm_kcontrol_widget(kcontrol);
struct snd_soc_component *component =
snd_soc_kcontrol_component(kcontrol);
struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
u32 path = 0;
struct wcd938x_priv *wcd938x = NULL;
int path = 0;
if (!widget || !widget->name || !wcd938x || !component)
if (!component)
return -EINVAL;
wcd938x = snd_soc_component_get_drvdata(component);
if (!widget || !widget->name || !wcd938x)
return -EINVAL;
path = wcd938x_tx_path_get(widget->name);
if (path < 0 || path >= TX_ADC_MAX)
return -EINVAL;
ucontrol->value.integer.value[0] = wcd938x->tx_mode[path];
@ -1675,14 +1682,22 @@ static int wcd938x_tx_mode_put(struct snd_kcontrol *kcontrol,
snd_soc_dapm_kcontrol_widget(kcontrol);
struct snd_soc_component *component =
snd_soc_kcontrol_component(kcontrol);
struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
struct wcd938x_priv *wcd938x = NULL;
u32 mode_val;
u32 path = 0;
int path = 0;
if (!widget || !widget->name || !wcd938x || !component)
if (!component)
return -EINVAL;
wcd938x = snd_soc_component_get_drvdata(component);
if (!widget || !widget->name || !wcd938x)
return -EINVAL;
path = wcd938x_tx_path_get(widget->name);
if (path < 0 || path >= TX_ADC_MAX)
return -EINVAL;
mode_val = ucontrol->value.enumerated.item[0];
dev_dbg(component->dev, "%s: mode: %d\n", __func__, mode_val);