lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Use vtable for reorder timeout

Browse Source 
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.

As part of that goal update the signature of the following function
and add that function to the vtable:
- wlan_hdd_cfg80211_wifi_set_reorder_timeout()

Change-Id: Ia9c160eb81358b91feecb35b1cb8c097f90979cc
CRs-Fixed: 2371593
This commit is contained in:
Jeff Johnson 2018-11-16 20:11:27 -08:00 committed by nshrivas
parent 1350e62148
commit 0dd687eda0
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/hdd/src/wlan_hdd_cfg80211.c
View File

@ -5458,16 +5458,17 @@ static int wlan_hdd_handle_restrict_offchan_config(struct hdd_adapter *adapter,
}
/**
* wlan_hdd_cfg80211_wifi_set_reorder_timeout - set reorder timeout
* @hdd_ctx: hdd context
* wlan_hdd_cfg80211_wifi_set_reorder_timeout() - set reorder timeout
* @adapter: Pointer to HDD adapter
* @tb: array of pointer to struct nlattr
*
* Return: 0 on success; error number otherwise
*/
static
int wlan_hdd_cfg80211_wifi_set_reorder_timeout(struct hdd_context *hdd_ctx,
int wlan_hdd_cfg80211_wifi_set_reorder_timeout(struct hdd_adapter *adapter,
struct nlattr *tb[])
{
struct hdd_context *hdd_ctx = WLAN_HDD_GET_CTX(adapter);
int ret_val = 0;
QDF_STATUS qdf_status;
struct sir_set_rx_reorder_timeout_val reorder_timeout;
@ -6521,6 +6522,7 @@ static const interdependent_setter_fn interdependent_setters[] = {
hdd_config_mpdu_aggregation,
hdd_config_ant_div_period,
hdd_config_ant_div_snr_weight,
wlan_hdd_cfg80211_wifi_set_reorder_timeout,
};
/**
@ -6609,11 +6611,6 @@ __wlan_hdd_cfg80211_wifi_configuration_set(struct wiphy *wiphy,
/* return errno here when all attributes have been refactored */
ret_val =
wlan_hdd_cfg80211_wifi_set_reorder_timeout(hdd_ctx, tb);
if (ret_val != 0)
return ret_val;
ret_val =
wlan_hdd_cfg80211_wifi_set_rx_blocksize(hdd_ctx, adapter, tb);
if (ret_val != 0)