lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backlight: lm3630a: Fix return code of .update_status() callback

Browse Source 
[ Upstream commit b9481a667a90ec739995e85f91f3672ca44d6ffa ]

According to <linux/backlight.h> .update_status() is supposed to
return 0 on success and a negative error code otherwise. Adapt
lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status() to
actually do it.

While touching that also add the error code to the failure message.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Uwe Kleine-König 2021-06-21 14:21:47 +02:00 committed by Greg Kroah-Hartman
parent 84d8414303
commit 0f3821c328
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/video/backlight/lm3630a_bl.c
View File

@ -188,7 +188,7 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
if ((pwm_ctrl & LM3630A_PWM_BANK_A) != 0) { if ((pwm_ctrl & LM3630A_PWM_BANK_A) != 0) {
lm3630a_pwm_ctrl(pchip, bl->props.brightness, lm3630a_pwm_ctrl(pchip, bl->props.brightness,
bl->props.max_brightness); bl->props.max_brightness);
return bl->props.brightness; return 0;
} }
/* disable sleep */ /* disable sleep */
@ -208,8 +208,8 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
return 0; return 0;
out_i2c_err: out_i2c_err:
dev_err(pchip->dev, "i2c failed to access\n"); dev_err(pchip->dev, "i2c failed to access (%pe)\n", ERR_PTR(ret));
return bl->props.brightness; return ret;
} }
static int lm3630a_bank_a_get_brightness(struct backlight_device *bl) static int lm3630a_bank_a_get_brightness(struct backlight_device *bl)
@ -265,7 +265,7 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
if ((pwm_ctrl & LM3630A_PWM_BANK_B) != 0) { if ((pwm_ctrl & LM3630A_PWM_BANK_B) != 0) {
lm3630a_pwm_ctrl(pchip, bl->props.brightness, lm3630a_pwm_ctrl(pchip, bl->props.brightness,
bl->props.max_brightness); bl->props.max_brightness);
return bl->props.brightness; return 0;
} }
/* disable sleep */ /* disable sleep */
@ -285,8 +285,8 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
return 0; return 0;
out_i2c_err: out_i2c_err:
dev_err(pchip->dev, "i2c failed to access REG_CTRL\n"); dev_err(pchip->dev, "i2c failed to access (%pe)\n", ERR_PTR(ret));
return bl->props.brightness; return ret;
} }
static int lm3630a_bank_b_get_brightness(struct backlight_device *bl) static int lm3630a_bank_b_get_brightness(struct backlight_device *bl)