diff --git a/drivers/rpmsg/qcom_glink_slatecom.c b/drivers/rpmsg/qcom_glink_slatecom.c index 79e241a04ce5..2786605c47aa 100644 --- a/drivers/rpmsg/qcom_glink_slatecom.c +++ b/drivers/rpmsg/qcom_glink_slatecom.c @@ -1900,7 +1900,7 @@ static void glink_slatecom_handle_rx_done(struct glink_slatecom *glink, mutex_unlock(&channel->intent_lock); } -static void glink_slatecom_process_cmd(struct glink_slatecom *glink, void *rx_data, +static int glink_slatecom_process_cmd(struct glink_slatecom *glink, void *rx_data, u32 rx_size) { struct glink_slatecom_msg *msg; @@ -1909,12 +1909,18 @@ static void glink_slatecom_process_cmd(struct glink_slatecom *glink, void *rx_da unsigned int param3; unsigned int param4; unsigned int cmd; - int offset = 0; - int ret; + u32 offset = 0; + int ret = 0; u16 name_len; char *name; while (offset < rx_size) { + if (rx_size - offset < sizeof(struct glink_slatecom_msg)) { + ret = -EBADMSG; + GLINK_ERR(glink, "%s: Error %d process cmd\n", __func__, ret); + return ret; + } + msg = (struct glink_slatecom_msg *)(rx_data + offset); offset += sizeof(*msg); @@ -1997,6 +2003,7 @@ static void glink_slatecom_process_cmd(struct glink_slatecom *glink, void *rx_da break; } } + return ret; } /**