lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: camera: isp: Remove redundant use of spin lock

Browse Source 
Interrupts in activated state machine are already
protected with spin_lock for context. No need to
reuse the spin_lock in interrupt handling routine.

CRs-Fixed: 2538876
Change-Id: Id86e7dc3419861cb8bce143c56923126a3dc3d3e
Signed-off-by: Vishalsingh Hajeri <vhajeri@codeaurora.org>
This commit is contained in:
Vishalsingh Hajeri 2019-10-09 17:21:41 -07:00 committed by Gerrit - the friendly Code Review server
parent 259e6f55d0
commit 1aadfe80e8
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/cam_isp/cam_isp_context.c
View File

@ -810,21 +810,17 @@ static int __cam_isp_ctx_notify_sof_in_activated_state(
return rc; return rc;
} }
spin_lock_bh(&ctx->lock);
req = list_first_entry(&ctx->active_req_list, req = list_first_entry(&ctx->active_req_list,
struct cam_ctx_request, list); struct cam_ctx_request, list);
req_isp = (struct cam_isp_ctx_req *) req->req_priv; req_isp = (struct cam_isp_ctx_req *) req->req_priv;
spin_unlock_bh(&ctx->lock);
if (ctx_isp->bubble_frame_cnt >= 1 && if (ctx_isp->bubble_frame_cnt >= 1 &&
req_isp->bubble_detected) { req_isp->bubble_detected) {
req_isp->num_acked = 0; req_isp->num_acked = 0;
ctx_isp->bubble_frame_cnt = 0; ctx_isp->bubble_frame_cnt = 0;
req_isp->bubble_detected = false; req_isp->bubble_detected = false;
spin_lock_bh(&ctx->lock);
list_del_init(&req->list); list_del_init(&req->list);
list_add(&req->list, &ctx->pending_req_list); list_add(&req->list, &ctx->pending_req_list);
spin_unlock_bh(&ctx->lock);
atomic_set(&ctx_isp->process_bubble, 0); atomic_set(&ctx_isp->process_bubble, 0);
ctx_isp->active_req_cnt--; ctx_isp->active_req_cnt--;
CAM_DBG(CAM_REQ, CAM_DBG(CAM_REQ,