lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remoteproc: sysmon: fix memory leak in qcom_add_sysmon_subdev()

Browse Source 
[ Upstream commit e01ce676aaef3b13d02343d7e70f9637d93a3367 ]

The kfree() should be called when of_irq_get_byname() fails or
devm_request_threaded_irq() fails in qcom_add_sysmon_subdev(),
otherwise there will be a memory leak, so add kfree() to fix it.

Fixes: 027045a6e2 ("remoteproc: qcom: Add shutdown-ack irq")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20221129105650.1539187-1-cuigaosheng1@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Gaosheng Cui 2022-11-29 18:56:50 +08:00 committed by Greg Kroah-Hartman
parent 292c0f3b4a
commit 27441fab26
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/remoteproc/qcom_sysmon.c
View File

@ -518,7 +518,9 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
if (sysmon->shutdown_irq != -ENODATA) { if (sysmon->shutdown_irq != -ENODATA) {
dev_err(sysmon->dev, dev_err(sysmon->dev,
"failed to retrieve shutdown-ack IRQ\n"); "failed to retrieve shutdown-ack IRQ\n");
return ERR_PTR(sysmon->shutdown_irq); ret = sysmon->shutdown_irq;
kfree(sysmon);
return ERR_PTR(ret);
} }
} else { } else {
ret = devm_request_threaded_irq(sysmon->dev, ret = devm_request_threaded_irq(sysmon->dev,
@ -529,6 +531,7 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
if (ret) { if (ret) {
dev_err(sysmon->dev, dev_err(sysmon->dev,
"failed to acquire shutdown-ack IRQ\n"); "failed to acquire shutdown-ack IRQ\n");
kfree(sysmon);
return ERR_PTR(ret); return ERR_PTR(ret);
} }
} }