lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: camera: common: Fix integer overflow in shift

Browse Source 
Various drivers are using right shift  by 32 to check if dma address is
32 bit addressable. This will result in shift count overflow in 32 bit
arch.

CRs-Fixed: 2543730
Change-Id: I57e30bc9c0a8179c8d74f3bd3b6567bdfff60741
Signed-off-by: Trishansh Bhardwaj <tbhardwa@codeaurora.org>
This commit is contained in:
Trishansh Bhardwaj 2019-10-30 15:22:06 +05:30
parent c23b668890
commit 30b9eed071
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/cam_icp/icp_hw/icp_hw_mgr/cam_icp_hw_mgr.c
View File

@ -4490,7 +4490,7 @@ static void cam_icp_mgr_print_io_bufs(struct cam_packet *packet,
"get src buf address fail rc %d", rc);
continue;
}
if (iova_addr >> 32) {
if ((iova_addr & 0xFFFFFFFF) != iova_addr) {
CAM_ERR(CAM_ICP, "Invalid mapped address");
rc = -EINVAL;
continue;

2
drivers/cam_isp/isp_hw_mgr/cam_ife_hw_mgr.c
View File

@ -5740,7 +5740,7 @@ static void cam_ife_mgr_print_io_bufs(struct cam_packet *packet,
io_cfg[i].mem_handle[j]);
continue;
}
if (iova_addr >> 32) {
if ((iova_addr & 0xFFFFFFFF) != iova_addr) {
CAM_ERR(CAM_ISP, "Invalid mapped address");
rc = -EINVAL;
continue;

2
drivers/cam_jpeg/jpeg_hw/cam_jpeg_hw_mgr.c
View File

@ -656,7 +656,7 @@ static void cam_jpeg_mgr_print_io_bufs(struct cam_packet *packet,
CAM_ERR(CAM_UTIL, "get src buf address fail");
continue;
}
if (iova_addr >> 32) {
if ((iova_addr & 0xFFFFFFFF) != iova_addr) {
CAM_ERR(CAM_JPEG, "Invalid mapped address");
rc = -EINVAL;
continue;